| Message ID | 20220907113400.12982-1-broonie@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 33060a64901e61f09ea6faffe367551df18a54c3 |
| Headers | show |
| Series | kselftest/arm64: Fix typo in hwcap check | expand |
On Wed, 7 Sep 2022 12:33:59 +0100, Mark Brown wrote: > We use a local variable hwcap to refer to the element of the hwcaps array > which we are currently checking. When checking for the relevant hwcap bit > being set in testing we were dereferencing hwcaps rather than hwcap in > fetching the AT_HWCAP to use, which is perfectly valid C but means we were > always checking the bit was set in the hwcap for whichever feature is first > in the array. Remove the stray s. > > [...] Applied to arm64 (for-next/kselftest), thanks! [1/1] kselftest/arm64: Fix typo in hwcap check https://git.kernel.org/arm64/c/33060a64901e
diff --git a/tools/testing/selftests/arm64/abi/hwcap.c b/tools/testing/selftests/arm64/abi/hwcap.c index 322d9b92bbe3..75eb470eb432 100644 --- a/tools/testing/selftests/arm64/abi/hwcap.c +++ b/tools/testing/selftests/arm64/abi/hwcap.c @@ -307,7 +307,7 @@ int main(void) for (i = 0; i < ARRAY_SIZE(hwcaps); i++) { hwcap = &hwcaps[i]; - have_hwcap = getauxval(hwcaps->at_hwcap) & hwcap->hwcap_bit; + have_hwcap = getauxval(hwcap->at_hwcap) & hwcap->hwcap_bit; have_cpuinfo = cpuinfo_present(hwcap->cpuinfo); if (have_hwcap)
We use a local variable hwcap to refer to the element of the hwcaps array which we are currently checking. When checking for the relevant hwcap bit being set in testing we were dereferencing hwcaps rather than hwcap in fetching the AT_HWCAP to use, which is perfectly valid C but means we were always checking the bit was set in the hwcap for whichever feature is first in the array. Remove the stray s. Signed-off-by: Mark Brown <broonie@kernel.org> --- tools/testing/selftests/arm64/abi/hwcap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)