| Message ID | 20220909103901.1503436-1-mic@digikod.net (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | de3ee3f63400a23954e7c1ad1cb8c20f29ab6fe3 |
| Headers | show |
| Series | [v1] selftests: Use optional USERCFLAGS and USERLDFLAGS | expand |
Hi Shuah, what do you think about this patch? On 09/09/2022 12:39, Mickaël Salaün wrote: > This change enables to extend CFLAGS and LDFLAGS from command line, e.g. > to extend compiler checks: make USERCFLAGS=-Werror USERLDFLAGS=-static > > USERCFLAGS and USERLDFLAGS are documented in > Documentation/kbuild/makefiles.rst and Documentation/kbuild/kbuild.rst > > This should be backported (down to 5.10) to improve previous kernel > versions testing as well. > > Cc: Shuah Khan <skhan@linuxfoundation.org> > Cc: stable@vger.kernel.org > Signed-off-by: Mickaël Salaün <mic@digikod.net> > Link: https://lore.kernel.org/r/20220909103901.1503436-1-mic@digikod.net > --- > tools/testing/selftests/lib.mk | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/tools/testing/selftests/lib.mk b/tools/testing/selftests/lib.mk > index d44c72b3abe3..da47a0257165 100644 > --- a/tools/testing/selftests/lib.mk > +++ b/tools/testing/selftests/lib.mk > @@ -119,6 +119,11 @@ endef > clean: > $(CLEAN) > > +# Enables to extend CFLAGS and LDFLAGS from command line, e.g. > +# make USERCFLAGS=-Werror USERLDFLAGS=-static > +CFLAGS += $(USERCFLAGS) > +LDFLAGS += $(USERLDFLAGS) > + > # When make O= with kselftest target from main level > # the following aren't defined. > # > > base-commit: 7e18e42e4b280c85b76967a9106a13ca61c16179
On 10/20/22 08:17, Mickaël Salaün wrote: > Hi Shuah, what do you think about this patch? > Thanks for the ping. > On 09/09/2022 12:39, Mickaël Salaün wrote: >> This change enables to extend CFLAGS and LDFLAGS from command line, e.g. >> to extend compiler checks: make USERCFLAGS=-Werror USERLDFLAGS=-static >> >> USERCFLAGS and USERLDFLAGS are documented in >> Documentation/kbuild/makefiles.rst and Documentation/kbuild/kbuild.rst >> >> This should be backported (down to 5.10) to improve previous kernel >> versions testing as well. >> >> Cc: Shuah Khan <skhan@linuxfoundation.org> >> Cc: stable@vger.kernel.org >> Signed-off-by: Mickaël Salaün <mic@digikod.net> >> Link: https://lore.kernel.org/r/20220909103901.1503436-1-mic@digikod.net >> --- >> tools/testing/selftests/lib.mk | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/tools/testing/selftests/lib.mk b/tools/testing/selftests/lib.mk >> index d44c72b3abe3..da47a0257165 100644 >> --- a/tools/testing/selftests/lib.mk >> +++ b/tools/testing/selftests/lib.mk >> @@ -119,6 +119,11 @@ endef >> clean: >> $(CLEAN) >> +# Enables to extend CFLAGS and LDFLAGS from command line, e.g. >> +# make USERCFLAGS=-Werror USERLDFLAGS=-static >> +CFLAGS += $(USERCFLAGS) >> +LDFLAGS += $(USERLDFLAGS) >> + >> # When make O= with kselftest target from main level >> # the following aren't defined. >> # >> >> base-commit: 7e18e42e4b280c85b76967a9106a13ca61c16179 Sorry for the delay. Looks good to me. I will apply to next to get some soak time and get this into 6.2. thanks, -- Shuah
diff --git a/tools/testing/selftests/lib.mk b/tools/testing/selftests/lib.mk index d44c72b3abe3..da47a0257165 100644 --- a/tools/testing/selftests/lib.mk +++ b/tools/testing/selftests/lib.mk @@ -119,6 +119,11 @@ endef clean: $(CLEAN) +# Enables to extend CFLAGS and LDFLAGS from command line, e.g. +# make USERCFLAGS=-Werror USERLDFLAGS=-static +CFLAGS += $(USERCFLAGS) +LDFLAGS += $(USERLDFLAGS) + # When make O= with kselftest target from main level # the following aren't defined. #
This change enables to extend CFLAGS and LDFLAGS from command line, e.g. to extend compiler checks: make USERCFLAGS=-Werror USERLDFLAGS=-static USERCFLAGS and USERLDFLAGS are documented in Documentation/kbuild/makefiles.rst and Documentation/kbuild/kbuild.rst This should be backported (down to 5.10) to improve previous kernel versions testing as well. Cc: Shuah Khan <skhan@linuxfoundation.org> Cc: stable@vger.kernel.org Signed-off-by: Mickaël Salaün <mic@digikod.net> Link: https://lore.kernel.org/r/20220909103901.1503436-1-mic@digikod.net --- tools/testing/selftests/lib.mk | 5 +++++ 1 file changed, 5 insertions(+) base-commit: 7e18e42e4b280c85b76967a9106a13ca61c16179