| Message ID | 20221205084429.570654-1-linmq006@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 8f4ab7da904ab7027ccd43ddb4f0094e932a5877 |
| Headers | show |
| Series | selftests/powerpc: Fix resource leaks | expand |
On Mon, 5 Dec 2022 12:44:27 +0400, Miaoqian Lin wrote: > In check_all_cpu_dscr_defaults, opendir() opens the directory stream. > Add missing closedir() in the error path to release it. > > In check_cpu_dscr_default, open() creates an open file descriptor. > Add missing close() in the error path to release it. > > > [...] Applied to powerpc/next. [1/1] selftests/powerpc: Fix resource leaks https://git.kernel.org/powerpc/c/8f4ab7da904ab7027ccd43ddb4f0094e932a5877 cheers
diff --git a/tools/testing/selftests/powerpc/dscr/dscr_sysfs_test.c b/tools/testing/selftests/powerpc/dscr/dscr_sysfs_test.c index fbbdffdb2e5d..f20d1c166d1e 100644 --- a/tools/testing/selftests/powerpc/dscr/dscr_sysfs_test.c +++ b/tools/testing/selftests/powerpc/dscr/dscr_sysfs_test.c @@ -24,6 +24,7 @@ static int check_cpu_dscr_default(char *file, unsigned long val) rc = read(fd, buf, sizeof(buf)); if (rc == -1) { perror("read() failed"); + close(fd); return 1; } close(fd); @@ -65,8 +66,10 @@ static int check_all_cpu_dscr_defaults(unsigned long val) if (access(file, F_OK)) continue; - if (check_cpu_dscr_default(file, val)) + if (check_cpu_dscr_default(file, val)) { + closedir(sysfs); return 1; + } } closedir(sysfs); return 0;
In check_all_cpu_dscr_defaults, opendir() opens the directory stream. Add missing closedir() in the error path to release it. In check_cpu_dscr_default, open() creates an open file descriptor. Add missing close() in the error path to release it. Fixes: ebd5858c904b ("selftests/powerpc: Add test for all DSCR sysfs interfaces") Signed-off-by: Miaoqian Lin <linmq006@gmail.com> --- tools/testing/selftests/powerpc/dscr/dscr_sysfs_test.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)