diff mbox series

[net-next,v2,1/4] mptcp: avoid unneeded address copy

Message ID 20230324-upstream-net-next-20230324-misc-features-v2-1-fca1471efbaa@tessares.net (mailing list archive)
State Accepted
Commit 2bb9a37f0e194ed95c70603b0efc7898a5a0d9b4
Headers show
Series mptcp: a couple of cleanups and improvements | expand

Commit Message

Matthieu Baerts March 27, 2023, 10:22 a.m. UTC 
From: Paolo Abeni <pabeni@redhat.com>

In the syn_recv fallback path, the msk is unused. We can skip
setting the socket address.

Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Reviewed-by: Matthieu Baerts <matthieu.baerts@tessares.net>
Signed-off-by: Matthieu Baerts <matthieu.baerts@tessares.net>
---
 net/mptcp/subflow.c | 2 --
 1 file changed, 2 deletions(-)
diff mbox series

Patch

diff --git a/net/mptcp/subflow.c b/net/mptcp/subflow.c
index dadaf85db720..a11f4c525e01 100644
--- a/net/mptcp/subflow.c
+++ b/net/mptcp/subflow.c
@@ -821,8 +821,6 @@  static struct sock *subflow_syn_recv_sock(const struct sock *sk,
 				goto dispose_child;
 			}
 
-			if (new_msk)
-				mptcp_copy_inaddrs(new_msk, child);
 			mptcp_subflow_drop_ctx(child);
 			goto out;
 		}