| Message ID | 20230327115331.122562-1-hca@linux.ibm.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 7232282dd47cce6a780c9414bd9baccf232c7686 |
| Delegated to: | Brendan Higgins |
| Headers | show |
| Series | kunit: increase KUNIT_LOG_SIZE to 2048 bytes | expand |
On Mon, Mar 27, 2023 at 7:53 AM Heiko Carstens <hca@linux.ibm.com> wrote: > > The s390 specific test_unwind kunit test has 39 parameterized tests. The > results in debugfs are truncated since the full log doesn't fit into 1500 > bytes. > Therefore increase KUNIT_LOG_SIZE to 2048 bytes in a similar way like it > was done recently with commit "kunit: fix bug in debugfs logs of > parameterized tests". With that the whole test result is present. > > Reported-by: Alexander Egorenkov <egorenar@linux.ibm.com> > Signed-off-by: Heiko Carstens <hca@linux.ibm.com> > --- This looks good to me. I don't see an issue increasing the log size. Maybe eventually we could create a config option or test attribute for a large log size but for now this seems good. Glad to see people are starting to get use of the parameterized test logs after the debugfs fixes. Thanks! -Rae Reviewed-by: Rae Moar <rmoar@google.com> > include/kunit/test.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/kunit/test.h b/include/kunit/test.h > index 9721584027d8..57b309c6ca27 100644 > --- a/include/kunit/test.h > +++ b/include/kunit/test.h > @@ -34,7 +34,7 @@ DECLARE_STATIC_KEY_FALSE(kunit_running); > struct kunit; > > /* Size of log associated with test. */ > -#define KUNIT_LOG_SIZE 1500 > +#define KUNIT_LOG_SIZE 2048 > > /* Maximum size of parameter description string. */ > #define KUNIT_PARAM_DESC_SIZE 128 > -- > 2.37.2 >
On Mon, 27 Mar 2023 at 19:53, Heiko Carstens <hca@linux.ibm.com> wrote: > > The s390 specific test_unwind kunit test has 39 parameterized tests. The > results in debugfs are truncated since the full log doesn't fit into 1500 > bytes. > Therefore increase KUNIT_LOG_SIZE to 2048 bytes in a similar way like it > was done recently with commit "kunit: fix bug in debugfs logs of > parameterized tests". With that the whole test result is present. > > Reported-by: Alexander Egorenkov <egorenar@linux.ibm.com> > Signed-off-by: Heiko Carstens <hca@linux.ibm.com> > --- Thanks! This looks fine here. Reviewed-by: David Gow <davidgow@google.com> -- David > include/kunit/test.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/kunit/test.h b/include/kunit/test.h > index 9721584027d8..57b309c6ca27 100644 > --- a/include/kunit/test.h > +++ b/include/kunit/test.h > @@ -34,7 +34,7 @@ DECLARE_STATIC_KEY_FALSE(kunit_running); > struct kunit; > > /* Size of log associated with test. */ > -#define KUNIT_LOG_SIZE 1500 > +#define KUNIT_LOG_SIZE 2048 > > /* Maximum size of parameter description string. */ > #define KUNIT_PARAM_DESC_SIZE 128 > -- > 2.37.2 >
diff --git a/include/kunit/test.h b/include/kunit/test.h index 9721584027d8..57b309c6ca27 100644 --- a/include/kunit/test.h +++ b/include/kunit/test.h @@ -34,7 +34,7 @@ DECLARE_STATIC_KEY_FALSE(kunit_running); struct kunit; /* Size of log associated with test. */ -#define KUNIT_LOG_SIZE 1500 +#define KUNIT_LOG_SIZE 2048 /* Maximum size of parameter description string. */ #define KUNIT_PARAM_DESC_SIZE 128
The s390 specific test_unwind kunit test has 39 parameterized tests. The results in debugfs are truncated since the full log doesn't fit into 1500 bytes. Therefore increase KUNIT_LOG_SIZE to 2048 bytes in a similar way like it was done recently with commit "kunit: fix bug in debugfs logs of parameterized tests". With that the whole test result is present. Reported-by: Alexander Egorenkov <egorenar@linux.ibm.com> Signed-off-by: Heiko Carstens <hca@linux.ibm.com> --- include/kunit/test.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)