diff mbox series

[v4,1/3] tracing/user_events: Fix incorrect return value for writing operation when events are disabled

Message ID 20230626111344.19136-2-sunliming@kylinos.cn (mailing list archive)
State Accepted
Commit f6d026eea390d59787a6cdc2ef5c983d02e029d0
Headers show
Series tracing/user_events: Fix incorrect return value for writes when events are disabled and add its tests | expand

Commit Message

sunliming June 26, 2023, 11:13 a.m. UTC 
The writing operation return the count of writes regardless of whether events
are enabled or disabled. Switch it to return -EBADF to indicates that the event
is disabled.

Signed-off-by: sunliming <sunliming@kylinos.cn>
---
 kernel/trace/trace_events_user.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/kernel/trace/trace_events_user.c b/kernel/trace/trace_events_user.c
index 1ac5ba5685ed..146bb2e9758f 100644
--- a/kernel/trace/trace_events_user.c
+++ b/kernel/trace/trace_events_user.c
@@ -1957,7 +1957,8 @@  static ssize_t user_events_write_core(struct file *file, struct iov_iter *i)
 
 		if (unlikely(faulted))
 			return -EFAULT;
-	}
+	} else
+		return -EBADF;
 
 	return ret;
 }