| Message ID | 20230713131932.133258-4-ilpo.jarvinen@linux.intel.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | f99e413eb54652e2436cc56d081176bc9a34cd8d |
| Headers | show |
| Series | selftests/resctrl: Fixes and cleanups | expand |
Hi Ilpo, On 7/13/2023 6:19 AM, Ilpo Järvinen wrote: > A child calls PARENT_EXIT() when it fails to run a benchmark to kill > the parent process. PARENT_EXIT() lacks unmount for the resctrl FS and > the parent won't be there to unmount it either after it gets killed. > > Add the resctrl FS unmount also to PARENT_EXIT(). > > Fixes: 591a6e8588fc ("selftests/resctrl: Add basic resctrl file system operations and data") > Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> Thank you. Reviewed-by: Reinette Chatre <reinette.chatre@intel.com> Reinette
diff --git a/tools/testing/selftests/resctrl/resctrl.h b/tools/testing/selftests/resctrl/resctrl.h index 87e39456dee0..f455f0b7e314 100644 --- a/tools/testing/selftests/resctrl/resctrl.h +++ b/tools/testing/selftests/resctrl/resctrl.h @@ -43,6 +43,7 @@ do { \ perror(err_msg); \ kill(ppid, SIGKILL); \ + umount_resctrlfs(); \ exit(EXIT_FAILURE); \ } while (0)
A child calls PARENT_EXIT() when it fails to run a benchmark to kill the parent process. PARENT_EXIT() lacks unmount for the resctrl FS and the parent won't be there to unmount it either after it gets killed. Add the resctrl FS unmount also to PARENT_EXIT(). Fixes: 591a6e8588fc ("selftests/resctrl: Add basic resctrl file system operations and data") Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> --- tools/testing/selftests/resctrl/resctrl.h | 1 + 1 file changed, 1 insertion(+)