| Message ID | 20230718034351.1373857-1-minachou@andestech.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | selftests/filesystems: Add six consecutive 'x' characters to mktemp | expand |
Hui Min Mina Chou <minachou@andestech.com> writes: > In busybox, the mktemp requires that the generated filename be > suffixed with at least six consecutive 'X' characters. Otherwise, > it will return an "Invalid argument" error. > > Signed-off-by: Hui Min Mina Chou <minachou@andestech.com> > --- Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
On 7/18/23 00:31, Javier Martinez Canillas wrote: > Hui Min Mina Chou <minachou@andestech.com> writes: > >> In busybox, the mktemp requires that the generated filename be >> suffixed with at least six consecutive 'X' characters. Otherwise, >> it will return an "Invalid argument" error. >> >> Signed-off-by: Hui Min Mina Chou <minachou@andestech.com> >> --- > > Reviewed-by: Javier Martinez Canillas <javierm@redhat.com> > Applied to linux-kselftest next for Linux 6.6-rc1. thanks, -- Shuah
diff --git a/tools/testing/selftests/filesystems/fat/run_fat_tests.sh b/tools/testing/selftests/filesystems/fat/run_fat_tests.sh index 7f35dc3d15df..d61264d4795d 100755 --- a/tools/testing/selftests/filesystems/fat/run_fat_tests.sh +++ b/tools/testing/selftests/filesystems/fat/run_fat_tests.sh @@ -12,7 +12,7 @@ set -u set -o pipefail BASE_DIR="$(dirname $0)" -TMP_DIR="$(mktemp -d /tmp/fat_tests_tmp.XXXX)" +TMP_DIR="$(mktemp -d /tmp/fat_tests_tmp.XXXXXX)" IMG_PATH="${TMP_DIR}/fat.img" MNT_PATH="${TMP_DIR}/mnt"
In busybox, the mktemp requires that the generated filename be suffixed with at least six consecutive 'X' characters. Otherwise, it will return an "Invalid argument" error. Signed-off-by: Hui Min Mina Chou <minachou@andestech.com> --- tools/testing/selftests/filesystems/fat/run_fat_tests.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)