| Message ID | 20230812084036.1834188-1-shaozhengchao@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | e56e220d73caf06e9e6f5553f414376b4af51c8a |
| Headers | show |
| Series | [net-next] selftests: bonding: remove redundant delete action of device link1_1 | expand |
Hello: This patch was applied to netdev/net-next.git (main) by David S. Miller <davem@davemloft.net>: On Sat, 12 Aug 2023 16:40:36 +0800 you wrote: > When run command "ip netns delete client", device link1_1 has been > deleted. So, it is no need to delete link1_1 again. Remove it. > > Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com> > --- > .../drivers/net/bonding/bond-arp-interval-causes-panic.sh | 1 - > 1 file changed, 1 deletion(-) Here is the summary with links: - [net-next] selftests: bonding: remove redundant delete action of device link1_1 https://git.kernel.org/netdev/net-next/c/e56e220d73ca You are awesome, thank you!
On Sat, Aug 12, 2023 at 04:40:36PM +0800, Zhengchao Shao wrote: > When run command "ip netns delete client", device link1_1 has been > deleted. So, it is no need to delete link1_1 again. Remove it. What if the test exit because the cmd execute failed before setting link1_1 to netns client? Thanks Hangbin > > Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com> > --- > .../drivers/net/bonding/bond-arp-interval-causes-panic.sh | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/tools/testing/selftests/drivers/net/bonding/bond-arp-interval-causes-panic.sh b/tools/testing/selftests/drivers/net/bonding/bond-arp-interval-causes-panic.sh > index 71c00bfafbc9..7b2d421f09cf 100755 > --- a/tools/testing/selftests/drivers/net/bonding/bond-arp-interval-causes-panic.sh > +++ b/tools/testing/selftests/drivers/net/bonding/bond-arp-interval-causes-panic.sh > @@ -11,7 +11,6 @@ finish() > { > ip netns delete server || true > ip netns delete client || true > - ip link del link1_1 || true > } > > trap finish EXIT > -- > 2.34.1 >
On 2023/8/16 14:11, Hangbin Liu wrote: > On Sat, Aug 12, 2023 at 04:40:36PM +0800, Zhengchao Shao wrote: >> When run command "ip netns delete client", device link1_1 has been >> deleted. So, it is no need to delete link1_1 again. Remove it. > Hi Hangbin: > What if the test exit because the cmd execute failed before setting > link1_1 to netns client? > > Thanks > Hangbin >> Your consideration is indeed possible. "ip link del link1_1 >/dev/null 2>&1" maybe looks better? Zhengchao Shao >> Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com> >> --- >> .../drivers/net/bonding/bond-arp-interval-causes-panic.sh | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/tools/testing/selftests/drivers/net/bonding/bond-arp-interval-causes-panic.sh b/tools/testing/selftests/drivers/net/bonding/bond-arp-interval-causes-panic.sh >> index 71c00bfafbc9..7b2d421f09cf 100755 >> --- a/tools/testing/selftests/drivers/net/bonding/bond-arp-interval-causes-panic.sh >> +++ b/tools/testing/selftests/drivers/net/bonding/bond-arp-interval-causes-panic.sh >> @@ -11,7 +11,6 @@ finish() >> { >> ip netns delete server || true >> ip netns delete client || true >> - ip link del link1_1 || true >> } >> >> trap finish EXIT >> -- >> 2.34.1 >>
On Wed, Aug 16, 2023 at 03:55:30PM +0800, shaozhengchao wrote: > > > On 2023/8/16 14:11, Hangbin Liu wrote: > > On Sat, Aug 12, 2023 at 04:40:36PM +0800, Zhengchao Shao wrote: > > > When run command "ip netns delete client", device link1_1 has been > > > deleted. So, it is no need to delete link1_1 again. Remove it. > > > Hi Hangbin: > > What if the test exit because the cmd execute failed before setting > > link1_1 to netns client? > > > > Thanks > > Hangbin > > > > Your consideration is indeed possible. > "ip link del link1_1 >/dev/null 2>&1" maybe looks better? I have not objects to this. On the other side, this only omit the error message. It doesn't fix anything. Thanks Hangbin
On 2023/8/16 16:33, Hangbin Liu wrote: > On Wed, Aug 16, 2023 at 03:55:30PM +0800, shaozhengchao wrote: >> >> >> On 2023/8/16 14:11, Hangbin Liu wrote: >>> On Sat, Aug 12, 2023 at 04:40:36PM +0800, Zhengchao Shao wrote: >>>> When run command "ip netns delete client", device link1_1 has been >>>> deleted. So, it is no need to delete link1_1 again. Remove it. >>> >> Hi Hangbin: >>> What if the test exit because the cmd execute failed before setting >>> link1_1 to netns client? >>> >>> Thanks >>> Hangbin >>>> >> Your consideration is indeed possible. >> "ip link del link1_1 >/dev/null 2>&1" maybe looks better? > > I have not objects to this. On the other side, this only omit the error > message. It doesn't fix anything. > > Thanks > Hangbin Yes, it will fix nothing, just clean up something. I will add it later. Also I run bond-break-lacpdu-tx.sh, it reports FAIL. When the master is set up, the slave does not go up. It seems that the mechanism has changed. But now I haven't had time to analyze it in detail, maybe someone can do it. Zhengchao Shao
On Wed, Aug 16, 2023 at 05:22:38PM +0800, shaozhengchao wrote: > Also I run bond-break-lacpdu-tx.sh, it reports FAIL. > When the master is set up, the slave does not go up. It seems > that the mechanism has changed. But now I haven't had time > to analyze it in detail, maybe someone can do it. I will check it. Hangbin
On 2023/8/16 18:02, Hangbin Liu wrote: > On Wed, Aug 16, 2023 at 05:22:38PM +0800, shaozhengchao wrote: >> Also I run bond-break-lacpdu-tx.sh, it reports FAIL. >> When the master is set up, the slave does not go up. It seems >> that the mechanism has changed. But now I haven't had time >> to analyze it in detail, maybe someone can do it. > > I will check it. > > Hangbin Thanks Zhengchao Shao
diff --git a/tools/testing/selftests/drivers/net/bonding/bond-arp-interval-causes-panic.sh b/tools/testing/selftests/drivers/net/bonding/bond-arp-interval-causes-panic.sh index 71c00bfafbc9..7b2d421f09cf 100755 --- a/tools/testing/selftests/drivers/net/bonding/bond-arp-interval-causes-panic.sh +++ b/tools/testing/selftests/drivers/net/bonding/bond-arp-interval-causes-panic.sh @@ -11,7 +11,6 @@ finish() { ip netns delete server || true ip netns delete client || true - ip link del link1_1 || true } trap finish EXIT
When run command "ip netns delete client", device link1_1 has been deleted. So, it is no need to delete link1_1 again. Remove it. Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com> --- .../drivers/net/bonding/bond-arp-interval-causes-panic.sh | 1 - 1 file changed, 1 deletion(-)