diff mbox series

[bpf-next] selftests/bpf: fix repeat option when kfunc_call verify fail

Message ID 20230814031434.3077944-1-zouyipeng@huawei.com (mailing list archive)
State Accepted
Commit 811915db674f8daf19bb4fcb67da9017235ce26d
Headers show
Series [bpf-next] selftests/bpf: fix repeat option when kfunc_call verify fail | expand

Commit Message

Yipeng Zou Aug. 14, 2023, 3:14 a.m. UTC
There is no way to set topts.repeat=1 when tc_test going to verify fail.

Maybe it's clerical error, fix it directly.

Fixes: fb66223a244f ("selftests/bpf: add test for accessing ctx from syscall program type")
Signed-off-by: Yipeng Zou <zouyipeng@huawei.com>
Reviewed-by: Li Zetao <lizetao1@huawei.com>
---
 tools/testing/selftests/bpf/prog_tests/kfunc_call.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

patchwork-bot+netdevbpf@kernel.org Aug. 14, 2023, 4:10 p.m. UTC | #1
Hello:

This patch was applied to bpf/bpf-next.git (master)
by Daniel Borkmann <daniel@iogearbox.net>:

On Mon, 14 Aug 2023 11:14:34 +0800 you wrote:
> There is no way to set topts.repeat=1 when tc_test going to verify fail.
> 
> Maybe it's clerical error, fix it directly.
> 
> Fixes: fb66223a244f ("selftests/bpf: add test for accessing ctx from syscall program type")
> Signed-off-by: Yipeng Zou <zouyipeng@huawei.com>
> Reviewed-by: Li Zetao <lizetao1@huawei.com>
> 
> [...]

Here is the summary with links:
  - [bpf-next] selftests/bpf: fix repeat option when kfunc_call verify fail
    https://git.kernel.org/bpf/bpf-next/c/811915db674f

You are awesome, thank you!
diff mbox series

Patch

diff --git a/tools/testing/selftests/bpf/prog_tests/kfunc_call.c b/tools/testing/selftests/bpf/prog_tests/kfunc_call.c
index a543742cd7bd..2eb71559713c 100644
--- a/tools/testing/selftests/bpf/prog_tests/kfunc_call.c
+++ b/tools/testing/selftests/bpf/prog_tests/kfunc_call.c
@@ -173,8 +173,8 @@  static void verify_fail(struct kfunc_test_params *param)
 	case tc_test:
 		topts.data_in = &pkt_v4;
 		topts.data_size_in = sizeof(pkt_v4);
-		break;
 		topts.repeat = 1;
+		break;
 	}
 
 	skel = kfunc_call_fail__open_opts(&opts);