| Message ID | 20231002114635.1567809-1-singhabhinav9051571833@gmail.com (mailing list archive) |
|---|---|
| State | Rejected |
| Headers | show |
| Series | [v2] Added missing TARGETS in kselftest top level Makefile | expand |
On 10/2/23 05:46, Abhinav wrote: > Some tests like dma, ia64, etc. were not present in top level of > selftest Makefile, so when someone ran 'make run_tests' they would miss > these tests. This patches adds those left out tests. > > Signed-off-by: Abhinav <singhabhinav9051571833@gmail.com> > --- > > I removed sched, safesetid and filelock from the Makefile, because these > tests were actually triggered when we run 'make run_tests' even though it > has not been mentioned explicitly inside top level Makefile of selftest. > > tools/testing/selftests/Makefile | 7 +++++++ > 1 file changed, 7 insertions(+) > There are good reasons to leave out tests from the kselftest default run. 1. test requires specific hardware or driver or system configuration which includes kernel configuration options. e.g: media_tests, dma 2. It is a benchmark and/or destructive test that doesn't fit into default run category: watchdog, kmod 3. test Makefile doesn't support kselftest framework Any patch adding a test left out of default run to the default run has to explain the reasons why it is a good idea to add it and more importantly showing that this doesn't impact the default run with report from the test run "make kselftest" Sorry. I am not going to take this patch. thanks, -- Shuah
diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile index 8d9b2341b79a..dc138c1dcb4b 100644 --- a/tools/testing/selftests/Makefile +++ b/tools/testing/selftests/Makefile @@ -13,6 +13,7 @@ TARGETS += core TARGETS += cpufreq TARGETS += cpu-hotplug TARGETS += damon +TARGETS += dma TARGETS += dmabuf-heaps TARGETS += drivers/dma-buf TARGETS += drivers/s390x/uvdevice @@ -32,17 +33,21 @@ TARGETS += ftrace TARGETS += futex TARGETS += gpio TARGETS += hid +TARGETS += ia64 TARGETS += intel_pstate TARGETS += iommu TARGETS += ipc TARGETS += ir TARGETS += kcmp TARGETS += kexec +TARGETS += kmod TARGETS += kvm TARGETS += landlock TARGETS += lib TARGETS += livepatch TARGETS += lkdtm +TARGETS += locking +TARGETS += media_tests TARGETS += membarrier TARGETS += memfd TARGETS += memory-hotplug @@ -66,6 +71,7 @@ TARGETS += pid_namespace TARGETS += powerpc TARGETS += prctl TARGETS += proc +TARGETS += ptp TARGETS += pstore TARGETS += ptrace TARGETS += openat2 @@ -99,6 +105,7 @@ TARGETS += user TARGETS += user_events TARGETS += vDSO TARGETS += mm +TARGETS += watchdog TARGETS += x86 TARGETS += zram #Please keep the TARGETS list alphabetically sorted
Some tests like dma, ia64, etc. were not present in top level of selftest Makefile, so when someone ran 'make run_tests' they would miss these tests. This patches adds those left out tests. Signed-off-by: Abhinav <singhabhinav9051571833@gmail.com> --- I removed sched, safesetid and filelock from the Makefile, because these tests were actually triggered when we run 'make run_tests' even though it has not been mentioned explicitly inside top level Makefile of selftest. tools/testing/selftests/Makefile | 7 +++++++ 1 file changed, 7 insertions(+)