| Message ID | 20231018015921.16890-1-zhujun2@cmss.chinamobile.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | selftests/efivarfs: create-read: fix a resource leak | expand |
On 10/17/23 19:59, zhujun2 wrote: > The opened file should be closed in main(), otherwise resource > leak will occur that this problem was discovered by code reading > > Signed-off-by: zhujun2 <zhujun2@cmss.chinamobile.com> > --- > tools/testing/selftests/efivarfs/create-read.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tools/testing/selftests/efivarfs/create-read.c b/tools/testing/selftests/efivarfs/create-read.c > index 9674a1939..7bc7af4eb 100644 > --- a/tools/testing/selftests/efivarfs/create-read.c > +++ b/tools/testing/selftests/efivarfs/create-read.c > @@ -32,8 +32,10 @@ int main(int argc, char **argv) > rc = read(fd, buf, sizeof(buf)); > if (rc != 0) { > fprintf(stderr, "Reading a new var should return EOF\n"); > + close(fd); > return EXIT_FAILURE; > } > > + close(fd); > return EXIT_SUCCESS; > } Thank you. Applied to linux-kselftest next for Linux 6.7-c1. thanks, -- Shuah
diff --git a/tools/testing/selftests/efivarfs/create-read.c b/tools/testing/selftests/efivarfs/create-read.c index 9674a1939..7bc7af4eb 100644 --- a/tools/testing/selftests/efivarfs/create-read.c +++ b/tools/testing/selftests/efivarfs/create-read.c @@ -32,8 +32,10 @@ int main(int argc, char **argv) rc = read(fd, buf, sizeof(buf)); if (rc != 0) { fprintf(stderr, "Reading a new var should return EOF\n"); + close(fd); return EXIT_FAILURE; } + close(fd); return EXIT_SUCCESS; }
The opened file should be closed in main(), otherwise resource leak will occur that this problem was discovered by code reading Signed-off-by: zhujun2 <zhujun2@cmss.chinamobile.com> --- tools/testing/selftests/efivarfs/create-read.c | 2 ++ 1 file changed, 2 insertions(+)