| Message ID | 20240118-tcp-ao-test-key-mgmt-v1-3-3583ca147113@arista.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | selftests/net: A couple of typos fixes in key-management test | expand |
On Thu, Jan 18, 2024 at 02:51:36AM +0000, Dmitry Safonov wrote: > Yeah, copy'n'paste typo. > > Fixes: 3c3ead555648 ("selftests/net: Add TCP-AO key-management test") > Reported-by: Nassiri, Mohammad <mnassiri@ciena.com> > Closes: https://lore.kernel.org/all/DM6PR04MB4202BC58A9FD5BDD24A16E8EC56F2@DM6PR04MB4202.namprd04.prod.outlook.com/ > Signed-off-by: Dmitry Safonov <dima@arista.com> > --- Hi Dmitry, This seems more like a clean-up than a fix. > tools/testing/selftests/net/tcp_ao/lib/sock.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/tools/testing/selftests/net/tcp_ao/lib/sock.c b/tools/testing/selftests/net/tcp_ao/lib/sock.c > index c75d82885a2e..923a9bb4f1ca 100644 > --- a/tools/testing/selftests/net/tcp_ao/lib/sock.c > +++ b/tools/testing/selftests/net/tcp_ao/lib/sock.c > @@ -377,7 +377,6 @@ int test_get_tcp_ao_counters(int sk, struct tcp_ao_counters *out) > > key_dump[0].nkeys = nr_keys; > key_dump[0].get_all = 1; > - key_dump[0].get_all = 1; > err = getsockopt(sk, IPPROTO_TCP, TCP_AO_GET_KEYS, > key_dump, &key_dump_sz); > if (err) { > > -- > 2.43.0 >
Hi Simon, On 1/19/24 16:25, Simon Horman wrote: > On Thu, Jan 18, 2024 at 02:51:36AM +0000, Dmitry Safonov wrote: >> Yeah, copy'n'paste typo. >> >> Fixes: 3c3ead555648 ("selftests/net: Add TCP-AO key-management test") >> Reported-by: Nassiri, Mohammad <mnassiri@ciena.com> >> Closes: https://lore.kernel.org/all/DM6PR04MB4202BC58A9FD5BDD24A16E8EC56F2@DM6PR04MB4202.namprd04.prod.outlook.com/ >> Signed-off-by: Dmitry Safonov <dima@arista.com> >> --- > > Hi Dmitry, > > This seems more like a clean-up than a fix. Do you mean to remove the tag or that you'd prefer it rather go to net-next? >> tools/testing/selftests/net/tcp_ao/lib/sock.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/tools/testing/selftests/net/tcp_ao/lib/sock.c b/tools/testing/selftests/net/tcp_ao/lib/sock.c >> index c75d82885a2e..923a9bb4f1ca 100644 >> --- a/tools/testing/selftests/net/tcp_ao/lib/sock.c >> +++ b/tools/testing/selftests/net/tcp_ao/lib/sock.c >> @@ -377,7 +377,6 @@ int test_get_tcp_ao_counters(int sk, struct tcp_ao_counters *out) >> >> key_dump[0].nkeys = nr_keys; >> key_dump[0].get_all = 1; >> - key_dump[0].get_all = 1; >> err = getsockopt(sk, IPPROTO_TCP, TCP_AO_GET_KEYS, >> key_dump, &key_dump_sz); >> if (err) { >> >> -- >> 2.43.0 >> Thanks, Dmitry
On Fri, Jan 19, 2024 at 06:37:46PM +0000, Dmitry Safonov wrote: > Hi Simon, > > On 1/19/24 16:25, Simon Horman wrote: > > On Thu, Jan 18, 2024 at 02:51:36AM +0000, Dmitry Safonov wrote: > >> Yeah, copy'n'paste typo. > >> > >> Fixes: 3c3ead555648 ("selftests/net: Add TCP-AO key-management test") > >> Reported-by: Nassiri, Mohammad <mnassiri@ciena.com> > >> Closes: https://lore.kernel.org/all/DM6PR04MB4202BC58A9FD5BDD24A16E8EC56F2@DM6PR04MB4202.namprd04.prod.outlook.com/ > >> Signed-off-by: Dmitry Safonov <dima@arista.com> > >> --- > > > > Hi Dmitry, > > > > This seems more like a clean-up than a fix. > > Do you mean to remove the tag or that you'd prefer it rather go > to net-next? Both :) ...
diff --git a/tools/testing/selftests/net/tcp_ao/lib/sock.c b/tools/testing/selftests/net/tcp_ao/lib/sock.c index c75d82885a2e..923a9bb4f1ca 100644 --- a/tools/testing/selftests/net/tcp_ao/lib/sock.c +++ b/tools/testing/selftests/net/tcp_ao/lib/sock.c @@ -377,7 +377,6 @@ int test_get_tcp_ao_counters(int sk, struct tcp_ao_counters *out) key_dump[0].nkeys = nr_keys; key_dump[0].get_all = 1; - key_dump[0].get_all = 1; err = getsockopt(sk, IPPROTO_TCP, TCP_AO_GET_KEYS, key_dump, &key_dump_sz); if (err) {
Yeah, copy'n'paste typo. Fixes: 3c3ead555648 ("selftests/net: Add TCP-AO key-management test") Reported-by: Nassiri, Mohammad <mnassiri@ciena.com> Closes: https://lore.kernel.org/all/DM6PR04MB4202BC58A9FD5BDD24A16E8EC56F2@DM6PR04MB4202.namprd04.prod.outlook.com/ Signed-off-by: Dmitry Safonov <dima@arista.com> --- tools/testing/selftests/net/tcp_ao/lib/sock.c | 1 - 1 file changed, 1 deletion(-)