| Message ID | 20240429191911.2552580-2-mic@digikod.net (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 37dc2e0d38d6eb690ee043b43ee6f7cdf2994bf6 |
| Headers | show |
| Series | Fix Kselftest's vfork() side effects | expand |
On Mon, Apr 29, 2024 at 09:19:03PM +0200, Mickaël Salaün wrote: > Required by switch_timens() to open /proc/self/ns/time_for_children. > > CONFIG_GENERIC_VDSO_TIME_NS is not available on UML, so pidfd_setns_test > cannot be run successfully on this architecture. > > Cc: Christian Brauner <brauner@kernel.org> > Cc: Shuah Khan <skhan@linuxfoundation.org> > Fixes: 2b40c5db73e2 ("selftests/pidfd: add pidfd setns tests") > Reviewed-by: Kees Cook <keescook@chromium.org> > Signed-off-by: Mickaël Salaün <mic@digikod.net> > Link: https://lore.kernel.org/r/20240429191911.2552580-2-mic@digikod.net > --- Looks good to me, Reviewed-by: Christian Brauner <brauner@kernel.org>
diff --git a/tools/testing/selftests/pidfd/config b/tools/testing/selftests/pidfd/config index f6f2965e17af..6133524710f7 100644 --- a/tools/testing/selftests/pidfd/config +++ b/tools/testing/selftests/pidfd/config @@ -3,5 +3,7 @@ CONFIG_IPC_NS=y CONFIG_USER_NS=y CONFIG_PID_NS=y CONFIG_NET_NS=y +CONFIG_TIME_NS=y +CONFIG_GENERIC_VDSO_TIME_NS=y CONFIG_CGROUPS=y CONFIG_CHECKPOINT_RESTORE=y
Required by switch_timens() to open /proc/self/ns/time_for_children. CONFIG_GENERIC_VDSO_TIME_NS is not available on UML, so pidfd_setns_test cannot be run successfully on this architecture. Cc: Christian Brauner <brauner@kernel.org> Cc: Shuah Khan <skhan@linuxfoundation.org> Fixes: 2b40c5db73e2 ("selftests/pidfd: add pidfd setns tests") Reviewed-by: Kees Cook <keescook@chromium.org> Signed-off-by: Mickaël Salaün <mic@digikod.net> Link: https://lore.kernel.org/r/20240429191911.2552580-2-mic@digikod.net --- tools/testing/selftests/pidfd/config | 2 ++ 1 file changed, 2 insertions(+)