| Message ID | 20240505230054.13813-1-jhubbard@nvidia.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 41b307ad756e1b7b618bf9d9c1cce3595705ede4 |
| Headers | show |
| Series | [v2] bpftool, selftests/hid/bpf: fix 29 clang warnings | expand |
On 06/05/2024 00:00, John Hubbard wrote: > When building either tools/bpf/bpftool, or tools/testing/selftests/hid, > (the same Makefile is used for these), clang generates many instances of > the following: > > "clang: warning: -lLLVM-17: 'linker' input unused" > > Quentin points out that the LLVM version is only required in $(LIBS), > not in $(CFLAGS), so the fix is to remove it from CFLAGS. > > Suggested-by: Quentin Monnet <qmo@kernel.org> > Signed-off-by: John Hubbard <jhubbard@nvidia.com> Acked-by: Quentin Monnet <qmo@kernel.org> Thank you!
Hello: This patch was applied to bpf/bpf-next.git (master) by Andrii Nakryiko <andrii@kernel.org>: On Sun, 5 May 2024 16:00:54 -0700 you wrote: > When building either tools/bpf/bpftool, or tools/testing/selftests/hid, > (the same Makefile is used for these), clang generates many instances of > the following: > > "clang: warning: -lLLVM-17: 'linker' input unused" > > Quentin points out that the LLVM version is only required in $(LIBS), > not in $(CFLAGS), so the fix is to remove it from CFLAGS. > > [...] Here is the summary with links: - [v2] bpftool, selftests/hid/bpf: fix 29 clang warnings https://git.kernel.org/bpf/bpf-next/c/41b307ad756e You are awesome, thank you!
diff --git a/tools/bpf/bpftool/Makefile b/tools/bpf/bpftool/Makefile index e9154ace80ff..a5445a422109 100644 --- a/tools/bpf/bpftool/Makefile +++ b/tools/bpf/bpftool/Makefile @@ -143,7 +143,7 @@ ifeq ($(feature-llvm),1) # If LLVM is available, use it for JIT disassembly CFLAGS += -DHAVE_LLVM_SUPPORT LLVM_CONFIG_LIB_COMPONENTS := mcdisassembler all-targets - CFLAGS += $(shell $(LLVM_CONFIG) --cflags --libs $(LLVM_CONFIG_LIB_COMPONENTS)) + CFLAGS += $(shell $(LLVM_CONFIG) --cflags) LIBS += $(shell $(LLVM_CONFIG) --libs $(LLVM_CONFIG_LIB_COMPONENTS)) ifeq ($(shell $(LLVM_CONFIG) --shared-mode),static) LIBS += $(shell $(LLVM_CONFIG) --system-libs $(LLVM_CONFIG_LIB_COMPONENTS))
When building either tools/bpf/bpftool, or tools/testing/selftests/hid, (the same Makefile is used for these), clang generates many instances of the following: "clang: warning: -lLLVM-17: 'linker' input unused" Quentin points out that the LLVM version is only required in $(LIBS), not in $(CFLAGS), so the fix is to remove it from CFLAGS. Suggested-by: Quentin Monnet <qmo@kernel.org> Signed-off-by: John Hubbard <jhubbard@nvidia.com> --- tools/bpf/bpftool/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) base-commit: f462ae0edd3703edd6f22fe41d336369c38b884b prerequisite-patch-id: b901ece2a5b78503e2fb5480f20e304d36a0ea27