Message ID | 20240510095803.472840-4-kunwu.chan@linux.dev (mailing list archive) |
---|---|
State | New |
Headers | show |
Series | Add some 'malloc' failure checks | expand |
On 5/10/24 2:58 PM, kunwu.chan@linux.dev wrote: > From: Kunwu Chan <chentao@kylinos.cn> > > There is a 'malloc' call, which can be unsuccessful. > Add the malloc failure checking to avoid possible null > dereference. > > Signed-off-by: Kunwu Chan <chentao@kylinos.cn> LGTM Reviewed-by: Muhammad Usama Anjum <usama.anjum@collabora.com> > --- > tools/testing/selftests/bpf/test_verifier.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tools/testing/selftests/bpf/test_verifier.c b/tools/testing/selftests/bpf/test_verifier.c > index df04bda1c927..9c80b2943418 100644 > --- a/tools/testing/selftests/bpf/test_verifier.c > +++ b/tools/testing/selftests/bpf/test_verifier.c > @@ -762,6 +762,8 @@ static int load_btf_spec(__u32 *types, int types_len, > ); > > raw_btf = malloc(sizeof(hdr) + types_len + strings_len); > + if (!raw_btf) > + return -ENOMEM; > > ptr = raw_btf; > memcpy(ptr, &hdr, sizeof(hdr));
diff --git a/tools/testing/selftests/bpf/test_verifier.c b/tools/testing/selftests/bpf/test_verifier.c index df04bda1c927..9c80b2943418 100644 --- a/tools/testing/selftests/bpf/test_verifier.c +++ b/tools/testing/selftests/bpf/test_verifier.c @@ -762,6 +762,8 @@ static int load_btf_spec(__u32 *types, int types_len, ); raw_btf = malloc(sizeof(hdr) + types_len + strings_len); + if (!raw_btf) + return -ENOMEM; ptr = raw_btf; memcpy(ptr, &hdr, sizeof(hdr));