| Message ID | 20240601-md-lib-kunit-framework-v1-1-f406bb629bde@quicinc.com (mailing list archive) |
|---|---|
| State | New |
| Delegated to: | Brendan Higgins |
| Headers | show |
| Series | kunit: add missing MODULE_DESCRIPTION() macros to core modules | expand |
On Sat, Jun 1, 2024 at 1:19 PM Jeff Johnson <quic_jjohnson@quicinc.com> wrote: > > make allmodconfig && make W=1 C=1 reports in lib/kunit: > WARNING: modpost: missing MODULE_DESCRIPTION() in lib/kunit/kunit.o > WARNING: modpost: missing MODULE_DESCRIPTION() in lib/kunit/kunit-test.o > WARNING: modpost: missing MODULE_DESCRIPTION() in lib/kunit/kunit-example-test.o > > Add the missing invocations of the MODULE_DESCRIPTION() macro. > > Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com> Hello! This looks good to me. Reviewed-by: Rae Moar <rmoar@google.com> Thanks! -Rae > --- > lib/kunit/kunit-example-test.c | 1 + > lib/kunit/kunit-test.c | 1 + > lib/kunit/test.c | 1 + > 3 files changed, 3 insertions(+) > > diff --git a/lib/kunit/kunit-example-test.c b/lib/kunit/kunit-example-test.c > index 798924f7cc86..3056d6bc705d 100644 > --- a/lib/kunit/kunit-example-test.c > +++ b/lib/kunit/kunit-example-test.c > @@ -374,4 +374,5 @@ static struct kunit_suite example_init_test_suite = { > */ > kunit_test_init_section_suites(&example_init_test_suite); > > +MODULE_DESCRIPTION("Example KUnit test suite"); > MODULE_LICENSE("GPL v2"); > diff --git a/lib/kunit/kunit-test.c b/lib/kunit/kunit-test.c > index e3412e0ca399..37e02be1e710 100644 > --- a/lib/kunit/kunit-test.c > +++ b/lib/kunit/kunit-test.c > @@ -871,4 +871,5 @@ kunit_test_suites(&kunit_try_catch_test_suite, &kunit_resource_test_suite, > &kunit_current_test_suite, &kunit_device_test_suite, > &kunit_fault_test_suite); > > +MODULE_DESCRIPTION("KUnit test for core test infrastructure"); > MODULE_LICENSE("GPL v2"); > diff --git a/lib/kunit/test.c b/lib/kunit/test.c > index b8514dbb337c..e8b1b52a19ab 100644 > --- a/lib/kunit/test.c > +++ b/lib/kunit/test.c > @@ -938,4 +938,5 @@ static void __exit kunit_exit(void) > } > module_exit(kunit_exit); > > +MODULE_DESCRIPTION("Base unit test (KUnit) API"); > MODULE_LICENSE("GPL v2"); > > --- > base-commit: b050496579632f86ee1ef7e7501906db579f3457 > change-id: 20240601-md-lib-kunit-framework-ed2d8b6f5e76 >
On Sun, 2 Jun 2024 at 01:19, Jeff Johnson <quic_jjohnson@quicinc.com> wrote: > > make allmodconfig && make W=1 C=1 reports in lib/kunit: > WARNING: modpost: missing MODULE_DESCRIPTION() in lib/kunit/kunit.o > WARNING: modpost: missing MODULE_DESCRIPTION() in lib/kunit/kunit-test.o > WARNING: modpost: missing MODULE_DESCRIPTION() in lib/kunit/kunit-example-test.o > > Add the missing invocations of the MODULE_DESCRIPTION() macro. > > Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com> > --- Reviewed-by: David Gow <davidgow@google.com> Cheers, -- David
diff --git a/lib/kunit/kunit-example-test.c b/lib/kunit/kunit-example-test.c index 798924f7cc86..3056d6bc705d 100644 --- a/lib/kunit/kunit-example-test.c +++ b/lib/kunit/kunit-example-test.c @@ -374,4 +374,5 @@ static struct kunit_suite example_init_test_suite = { */ kunit_test_init_section_suites(&example_init_test_suite); +MODULE_DESCRIPTION("Example KUnit test suite"); MODULE_LICENSE("GPL v2"); diff --git a/lib/kunit/kunit-test.c b/lib/kunit/kunit-test.c index e3412e0ca399..37e02be1e710 100644 --- a/lib/kunit/kunit-test.c +++ b/lib/kunit/kunit-test.c @@ -871,4 +871,5 @@ kunit_test_suites(&kunit_try_catch_test_suite, &kunit_resource_test_suite, &kunit_current_test_suite, &kunit_device_test_suite, &kunit_fault_test_suite); +MODULE_DESCRIPTION("KUnit test for core test infrastructure"); MODULE_LICENSE("GPL v2"); diff --git a/lib/kunit/test.c b/lib/kunit/test.c index b8514dbb337c..e8b1b52a19ab 100644 --- a/lib/kunit/test.c +++ b/lib/kunit/test.c @@ -938,4 +938,5 @@ static void __exit kunit_exit(void) } module_exit(kunit_exit); +MODULE_DESCRIPTION("Base unit test (KUnit) API"); MODULE_LICENSE("GPL v2");
make allmodconfig && make W=1 C=1 reports in lib/kunit: WARNING: modpost: missing MODULE_DESCRIPTION() in lib/kunit/kunit.o WARNING: modpost: missing MODULE_DESCRIPTION() in lib/kunit/kunit-test.o WARNING: modpost: missing MODULE_DESCRIPTION() in lib/kunit/kunit-example-test.o Add the missing invocations of the MODULE_DESCRIPTION() macro. Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com> --- lib/kunit/kunit-example-test.c | 1 + lib/kunit/kunit-test.c | 1 + lib/kunit/test.c | 1 + 3 files changed, 3 insertions(+) --- base-commit: b050496579632f86ee1ef7e7501906db579f3457 change-id: 20240601-md-lib-kunit-framework-ed2d8b6f5e76