| Message ID | 20240607124117.66769-2-amer.shanawany@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [v2] selftests: seccomp: fix format-zero-length warnings | expand |
On 6/7/24 06:41, Amer Al Shanawany wrote: > fix the following errors by removing empty print statements: > seccomp_benchmark.c:197:24: warning: zero-length gnu_printf format > string [-Wformat-zero-length] > 197 | ksft_print_msg(""); > | ^~ > seccomp_benchmark.c:202:24: warning: zero-length gnu_printf format > string [-Wformat-zero-length] > 202 | ksft_print_msg(""); > | ^~ > seccomp_benchmark.c:204:24: warning: zero-length gnu_printf format > string [-Wformat-zero-length] > 204 | ksft_print_msg(""); > | ^~ > > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202312260235.Uj5ug8K9-lkp@intel.com/ > Signed-off-by: Amer Al Shanawany <amer.shanawany@gmail.com> > --- > Changes v1 -> v2: > removed empty print statements Kees, Is this change okay with you. I didn't see any use for these empty ksft_print_msg(). I will take this patch if you are okay with the change. > --- > tools/testing/selftests/seccomp/seccomp_benchmark.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/tools/testing/selftests/seccomp/seccomp_benchmark.c b/tools/testing/selftests/seccomp/seccomp_benchmark.c > index b83099160fbc..6fe34be6c693 100644 > --- a/tools/testing/selftests/seccomp/seccomp_benchmark.c > +++ b/tools/testing/selftests/seccomp/seccomp_benchmark.c > @@ -194,14 +194,11 @@ int main(int argc, char *argv[]) > ksft_set_plan(7); > > ksft_print_msg("Running on:\n"); > - ksft_print_msg(""); > system("uname -a"); > > ksft_print_msg("Current BPF sysctl settings:\n"); > /* Avoid using "sysctl" which may not be installed. */ > - ksft_print_msg(""); > system("grep -H . /proc/sys/net/core/bpf_jit_enable"); > - ksft_print_msg(""); > system("grep -H . /proc/sys/net/core/bpf_jit_harden"); > > affinity(); thanks, -- Shuah
On Fri, Jun 07, 2024 at 02:58:47PM -0600, Shuah Khan wrote: > On 6/7/24 06:41, Amer Al Shanawany wrote: > > fix the following errors by removing empty print statements: > > seccomp_benchmark.c:197:24: warning: zero-length gnu_printf format > > string [-Wformat-zero-length] > > 197 | ksft_print_msg(""); > > | ^~ > > seccomp_benchmark.c:202:24: warning: zero-length gnu_printf format > > string [-Wformat-zero-length] > > 202 | ksft_print_msg(""); > > | ^~ > > seccomp_benchmark.c:204:24: warning: zero-length gnu_printf format > > string [-Wformat-zero-length] > > 204 | ksft_print_msg(""); > > | ^~ > > > > Reported-by: kernel test robot <lkp@intel.com> > > Closes: https://lore.kernel.org/oe-kbuild-all/202312260235.Uj5ug8K9-lkp@intel.com/ > > Signed-off-by: Amer Al Shanawany <amer.shanawany@gmail.com> > > --- > > Changes v1 -> v2: > > removed empty print statements > > Kees, > > Is this change okay with you. I didn't see any use for > these empty ksft_print_msg(). > > I will take this patch if you are okay with the change. Dropping these means that the "#" marks go missing. Currently: # Running on: # Linux proton 6.5.0-25-generic #25~22.04.1-Ubuntu SMP PREEMPT_DYNAMIC Tue Feb 20 16:09:15 UTC 2 x86_64 x86_64 x86_64 GNU/Linux with the proposed patch: # Running on: Linux proton 6.5.0-25-generic #25~22.04.1-Ubuntu SMP PREEMPT_DYNAMIC Tue Feb 20 16:09:15 UTC 2 x86_64 x86_64 x86_64 GNU/Linux This breaks the TAP syntax for the test, so we should find a different solution. Perhaps: ksft_print_msg("%s", ""); ? -Kees > > > --- > > tools/testing/selftests/seccomp/seccomp_benchmark.c | 3 --- > > 1 file changed, 3 deletions(-) > > > > diff --git a/tools/testing/selftests/seccomp/seccomp_benchmark.c b/tools/testing/selftests/seccomp/seccomp_benchmark.c > > index b83099160fbc..6fe34be6c693 100644 > > --- a/tools/testing/selftests/seccomp/seccomp_benchmark.c > > +++ b/tools/testing/selftests/seccomp/seccomp_benchmark.c > > @@ -194,14 +194,11 @@ int main(int argc, char *argv[]) > > ksft_set_plan(7); > > ksft_print_msg("Running on:\n"); > > - ksft_print_msg(""); > > system("uname -a"); > > ksft_print_msg("Current BPF sysctl settings:\n"); > > /* Avoid using "sysctl" which may not be installed. */ > > - ksft_print_msg(""); > > system("grep -H . /proc/sys/net/core/bpf_jit_enable"); > > - ksft_print_msg(""); > > system("grep -H . /proc/sys/net/core/bpf_jit_harden"); > > affinity(); > > > thanks, > -- Shuah
On 6/10/24 10:59, Kees Cook wrote: > On Fri, Jun 07, 2024 at 02:58:47PM -0600, Shuah Khan wrote: >> On 6/7/24 06:41, Amer Al Shanawany wrote: >>> fix the following errors by removing empty print statements: >>> seccomp_benchmark.c:197:24: warning: zero-length gnu_printf format >>> string [-Wformat-zero-length] >>> 197 | ksft_print_msg(""); >>> | ^~ >>> seccomp_benchmark.c:202:24: warning: zero-length gnu_printf format >>> string [-Wformat-zero-length] >>> 202 | ksft_print_msg(""); >>> | ^~ >>> seccomp_benchmark.c:204:24: warning: zero-length gnu_printf format >>> string [-Wformat-zero-length] >>> 204 | ksft_print_msg(""); >>> | ^~ >>> >>> Reported-by: kernel test robot <lkp@intel.com> >>> Closes: https://lore.kernel.org/oe-kbuild-all/202312260235.Uj5ug8K9-lkp@intel.com/ >>> Signed-off-by: Amer Al Shanawany <amer.shanawany@gmail.com> >>> --- >>> Changes v1 -> v2: >>> removed empty print statements >> >> Kees, >> >> Is this change okay with you. I didn't see any use for >> these empty ksft_print_msg(). >> >> I will take this patch if you are okay with the change. > > Dropping these means that the "#" marks go missing. Currently: > > # Running on: > # Linux proton 6.5.0-25-generic #25~22.04.1-Ubuntu SMP PREEMPT_DYNAMIC Tue Feb 20 16:09:15 UTC 2 x86_64 x86_64 x86_64 GNU/Linux > > with the proposed patch: > > # Running on: > Linux proton 6.5.0-25-generic #25~22.04.1-Ubuntu SMP PREEMPT_DYNAMIC Tue Feb 20 16:09:15 UTC 2 x86_64 x86_64 x86_64 GNU/Linux > > This breaks the TAP syntax for the test, so we should find a different > solution. > > Perhaps: > > ksft_print_msg("%s", ""); > > ? > Thank you Kees. Yes that would work. Amer, please send me v3 based on Kees's suggestions. thanks, -- Shuah
diff --git a/tools/testing/selftests/seccomp/seccomp_benchmark.c b/tools/testing/selftests/seccomp/seccomp_benchmark.c index b83099160fbc..6fe34be6c693 100644 --- a/tools/testing/selftests/seccomp/seccomp_benchmark.c +++ b/tools/testing/selftests/seccomp/seccomp_benchmark.c @@ -194,14 +194,11 @@ int main(int argc, char *argv[]) ksft_set_plan(7); ksft_print_msg("Running on:\n"); - ksft_print_msg(""); system("uname -a"); ksft_print_msg("Current BPF sysctl settings:\n"); /* Avoid using "sysctl" which may not be installed. */ - ksft_print_msg(""); system("grep -H . /proc/sys/net/core/bpf_jit_enable"); - ksft_print_msg(""); system("grep -H . /proc/sys/net/core/bpf_jit_harden"); affinity();
fix the following errors by removing empty print statements: seccomp_benchmark.c:197:24: warning: zero-length gnu_printf format string [-Wformat-zero-length] 197 | ksft_print_msg(""); | ^~ seccomp_benchmark.c:202:24: warning: zero-length gnu_printf format string [-Wformat-zero-length] 202 | ksft_print_msg(""); | ^~ seccomp_benchmark.c:204:24: warning: zero-length gnu_printf format string [-Wformat-zero-length] 204 | ksft_print_msg(""); | ^~ Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202312260235.Uj5ug8K9-lkp@intel.com/ Signed-off-by: Amer Al Shanawany <amer.shanawany@gmail.com> --- Changes v1 -> v2: removed empty print statements --- tools/testing/selftests/seccomp/seccomp_benchmark.c | 3 --- 1 file changed, 3 deletions(-)