| Message ID | 20240704024202.84726-1-jhubbard@nvidia.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [v3] selftests/timers: remove unused irqcount variable | expand |
On Wed, Jul 3, 2024 at 7:42 PM John Hubbard <jhubbard@nvidia.com> wrote: > > When building with clang, via: > > make LLVM=1 -C tools/testing/selftest > > ...clang warns about an unused irqcount variable. clang is correct: the > variable is incremented and then ignored. > > Fix this by deleting the irqcount variable. > > Signed-off-by: John Hubbard <jhubbard@nvidia.com> Acked-by: John Stultz <jstultz@google.com>
On 7/4/24 7:42 AM, John Hubbard wrote: > When building with clang, via: > > make LLVM=1 -C tools/testing/selftest > > ...clang warns about an unused irqcount variable. clang is correct: the > variable is incremented and then ignored. > > Fix this by deleting the irqcount variable. > > Signed-off-by: John Hubbard <jhubbard@nvidia.com> Reviewed-by: Muhammad Usama Anjum <usama.anjum@collabora.com> > --- > > Changes since v2: > > 1) Rebased onto Linux 6.10-rc6+ > > Changes since the first version: > > 1) Rebased onto Linux 6.10-rc1 > > thanks, > John Hubbard > > tools/testing/selftests/timers/rtcpie.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/timers/rtcpie.c b/tools/testing/selftests/timers/rtcpie.c > index 4ef2184f1558..7c07edd0d450 100644 > --- a/tools/testing/selftests/timers/rtcpie.c > +++ b/tools/testing/selftests/timers/rtcpie.c > @@ -29,7 +29,7 @@ static const char default_rtc[] = "/dev/rtc0"; > > int main(int argc, char **argv) > { > - int i, fd, retval, irqcount = 0; > + int i, fd, retval; > unsigned long tmp, data, old_pie_rate; > const char *rtc = default_rtc; > struct timeval start, end, diff; > @@ -120,7 +120,6 @@ int main(int argc, char **argv) > > fprintf(stderr, " %d",i); > fflush(stderr); > - irqcount++; > } > > /* Disable periodic interrupts */ > > base-commit: 8a9c6c40432e265600232b864f97d7c675e8be52
On 7/3/24 21:11, John Stultz wrote: > On Wed, Jul 3, 2024 at 7:42 PM John Hubbard <jhubbard@nvidia.com> wrote: >> >> When building with clang, via: >> >> make LLVM=1 -C tools/testing/selftest >> >> ...clang warns about an unused irqcount variable. clang is correct: the >> variable is incremented and then ignored. >> >> Fix this by deleting the irqcount variable. >> >> Signed-off-by: John Hubbard <jhubbard@nvidia.com> > > Acked-by: John Stultz <jstultz@google.com> Thank you all. Applied to linux_kselftest next for Linux 6.11-rc1. thanks, -- Shuah
diff --git a/tools/testing/selftests/timers/rtcpie.c b/tools/testing/selftests/timers/rtcpie.c index 4ef2184f1558..7c07edd0d450 100644 --- a/tools/testing/selftests/timers/rtcpie.c +++ b/tools/testing/selftests/timers/rtcpie.c @@ -29,7 +29,7 @@ static const char default_rtc[] = "/dev/rtc0"; int main(int argc, char **argv) { - int i, fd, retval, irqcount = 0; + int i, fd, retval; unsigned long tmp, data, old_pie_rate; const char *rtc = default_rtc; struct timeval start, end, diff; @@ -120,7 +120,6 @@ int main(int argc, char **argv) fprintf(stderr, " %d",i); fflush(stderr); - irqcount++; } /* Disable periodic interrupts */
When building with clang, via: make LLVM=1 -C tools/testing/selftest ...clang warns about an unused irqcount variable. clang is correct: the variable is incremented and then ignored. Fix this by deleting the irqcount variable. Signed-off-by: John Hubbard <jhubbard@nvidia.com> --- Changes since v2: 1) Rebased onto Linux 6.10-rc6+ Changes since the first version: 1) Rebased onto Linux 6.10-rc1 thanks, John Hubbard tools/testing/selftests/timers/rtcpie.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) base-commit: 8a9c6c40432e265600232b864f97d7c675e8be52