From patchwork Fri Jul 12 08:53:14 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Muhammad Usama Anjum X-Patchwork-Id: 13731420 Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C31D31428E7; Fri, 12 Jul 2024 08:53:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.235.227.194 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720774413; cv=none; b=YsMzLUD2ShF6lCsf9qTwtCVPHkf6VhbZ+hj0sW+L1XKtjREzfWM47kQP6Qb66MGbKwYh5Au3HSKyDyAgB+YYz6ZZMA/69IhanhJshOpK1832dQGAN7cTXxTvzz3QWD4VPtdoEsdg2jSdv2KC9ciU2xrJ+jsZgTBk1jO6WwQP4Jo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720774413; c=relaxed/simple; bh=newjgmZ8NVY0WI0RWTkosD/XDmBr5O5rKuL1X4AnNXE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=FUzb6+NrSgsTs+uSr0XF+z0H7MbrjojBuzPPy09CXOPthkT9YWDZZT4pTUhO/K5LfuRlhRVGIYngXrL16gH4bMqwscJI8pmxFzpmcAzujVmjmAcgYKmi6bpEQemyNWP09vD+LyOwX2SCsH9DTqPRqc1M74AmdvmlJfZyJTNtwjY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=vfU8HLDG; arc=none smtp.client-ip=46.235.227.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="vfU8HLDG" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1720774409; bh=newjgmZ8NVY0WI0RWTkosD/XDmBr5O5rKuL1X4AnNXE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=vfU8HLDGV6WAgWgFzDAPD6TJTW34FLpE+t/vQJOS2F/+M95lGSlnkKpsL0tOzbYx2 yzJr+eLVJewz09ZBIrJEmITFJ37wQco0UlLOkYBJftoOstKyCSMGV/SJnskYK30tFm NmsuqyHbk0F4JWGSvVX+0S6wEDbS/WqkOSIMjNM4jeCWnB2MgJRT1g288ApPilcw9l 27JardrtR+SuMnIVhbm0k1suYZBLbqKucl8ieZp8p7xr6aJN8SlHOejqixqWgDwxcz nF+Jmh7ghfRTmWSHLGSUmFFl+Eryzk9lip9HFYrfnQ9rxNKYWi9TdV6MoLObedunyu ZHE16P7ejfz6w== Received: from localhost.localdomain (ec2-34-240-57-77.eu-west-1.compute.amazonaws.com [34.240.57.77]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: usama.anjum) by madrid.collaboradmins.com (Postfix) with ESMTPSA id CDAD63782212; Fri, 12 Jul 2024 08:53:26 +0000 (UTC) From: Muhammad Usama Anjum To: Shuah Khan , Muhammad Usama Anjum , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Cc: kernel@collabora.com, "Chang S . Bae" , Binbin Wu , Ingo Molnar , "Kirill A . Shutemov" Subject: [PATCH v3 1/4] selftests: x86: check_initial_reg_state: remove manual counting and increase maintainability Date: Fri, 12 Jul 2024 13:53:14 +0500 Message-Id: <20240712085318.315386-2-usama.anjum@collabora.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240712085318.315386-1-usama.anjum@collabora.com> References: <20240712085318.315386-1-usama.anjum@collabora.com> Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 - Removes manual counting of pass and fail tests - Increase readability and maintainability of tests - Print logs in standard format (without [RUN], [OK] tags) Signed-off-by: Muhammad Usama Anjum --- .../selftests/x86/check_initial_reg_state.c | 24 +++++++++---------- 1 file changed, 11 insertions(+), 13 deletions(-) diff --git a/tools/testing/selftests/x86/check_initial_reg_state.c b/tools/testing/selftests/x86/check_initial_reg_state.c index 3bc95f3ed5859..b91c2b06b9881 100644 --- a/tools/testing/selftests/x86/check_initial_reg_state.c +++ b/tools/testing/selftests/x86/check_initial_reg_state.c @@ -7,6 +7,7 @@ #define _GNU_SOURCE #include +#include "../kselftest.h" unsigned long ax, bx, cx, dx, si, di, bp, sp, flags; unsigned long r8, r9, r10, r11, r12, r13, r14, r15; @@ -53,20 +54,19 @@ asm ( int main() { - int nerrs = 0; + ksft_print_header(); + ksft_set_plan(2); - if (sp == 0) { - printf("[FAIL]\tTest was built incorrectly\n"); - return 1; - } + if (sp == 0) + ksft_exit_fail_msg("Test was built incorrectly\n"); if (ax || bx || cx || dx || si || di || bp #ifdef __x86_64__ || r8 || r9 || r10 || r11 || r12 || r13 || r14 || r15 #endif ) { - printf("[FAIL]\tAll GPRs except SP should be 0\n"); -#define SHOW(x) printf("\t" #x " = 0x%lx\n", x); + ksft_test_result_fail("All GPRs except SP should be 0\n"); +#define SHOW(x) ksft_print_msg("\t" #x " = 0x%lx\n", x) SHOW(ax); SHOW(bx); SHOW(cx); @@ -85,17 +85,15 @@ int main() SHOW(r14); SHOW(r15); #endif - nerrs++; } else { - printf("[OK]\tAll GPRs except SP are 0\n"); + ksft_test_result_pass("All GPRs except SP are 0\n"); } if (flags != 0x202) { - printf("[FAIL]\tFLAGS is 0x%lx, but it should be 0x202\n", flags); - nerrs++; + ksft_test_result_fail("FLAGS is 0x%lx, but it should be 0x202\n", flags); } else { - printf("[OK]\tFLAGS is 0x202\n"); + ksft_test_result_pass("FLAGS is 0x202\n"); } - return nerrs ? 1 : 0; + ksft_finished(); }