| Message ID | 20240715192634.19272-1-shreeya.patel@collabora.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 0b631ed3ce922b34dad4938215f84e5321f7e524 |
| Headers | show |
| Series | [v2] kselftest: cpufreq: Add RTC wakeup alarm | expand |
On 16-07-24, 00:56, Shreeya Patel wrote: > Add RTC wakeup alarm for devices to resume after specific time interval. > This improvement in the test will help in enabling this test > in the CI systems and will eliminate the need of manual intervention > for resuming back the devices after suspend/hibernation. > > Signed-off-by: Shreeya Patel <shreeya.patel@collabora.com> > --- > > Changes in v2 > - Use rtcwake utility instead of sysfs for setting up > a RTC wakeup alarm > > tools/testing/selftests/cpufreq/cpufreq.sh | 15 +++++++++++++++ > tools/testing/selftests/cpufreq/main.sh | 13 ++++++++++++- > 2 files changed, 27 insertions(+), 1 deletion(-) Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
On 7/24/24 21:57, Viresh Kumar wrote: > On 16-07-24, 00:56, Shreeya Patel wrote: >> Add RTC wakeup alarm for devices to resume after specific time interval. >> This improvement in the test will help in enabling this test >> in the CI systems and will eliminate the need of manual intervention >> for resuming back the devices after suspend/hibernation. >> >> Signed-off-by: Shreeya Patel <shreeya.patel@collabora.com> >> --- >> >> Changes in v2 >> - Use rtcwake utility instead of sysfs for setting up >> a RTC wakeup alarm >> >> tools/testing/selftests/cpufreq/cpufreq.sh | 15 +++++++++++++++ >> tools/testing/selftests/cpufreq/main.sh | 13 ++++++++++++- >> 2 files changed, 27 insertions(+), 1 deletion(-) > > Acked-by: Viresh Kumar <viresh.kumar@linaro.org> > Thank you. I will apply this once merge window closes. thanks, -- Shuah
diff --git a/tools/testing/selftests/cpufreq/cpufreq.sh b/tools/testing/selftests/cpufreq/cpufreq.sh index b583a2fb4504..a427de1f9e08 100755 --- a/tools/testing/selftests/cpufreq/cpufreq.sh +++ b/tools/testing/selftests/cpufreq/cpufreq.sh @@ -232,6 +232,21 @@ do_suspend() for i in `seq 1 $2`; do printf "Starting $1\n" + + if [ "$3" = "rtc" ]; then + if ! command -v rtcwake &> /dev/null; then + printf "rtcwake could not be found, please install it.\n" + return 1 + fi + + rtcwake -m $filename -s 15 + + if [ $? -ne 0 ]; then + printf "Failed to suspend using RTC wake alarm\n" + return 1 + fi + fi + echo $filename > $SYSFS/power/state printf "Came out of $1\n" diff --git a/tools/testing/selftests/cpufreq/main.sh b/tools/testing/selftests/cpufreq/main.sh index 60ce18ed0666..b1ca4147a5e6 100755 --- a/tools/testing/selftests/cpufreq/main.sh +++ b/tools/testing/selftests/cpufreq/main.sh @@ -24,6 +24,8 @@ helpme() [-t <basic: Basic cpufreq testing suspend: suspend/resume, hibernate: hibernate/resume, + suspend_rtc: suspend/resume back using the RTC wakeup alarm, + hibernate_rtc: hibernate/resume back using the RTC wakeup alarm, modtest: test driver or governor modules. Only to be used with -d or -g options, sptest1: Simple governor switch to produce lockdep. sptest2: Concurrent governor switch to produce lockdep. @@ -76,7 +78,8 @@ parse_arguments() helpme ;; - t) # --func_type (Function to perform: basic, suspend, hibernate, modtest, sptest1/2/3/4 (default: basic)) + t) # --func_type (Function to perform: basic, suspend, hibernate, + # suspend_rtc, hibernate_rtc, modtest, sptest1/2/3/4 (default: basic)) FUNC=$OPTARG ;; @@ -122,6 +125,14 @@ do_test() do_suspend "hibernate" 1 ;; + "suspend_rtc") + do_suspend "suspend" 1 rtc + ;; + + "hibernate_rtc") + do_suspend "hibernate" 1 rtc + ;; + "modtest") # Do we have modules in place? if [ -z $DRIVER_MOD ] && [ -z $GOVERNOR_MOD ]; then
Add RTC wakeup alarm for devices to resume after specific time interval. This improvement in the test will help in enabling this test in the CI systems and will eliminate the need of manual intervention for resuming back the devices after suspend/hibernation. Signed-off-by: Shreeya Patel <shreeya.patel@collabora.com> --- Changes in v2 - Use rtcwake utility instead of sysfs for setting up a RTC wakeup alarm tools/testing/selftests/cpufreq/cpufreq.sh | 15 +++++++++++++++ tools/testing/selftests/cpufreq/main.sh | 13 ++++++++++++- 2 files changed, 27 insertions(+), 1 deletion(-)