diff mbox series

kselftest: timers: Fix const correctness

Message ID 20240819174814.139344-3-pZ010001011111@proton.me (mailing list archive)
State Accepted
Headers show
Series kselftest: timers: Fix const correctness | expand

Commit Message

Piotr Zalewski Aug. 19, 2024, 5:58 p.m. UTC 
Make timespec pointers, pointers to const in checklist function. As a
consequence, make list parameter in checklist function pointer to const
as well. Const-correctness increases readability.

Improvement was found by running cppcheck tool on the patched file as
follows:
```
cppcheck --enable=all \
	tools/testing/selftests/timers/threadtest.c \
	--suppress=missingIncludeSystem \
	--suppress=unusedFunction
```

Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>
Signed-off-by: Piotr Zalewski <pZ010001011111@proton.me>
---
 tools/testing/selftests/timers/threadtest.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

John Stultz Aug. 19, 2024, 6:34 p.m. UTC | #1 
On Mon, Aug 19, 2024 at 10:58 AM Piotr Zalewski
<pZ010001011111@proton.me> wrote:
>
> Make timespec pointers, pointers to const in checklist function. As a
> consequence, make list parameter in checklist function pointer to const
> as well. Const-correctness increases readability.
>
> Improvement was found by running cppcheck tool on the patched file as
> follows:
> ```
> cppcheck --enable=all \
>         tools/testing/selftests/timers/threadtest.c \
>         --suppress=missingIncludeSystem \
>         --suppress=unusedFunction
> ```
>
> Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>
> Signed-off-by: Piotr Zalewski <pZ010001011111@proton.me>

Acked-by: John Stultz <jstultz@google.com>

thanks
-john
diff mbox series

Patch

diff --git a/tools/testing/selftests/timers/threadtest.c b/tools/testing/selftests/timers/threadtest.c
index 76b38e41d9c7..d5564bbf0e50 100644
--- a/tools/testing/selftests/timers/threadtest.c
+++ b/tools/testing/selftests/timers/threadtest.c
@@ -38,10 +38,10 @@  struct timespec global_list[LISTSIZE];
 int listcount = 0;
 
 
-void checklist(struct timespec *list, int size)
+void checklist(const struct timespec *list, int size)
 {
 	int i, j;
-	struct timespec *a, *b;
+	const struct timespec *a, *b;
 
 	/* scan the list */
 	for (i = 0; i < size-1; i++) {