diff mbox series

[net-next] net-timestamp: correct the use of SOF_TIMESTAMPING_RAW_HARDWARE

Message ID 20240906095706.77636-1-kerneljasonxing@gmail.com (mailing list archive)
State Accepted
Commit e503f82e304b039332226008addac9d13ac68cb9
Headers show
Series [net-next] net-timestamp: correct the use of SOF_TIMESTAMPING_RAW_HARDWARE | expand

Commit Message

Jason Xing Sept. 6, 2024, 9:57 a.m. UTC 
From: Jason Xing <kernelxing@tencent.com>

SOF_TIMESTAMPING_RAW_HARDWARE is a report flag which passes the
timestamps generated by either SOF_TIMESTAMPING_TX_HARDWARE or
SOF_TIMESTAMPING_RX_HARDWARE to the userspace all the time.

So let us revise the doc here.

Link: Link: https://lore.kernel.org/all/66d8c21d3042a_163d93294cb@willemb.c.googlers.com.notmuch/
Suggested-by: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Reviewed-by: Willem de Bruijn <willemb@google.com>
Signed-off-by: Jason Xing <kernelxing@tencent.com>
---
previous version
Link: https://lore.kernel.org/all/66d9b467d02d3_18ac2129427@willemb.c.googlers.com.notmuch/
Link: https://lore.kernel.org/all/66d9c3f875b90_18de412948b@willemb.c.googlers.com.notmuch/
1. cook this as a stand-alone patch (Willem)
2. add Willem's reviewed-by tag since this patch doesn't change
3. move the reference link at the top of S-b tag
---
 Documentation/networking/timestamping.rst | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Willem de Bruijn Sept. 6, 2024, 3:26 p.m. UTC | #1 
Jason Xing wrote:
> From: Jason Xing <kernelxing@tencent.com>
> 
> SOF_TIMESTAMPING_RAW_HARDWARE is a report flag which passes the
> timestamps generated by either SOF_TIMESTAMPING_TX_HARDWARE or
> SOF_TIMESTAMPING_RX_HARDWARE to the userspace all the time.
> 
> So let us revise the doc here.
> 
> Link: Link: https://lore.kernel.org/all/66d8c21d3042a_163d93294cb@willemb.c.googlers.com.notmuch/

nit: duplicate keyword

> Suggested-by: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
> Reviewed-by: Willem de Bruijn <willemb@google.com>

indeed

> Signed-off-by: Jason Xing <kernelxing@tencent.com>
Jason Xing Sept. 6, 2024, 4:18 p.m. UTC | #2 
On Fri, Sep 6, 2024 at 11:26 PM Willem de Bruijn
<willemdebruijn.kernel@gmail.com> wrote:
>
> Jason Xing wrote:
> > From: Jason Xing <kernelxing@tencent.com>
> >
> > SOF_TIMESTAMPING_RAW_HARDWARE is a report flag which passes the
> > timestamps generated by either SOF_TIMESTAMPING_TX_HARDWARE or
> > SOF_TIMESTAMPING_RX_HARDWARE to the userspace all the time.
> >
> > So let us revise the doc here.
> >
> > Link: Link: https://lore.kernel.org/all/66d8c21d3042a_163d93294cb@willemb.c.googlers.com.notmuch/

Something seems wrong with my macbook... Really strange

Ah, sorry, I have to repost it...

>
> nit: duplicate keyword
>
> > Suggested-by: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
> > Reviewed-by: Willem de Bruijn <willemb@google.com>
>
> indeed

Thanks.
diff mbox series

Patch

diff --git a/Documentation/networking/timestamping.rst b/Documentation/networking/timestamping.rst
index 5e93cd71f99f..9c7773271393 100644
--- a/Documentation/networking/timestamping.rst
+++ b/Documentation/networking/timestamping.rst
@@ -158,7 +158,8 @@  SOF_TIMESTAMPING_SYS_HARDWARE:
 
 SOF_TIMESTAMPING_RAW_HARDWARE:
   Report hardware timestamps as generated by
-  SOF_TIMESTAMPING_TX_HARDWARE when available.
+  SOF_TIMESTAMPING_TX_HARDWARE or SOF_TIMESTAMPING_RX_HARDWARE
+  when available.
 
 
 1.3.3 Timestamp Options