| Message ID | 20240924175500.17212-1-david.hunter.linux@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [v1,1/1] selftests: set executable bit | expand |
Hi David, On Tue, 24 Sep 2024 13:54:57 -0400 David Hunter <david.hunter.linux@gmail.com> wrote: > Turn on the executable bit for the following script files. These scripts > are set to TEST_PROGS in their respective Makefiles, but currently, when > these tests are run, a warning occurs: > > # Warning: <file> is not executable Thank you so much for finding this issue and sending this nice fix! > > Signed-off-by: David Hunter <david.hunter.linux@gmail.com> > --- > tools/testing/selftests/damon/damon_nr_regions.py | 0 > tools/testing/selftests/damon/damos_apply_interval.py | 0 > tools/testing/selftests/damon/damos_quota.py | 0 > tools/testing/selftests/damon/damos_quota_goal.py | 0 > tools/testing/selftests/damon/damos_tried_regions.py | 0 > tools/testing/selftests/damon/debugfs_target_ids_pid_leak.sh | 0 > .../damon/debugfs_target_ids_read_before_terminate_race.sh | 0 > .../selftests/damon/sysfs_update_schemes_tried_regions_hang.py | 0 > .../damon/sysfs_update_schemes_tried_regions_wss_estimation.py | 0 > tools/testing/selftests/net/rds/test.py | 0 > 10 files changed, 0 insertions(+), 0 deletions(-) > mode change 100644 => 100755 tools/testing/selftests/damon/damon_nr_regions.py > mode change 100644 => 100755 tools/testing/selftests/damon/damos_apply_interval.py > mode change 100644 => 100755 tools/testing/selftests/damon/damos_quota.py > mode change 100644 => 100755 tools/testing/selftests/damon/damos_quota_goal.py > mode change 100644 => 100755 tools/testing/selftests/damon/damos_tried_regions.py > mode change 100644 => 100755 tools/testing/selftests/damon/debugfs_target_ids_pid_leak.sh > mode change 100644 => 100755 tools/testing/selftests/damon/debugfs_target_ids_read_before_terminate_race.sh > mode change 100644 => 100755 tools/testing/selftests/damon/sysfs_update_schemes_tried_regions_hang.py > mode change 100644 => 100755 tools/testing/selftests/damon/sysfs_update_schemes_tried_regions_wss_estimation.py > mode change 100644 => 100755 tools/testing/selftests/net/rds/test.py However, a very similar fix has already posted [1] and merged [2] into the mainline. So, apparently there was a trivial race. I'm looking forward to your next patches for DAMON, though! [1] https://lore.kernel.org/20240827030336.7930-4-sj@kernel.org [2] https://github.com/torvalds/linux/commit/8c211412c5dffd090eaea5ee033cd729f8e5f873 Thanks, SJ [...]
diff --git a/tools/testing/selftests/damon/damon_nr_regions.py b/tools/testing/selftests/damon/damon_nr_regions.py old mode 100644 new mode 100755 diff --git a/tools/testing/selftests/damon/damos_apply_interval.py b/tools/testing/selftests/damon/damos_apply_interval.py old mode 100644 new mode 100755 diff --git a/tools/testing/selftests/damon/damos_quota.py b/tools/testing/selftests/damon/damos_quota.py old mode 100644 new mode 100755 diff --git a/tools/testing/selftests/damon/damos_quota_goal.py b/tools/testing/selftests/damon/damos_quota_goal.py old mode 100644 new mode 100755 diff --git a/tools/testing/selftests/damon/damos_tried_regions.py b/tools/testing/selftests/damon/damos_tried_regions.py old mode 100644 new mode 100755 diff --git a/tools/testing/selftests/damon/debugfs_target_ids_pid_leak.sh b/tools/testing/selftests/damon/debugfs_target_ids_pid_leak.sh old mode 100644 new mode 100755 diff --git a/tools/testing/selftests/damon/debugfs_target_ids_read_before_terminate_race.sh b/tools/testing/selftests/damon/debugfs_target_ids_read_before_terminate_race.sh old mode 100644 new mode 100755 diff --git a/tools/testing/selftests/damon/sysfs_update_schemes_tried_regions_hang.py b/tools/testing/selftests/damon/sysfs_update_schemes_tried_regions_hang.py old mode 100644 new mode 100755 diff --git a/tools/testing/selftests/damon/sysfs_update_schemes_tried_regions_wss_estimation.py b/tools/testing/selftests/damon/sysfs_update_schemes_tried_regions_wss_estimation.py old mode 100644 new mode 100755 diff --git a/tools/testing/selftests/net/rds/test.py b/tools/testing/selftests/net/rds/test.py old mode 100644 new mode 100755
Turn on the executable bit for the following script files. These scripts are set to TEST_PROGS in their respective Makefiles, but currently, when these tests are run, a warning occurs: # Warning: <file> is not executable Signed-off-by: David Hunter <david.hunter.linux@gmail.com> --- tools/testing/selftests/damon/damon_nr_regions.py | 0 tools/testing/selftests/damon/damos_apply_interval.py | 0 tools/testing/selftests/damon/damos_quota.py | 0 tools/testing/selftests/damon/damos_quota_goal.py | 0 tools/testing/selftests/damon/damos_tried_regions.py | 0 tools/testing/selftests/damon/debugfs_target_ids_pid_leak.sh | 0 .../damon/debugfs_target_ids_read_before_terminate_race.sh | 0 .../selftests/damon/sysfs_update_schemes_tried_regions_hang.py | 0 .../damon/sysfs_update_schemes_tried_regions_wss_estimation.py | 0 tools/testing/selftests/net/rds/test.py | 0 10 files changed, 0 insertions(+), 0 deletions(-) mode change 100644 => 100755 tools/testing/selftests/damon/damon_nr_regions.py mode change 100644 => 100755 tools/testing/selftests/damon/damos_apply_interval.py mode change 100644 => 100755 tools/testing/selftests/damon/damos_quota.py mode change 100644 => 100755 tools/testing/selftests/damon/damos_quota_goal.py mode change 100644 => 100755 tools/testing/selftests/damon/damos_tried_regions.py mode change 100644 => 100755 tools/testing/selftests/damon/debugfs_target_ids_pid_leak.sh mode change 100644 => 100755 tools/testing/selftests/damon/debugfs_target_ids_read_before_terminate_race.sh mode change 100644 => 100755 tools/testing/selftests/damon/sysfs_update_schemes_tried_regions_hang.py mode change 100644 => 100755 tools/testing/selftests/damon/sysfs_update_schemes_tried_regions_wss_estimation.py mode change 100644 => 100755 tools/testing/selftests/net/rds/test.py