| Message ID | 20240925050539.1906-1-kacper@ludwinski.dev (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 9f49d14ec41ce7be647028d7d34dea727af55272 |
| Headers | show |
| Series | Fix issue related with assigning two diffrent vids to the same interface. | expand |
On Wed, Sep 25, 2024 at 02:05:39PM +0900, Kacper Ludwinski wrote: > Fixes: 476a4f05d9b8 ("selftests: forwarding: add a no_forwarding.sh test") > Signed-off-by: Kacper Ludwinski <kacper@ludwinski.dev> > --- > tools/testing/selftests/net/forwarding/no_forwarding.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) ... Hi Kacper, Thanks for your patch. Some feedback in process: * Please do not post updated versions of patches within 24h of each other. * Please do post new versions of patches in new threads, with appropriate versions in the subject (v2 in this case). And some text under the scissors ('---') describing that the change is. b4 will handle this for you. * Please include some text in the commit message, in this case describing the problem that is being resolved. * Please tag patches for Networking as being targeted at either the net or net-next trees. Subject: [PATCH net v2] ... * Please refer to git history and include an appropriate prefix in the subject of the patch. In this case it looks like it should be 'selftests: forwarding:' Subject: [PATCH net v2] selftests: forwarding: ... * Please consider reading the netdev maintainers process guide https://docs.kernel.org/process/maintainer-netdev.html Lastly, there is a spelling error in the subject. checkpatch.pl --codespell flagged this.
Hi Kacper, When you post a second patch, you need to add PATCHv2 in the subject. On Wed, Sep 25, 2024 at 02:05:39PM +0900, Kacper Ludwinski wrote: > Fixes: 476a4f05d9b8 ("selftests: forwarding: add a no_forwarding.sh test") > Signed-off-by: Kacper Ludwinski <kacper@ludwinski.dev> > --- > tools/testing/selftests/net/forwarding/no_forwarding.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/net/forwarding/no_forwarding.sh b/tools/testing/selftests/net/forwarding/no_forwarding.sh > index 9e677aa64a06..694ece9ba3a7 100755 > --- a/tools/testing/selftests/net/forwarding/no_forwarding.sh > +++ b/tools/testing/selftests/net/forwarding/no_forwarding.sh > @@ -202,7 +202,7 @@ one_bridge_two_pvids() > ip link set $swp2 master br0 > > bridge vlan add dev $swp1 vid 1 pvid untagged > - bridge vlan add dev $swp1 vid 2 pvid untagged > + bridge vlan add dev $swp2 vid 2 pvid untagged > > run_test "Switch ports in VLAN-aware bridge with different PVIDs" > The patch looks good to me. Reviewed-by: Hangbin Liu <liuhangbin@gmail.com>
diff --git a/tools/testing/selftests/net/forwarding/no_forwarding.sh b/tools/testing/selftests/net/forwarding/no_forwarding.sh index 9e677aa64a06..694ece9ba3a7 100755 --- a/tools/testing/selftests/net/forwarding/no_forwarding.sh +++ b/tools/testing/selftests/net/forwarding/no_forwarding.sh @@ -202,7 +202,7 @@ one_bridge_two_pvids() ip link set $swp2 master br0 bridge vlan add dev $swp1 vid 1 pvid untagged - bridge vlan add dev $swp1 vid 2 pvid untagged + bridge vlan add dev $swp2 vid 2 pvid untagged run_test "Switch ports in VLAN-aware bridge with different PVIDs"
Fixes: 476a4f05d9b8 ("selftests: forwarding: add a no_forwarding.sh test") Signed-off-by: Kacper Ludwinski <kacper@ludwinski.dev> --- tools/testing/selftests/net/forwarding/no_forwarding.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)