diff mbox series

kunit: constify return of string literals

Message ID 20241125105240.44219-1-cgoettsche@seltendoof.de (mailing list archive)
State New
Delegated to: Brendan Higgins
Headers show
Series kunit: constify return of string literals | expand

Commit Message

Christian Göttsche Nov. 25, 2024, 10:52 a.m. UTC 
From: Christian Göttsche <cgzones@googlemail.com>

The function kunit_status_to_ok_not_ok() returns string literals, thus
declare the return value as such.

Reported by clang:

    ./include/kunit/test.h:143:10: warning: returning 'const char[3]' from a function with result type 'char *' discards qualifiers [-Wincompatible-pointer-types-discards-qualifiers]
      143 |                 return "ok";
          |                        ^~~~
    ./include/kunit/test.h:145:10: warning: returning 'const char[7]' from a function with result type 'char *' discards qualifiers [-Wincompatible-pointer-types-discards-qualifiers]
      145 |                 return "not ok";
          |                        ^~~~~~~~
    ./include/kunit/test.h:147:9: warning: returning 'const char[8]' from a function with result type 'char *' discards qualifiers [-Wincompatible-pointer-types-discards-qualifiers]
      147 |         return "invalid";
          |                ^~~~~~~~~

Signed-off-by: Christian Göttsche <cgzones@googlemail.com>
---
 include/kunit/test.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/include/kunit/test.h b/include/kunit/test.h
index 34b71e42fb10..ae1b57578476 100644
--- a/include/kunit/test.h
+++ b/include/kunit/test.h
@@ -135,7 +135,7 @@  struct kunit_case {
 	struct string_stream *log;
 };
 
-static inline char *kunit_status_to_ok_not_ok(enum kunit_status status)
+static inline const char *kunit_status_to_ok_not_ok(enum kunit_status status)
 {
 	switch (status) {
 	case KUNIT_SKIPPED: