| Message ID | 20241209151418.348085-1-maddy@linux.ibm.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [1/3] selftest/powerpc/ptrace/core-pkey: Remove duplicate macros | expand |
Madhavan Srinivasan <maddy@linux.ibm.com> writes: > core-pkey.c test has couple of macros defined which > are part of "pkeys.h" header file. Remove those > duplicates and include "pkeys.h" > > Signed-off-by: Madhavan Srinivasan <maddy@linux.ibm.com> > --- > .../selftests/powerpc/ptrace/core-pkey.c | 19 +------------------ > 1 file changed, 1 insertion(+), 18 deletions(-) .../powerpc/ptrace/Makefile includes flags.mk. In .../powerpc/flags.mk we anyways add -I$(selfdir)/powerpc/include in CFLAGS - so it will pick up the header files defined in powerpc/include. It make sense to clean this up and consolidate the common header definitions into pkeys.h header file. The changes looks good to me. Please feel free to add - Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com> -ritesh
On 12/16/24 4:17 PM, Ritesh Harjani (IBM) wrote: > Madhavan Srinivasan <maddy@linux.ibm.com> writes: > >> core-pkey.c test has couple of macros defined which >> are part of "pkeys.h" header file. Remove those >> duplicates and include "pkeys.h" >> >> Signed-off-by: Madhavan Srinivasan <maddy@linux.ibm.com> >> --- >> .../selftests/powerpc/ptrace/core-pkey.c | 19 +------------------ >> 1 file changed, 1 insertion(+), 18 deletions(-) > > .../powerpc/ptrace/Makefile includes flags.mk. In > .../powerpc/flags.mk we anyways add -I$(selfdir)/powerpc/include in > CFLAGS - so it will pick up the header files defined in powerpc/include. > > It make sense to clean this up and consolidate the common header definitions > into pkeys.h header file. The changes looks good to me. Please feel free > to add - > > Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com> Thanks > > -ritesh
diff --git a/tools/testing/selftests/powerpc/ptrace/core-pkey.c b/tools/testing/selftests/powerpc/ptrace/core-pkey.c index f6da4cb30cd6..31c9bf6d95db 100644 --- a/tools/testing/selftests/powerpc/ptrace/core-pkey.c +++ b/tools/testing/selftests/powerpc/ptrace/core-pkey.c @@ -16,14 +16,7 @@ #include <unistd.h> #include "ptrace.h" #include "child.h" - -#ifndef __NR_pkey_alloc -#define __NR_pkey_alloc 384 -#endif - -#ifndef __NR_pkey_free -#define __NR_pkey_free 385 -#endif +#include "pkeys.h" #ifndef NT_PPC_PKEY #define NT_PPC_PKEY 0x110 @@ -61,16 +54,6 @@ struct shared_info { time_t core_time; }; -static int sys_pkey_alloc(unsigned long flags, unsigned long init_access_rights) -{ - return syscall(__NR_pkey_alloc, flags, init_access_rights); -} - -static int sys_pkey_free(int pkey) -{ - return syscall(__NR_pkey_free, pkey); -} - static int increase_core_file_limit(void) { struct rlimit rlim;
core-pkey.c test has couple of macros defined which are part of "pkeys.h" header file. Remove those duplicates and include "pkeys.h" Signed-off-by: Madhavan Srinivasan <maddy@linux.ibm.com> --- .../selftests/powerpc/ptrace/core-pkey.c | 19 +------------------ 1 file changed, 1 insertion(+), 18 deletions(-)