| Message ID | 20241209151418.348085-2-maddy@linux.ibm.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [1/3] selftest/powerpc/ptrace/core-pkey: Remove duplicate macros | expand |
Madhavan Srinivasan <maddy@linux.ibm.com> writes: > ptrace-pkey.c test has macros defined which > are part of "pkeys.h" header file. Remove those > duplicates and include "pkeys.h" > > Signed-off-by: Madhavan Srinivasan <maddy@linux.ibm.com> > --- > .../testing/selftests/powerpc/ptrace/ptrace-pkey.c | 14 +------------- > 1 file changed, 1 insertion(+), 13 deletions(-) > Similar to previous patch. Cleanup looks good to me. Please feel free to add - Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com> -ritesh
On 12/16/24 4:24 PM, Ritesh Harjani (IBM) wrote: > Madhavan Srinivasan <maddy@linux.ibm.com> writes: > >> ptrace-pkey.c test has macros defined which >> are part of "pkeys.h" header file. Remove those >> duplicates and include "pkeys.h" >> >> Signed-off-by: Madhavan Srinivasan <maddy@linux.ibm.com> >> --- >> .../testing/selftests/powerpc/ptrace/ptrace-pkey.c | 14 +------------- >> 1 file changed, 1 insertion(+), 13 deletions(-) >> > > Similar to previous patch. Cleanup looks good to me. > > Please feel free to add - > Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com> > Thanks > -ritesh
diff --git a/tools/testing/selftests/powerpc/ptrace/ptrace-pkey.c b/tools/testing/selftests/powerpc/ptrace/ptrace-pkey.c index d89474377f11..6893ed096457 100644 --- a/tools/testing/selftests/powerpc/ptrace/ptrace-pkey.c +++ b/tools/testing/selftests/powerpc/ptrace/ptrace-pkey.c @@ -7,14 +7,7 @@ */ #include "ptrace.h" #include "child.h" - -#ifndef __NR_pkey_alloc -#define __NR_pkey_alloc 384 -#endif - -#ifndef __NR_pkey_free -#define __NR_pkey_free 385 -#endif +#include "pkeys.h" #ifndef NT_PPC_PKEY #define NT_PPC_PKEY 0x110 @@ -61,11 +54,6 @@ struct shared_info { unsigned long invalid_uamor; }; -static int sys_pkey_alloc(unsigned long flags, unsigned long init_access_rights) -{ - return syscall(__NR_pkey_alloc, flags, init_access_rights); -} - static int child(struct shared_info *info) { unsigned long reg;
ptrace-pkey.c test has macros defined which are part of "pkeys.h" header file. Remove those duplicates and include "pkeys.h" Signed-off-by: Madhavan Srinivasan <maddy@linux.ibm.com> --- .../testing/selftests/powerpc/ptrace/ptrace-pkey.c | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-)