| Message ID | 20241210123212.332050-1-cvam0000@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | bd812d2858532cf5fc50e37a1c5d5c6b3cdbb3a3 |
| Headers | show |
| Series | [v2] selftests: acct: Add ksft_exit_skip if not running as root | expand |
On 12/10/24 05:32, Shivam Chaudhary wrote: > If the selftest is not running as root, it should skip not > fail and give an appropriate warning to the user. This patch adds > ksft_exit_skip() if the test is not running as root. > > Logs: > > Before change: > > TAP version 13 > 1..1 > ok 1 # SKIP This test needs root to run! > > After change: > > TAP version 13 > 1..1 > ok 2 # SKIP This test needs root to run! > Totals: pass:0 fail:0 xfail:0 xpass:0 skip:1 error:0 > > Signed-off-by: Shivam Chaudhary <cvam0000@gmail.com> > --- > > v1->v2 : Replace ksft_exit_fail_msg -> ksft_exit_skip > v1 : https://lore.kernel.org/all/20241115191721.621381-1-cvam0000@gmail.com/ > > tools/testing/selftests/acct/acct_syscall.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/acct/acct_syscall.c b/tools/testing/selftests/acct/acct_syscall.c > index e44e8fe1f4a3..87c044fb9293 100644 > --- a/tools/testing/selftests/acct/acct_syscall.c > +++ b/tools/testing/selftests/acct/acct_syscall.c > @@ -24,7 +24,7 @@ int main(void) > > // Check if test is run a root > if (geteuid()) { > - ksft_test_result_skip("This test needs root to run!\n"); > + ksft_exit_skip("This test needs root to run!\n"); > return 1; > } > Applied to linux-kselftest next for Linux 6.14-rc1 thanks, -- Shuah
diff --git a/tools/testing/selftests/acct/acct_syscall.c b/tools/testing/selftests/acct/acct_syscall.c index e44e8fe1f4a3..87c044fb9293 100644 --- a/tools/testing/selftests/acct/acct_syscall.c +++ b/tools/testing/selftests/acct/acct_syscall.c @@ -24,7 +24,7 @@ int main(void) // Check if test is run a root if (geteuid()) { - ksft_test_result_skip("This test needs root to run!\n"); + ksft_exit_skip("This test needs root to run!\n"); return 1; }
If the selftest is not running as root, it should skip not fail and give an appropriate warning to the user. This patch adds ksft_exit_skip() if the test is not running as root. Logs: Before change: TAP version 13 1..1 ok 1 # SKIP This test needs root to run! After change: TAP version 13 1..1 ok 2 # SKIP This test needs root to run! Totals: pass:0 fail:0 xfail:0 xpass:0 skip:1 error:0 Signed-off-by: Shivam Chaudhary <cvam0000@gmail.com> --- v1->v2 : Replace ksft_exit_fail_msg -> ksft_exit_skip v1 : https://lore.kernel.org/all/20241115191721.621381-1-cvam0000@gmail.com/ tools/testing/selftests/acct/acct_syscall.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)