| Message ID | 20250126195147.902608-1-khaledelnaggarlinux@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [v4] selftests: tpm2: create a dedicated .gitignore | expand |
On Sun Jan 26, 2025 at 9:51 PM EET, Khaled Elnaggar wrote: > The tpm2 selftests produce two logs: SpaceTest.log and > AsyncTest.log. Only SpaceTest.log was listed in selftests/.gitignore, > while AsyncTest.log remained untracked. > > This change creates a dedicated .gitignore in the tpm2/ directory to > manage these entries, keeping tpm2-specific patterns isolated from > parent .gitignore. > > Signed-off-by: Khaled Elnaggar <khaledelnaggarlinux@gmail.com> > --- > Oh no, I realized there was a mistake in v3. I wrote tpm2/*.log in the > tpm2/.gitignore file, which is unnecessary since tpm2/.gitignore is > already scoped to the tpm2 directory. > All entries are automatically relative to the tpm2 directory. > > I’ve fixed it by removing the redundant tpm2/ prefix from the entries > in tpm2/.gitignore. > > Apologies for not catching this earlier, I tested it after submitting > the patch because I was confident v2 was correct, but the issue was > introduced in v3. > > Thanks, > Khaled > > Changes: > v4: Correct the mistake in v3 > v3: Improve commit message (and introduce a mistake) > v2: Created a dedicated .gitignore > v1: https://lore.kernel.org/linux-kselftest/20250116085929.313677-1-eng.khaled.elnaggar@gmail.com > --- > tools/testing/selftests/.gitignore | 1 - > tools/testing/selftests/tpm2/.gitignore | 4 ++++ > 2 files changed, 4 insertions(+), 1 deletion(-) > create mode 100644 tools/testing/selftests/tpm2/.gitignore > > diff --git a/tools/testing/selftests/.gitignore b/tools/testing/selftests/.gitignore > index cb24124ac5b9..674aaa02e396 100644 > --- a/tools/testing/selftests/.gitignore > +++ b/tools/testing/selftests/.gitignore > @@ -4,7 +4,6 @@ gpiogpio-hammer > gpioinclude/ > gpiolsgpio > kselftest_install/ > -tpm2/SpaceTest.log > > # Python bytecode and cache > __pycache__/ > diff --git a/tools/testing/selftests/tpm2/.gitignore b/tools/testing/selftests/tpm2/.gitignore > new file mode 100644 > index 000000000000..910bbdbb336a > --- /dev/null > +++ b/tools/testing/selftests/tpm2/.gitignore > @@ -0,0 +1,4 @@ > +# SPDX-License-Identifier: GPL-2.0-only > +AsyncTest.log > +SpaceTest.log > + > -- > 2.45.2 Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org> BR, Jarkko
diff --git a/tools/testing/selftests/.gitignore b/tools/testing/selftests/.gitignore index cb24124ac5b9..674aaa02e396 100644 --- a/tools/testing/selftests/.gitignore +++ b/tools/testing/selftests/.gitignore @@ -4,7 +4,6 @@ gpiogpio-hammer gpioinclude/ gpiolsgpio kselftest_install/ -tpm2/SpaceTest.log # Python bytecode and cache __pycache__/ diff --git a/tools/testing/selftests/tpm2/.gitignore b/tools/testing/selftests/tpm2/.gitignore new file mode 100644 index 000000000000..910bbdbb336a --- /dev/null +++ b/tools/testing/selftests/tpm2/.gitignore @@ -0,0 +1,4 @@ +# SPDX-License-Identifier: GPL-2.0-only +AsyncTest.log +SpaceTest.log +
The tpm2 selftests produce two logs: SpaceTest.log and AsyncTest.log. Only SpaceTest.log was listed in selftests/.gitignore, while AsyncTest.log remained untracked. This change creates a dedicated .gitignore in the tpm2/ directory to manage these entries, keeping tpm2-specific patterns isolated from parent .gitignore. Signed-off-by: Khaled Elnaggar <khaledelnaggarlinux@gmail.com> --- Oh no, I realized there was a mistake in v3. I wrote tpm2/*.log in the tpm2/.gitignore file, which is unnecessary since tpm2/.gitignore is already scoped to the tpm2 directory. All entries are automatically relative to the tpm2 directory. I’ve fixed it by removing the redundant tpm2/ prefix from the entries in tpm2/.gitignore. Apologies for not catching this earlier, I tested it after submitting the patch because I was confident v2 was correct, but the issue was introduced in v3. Thanks, Khaled Changes: v4: Correct the mistake in v3 v3: Improve commit message (and introduce a mistake) v2: Created a dedicated .gitignore v1: https://lore.kernel.org/linux-kselftest/20250116085929.313677-1-eng.khaled.elnaggar@gmail.com --- tools/testing/selftests/.gitignore | 1 - tools/testing/selftests/tpm2/.gitignore | 4 ++++ 2 files changed, 4 insertions(+), 1 deletion(-) create mode 100644 tools/testing/selftests/tpm2/.gitignore -- 2.45.2