[net-next,v3,02/10] net: pktgen: enable 'param=value' parsing

Commit Message

Peter Seiderer Feb. 3, 2025, 5:01 p.m. UTC

Enable additional to 'parm value' the 'param=value' parsing (otherwise
skipping '=' in count_trail_chars() is useless).

Tested with:

	$ echo "min_pkt_size 999" > /proc/net/pktgen/lo\@0
	$ echo "min_pkt_size=999" > /proc/net/pktgen/lo\@0
	$ echo "min_pkt_size =999" > /proc/net/pktgen/lo\@0
	$ echo "min_pkt_size= 999" > /proc/net/pktgen/lo\@0
	$ echo "min_pkt_size = 999" > /proc/net/pktgen/lo\@0

Signed-off-by: Peter Seiderer <[e-mail]>
---
Changes v2 -> v3:
  - no changes

Changes v1 -> v2:
  - no changes
---
 net/core/pktgen.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Paolo Abeni Feb. 4, 2025, 10:55 a.m. UTC | #1

On 2/3/25 6:01 PM, Peter Seiderer wrote:
> Enable additional to 'parm value' the 'param=value' parsing

It could be language bias on my side, by I find the above statement hard
to parse. Could you please rephrase it?

IMHO something alike:

"""
Enable more flexible parameters syntax, allowing "param=value" in
addition to the already supported "param value" pattern.
"""

Thanks,

Paolo

Patch

diff --git a/net/core/pktgen.c b/net/core/pktgen.c
index 496aa16773e7..4f8ec6c9bed4 100644
--- a/net/core/pktgen.c
+++ b/net/core/pktgen.c
@@ -823,6 +823,7 @@  static int strn_len(const char __user * user_buffer, unsigned int maxlen)
 		case '\r':
 		case '\t':
 		case ' ':
+		case '=':
 			goto done_str;
 		default:
 			break;