diff mbox series

[v1] selftests/landlock: Enable the new CONFIG_AF_UNIX_OOB

Message ID 20250211132531.1625566-1-mic@digikod.net (mailing list archive)
State New
Headers show
Series [v1] selftests/landlock: Enable the new CONFIG_AF_UNIX_OOB | expand

Commit Message

Mickaël Salaün Feb. 11, 2025, 1:25 p.m. UTC
Since commit 5155cbcdbf03 ("af_unix: Add a prompt to
CONFIG_AF_UNIX_OOB"), the Landlock selftests's configuration is not
enough to build a minimal kernel.  Because scoped_signal_test checks
with the MSG_OOB flag, we need to enable CONFIG_AF_UNIX_OOB for tests:

 #  RUN           fown.no_sandbox.sigurg_socket ...
 # scoped_signal_test.c:420:sigurg_socket:Expected 1 (1) == send(client_socket, ".", 1, MSG_OOB) (-1)
 # sigurg_socket: Test terminated by assertion
 #          FAIL  fown.no_sandbox.sigurg_socket
 ...

Cc: Florent Revest <revest@chromium.org>
Cc: Günther Noack <gnoack@google.com>
Signed-off-by: Mickaël Salaün <mic@digikod.net>
---
 tools/testing/selftests/landlock/config | 1 +
 1 file changed, 1 insertion(+)

Comments

Florent Revest Feb. 13, 2025, 10:32 p.m. UTC | #1
On Tue, Feb 11, 2025 at 2:26 PM Mickaël Salaün <mic@digikod.net> wrote:
>
> Since commit 5155cbcdbf03 ("af_unix: Add a prompt to
> CONFIG_AF_UNIX_OOB"), the Landlock selftests's configuration is not
> enough to build a minimal kernel.  Because scoped_signal_test checks
> with the MSG_OOB flag, we need to enable CONFIG_AF_UNIX_OOB for tests:

Makes sense. Thank you!

Acked-by: Florent Revest <revest@chromium.org>

>  #  RUN           fown.no_sandbox.sigurg_socket ...
>  # scoped_signal_test.c:420:sigurg_socket:Expected 1 (1) == send(client_socket, ".", 1, MSG_OOB) (-1)
>  # sigurg_socket: Test terminated by assertion
>  #          FAIL  fown.no_sandbox.sigurg_socket
>  ...
>
> Cc: Florent Revest <revest@chromium.org>
> Cc: Günther Noack <gnoack@google.com>
> Signed-off-by: Mickaël Salaün <mic@digikod.net>
> ---
>  tools/testing/selftests/landlock/config | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/tools/testing/selftests/landlock/config b/tools/testing/selftests/landlock/config
> index 29af19c4e9f9..361f94f8cb0d 100644
> --- a/tools/testing/selftests/landlock/config
> +++ b/tools/testing/selftests/landlock/config
> @@ -1,3 +1,4 @@
> +CONFIG_AF_UNIX_OOB=y
>  CONFIG_CGROUPS=y
>  CONFIG_CGROUP_SCHED=y
>  CONFIG_INET=y
> --
> 2.48.1
>
diff mbox series

Patch

diff --git a/tools/testing/selftests/landlock/config b/tools/testing/selftests/landlock/config
index 29af19c4e9f9..361f94f8cb0d 100644
--- a/tools/testing/selftests/landlock/config
+++ b/tools/testing/selftests/landlock/config
@@ -1,3 +1,4 @@ 
+CONFIG_AF_UNIX_OOB=y
 CONFIG_CGROUPS=y
 CONFIG_CGROUP_SCHED=y
 CONFIG_INET=y