| Message ID | 20250212-nolibc-test-constructor-v1-1-c963875b3da4@weissschuh.net (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | selftests/nolibc: only run constructor tests on nolibc | expand |
On Wed, Feb 12, 2025 at 07:01:01PM +0100, Thomas Weißschuh wrote: > The nolibc testsuite can be run against other libcs to test for > interoperability. Some aspects of the constructor execution are not > standardized and musl does not provide all tested feature, for one it > does not provide arguments to the constructors, anymore? > > Skip the constructor tests on non-nolibc configurations. I'm not much surprised, I've always avoided arguments in my use of constructors due to a lack of portability. However the patch disables all constructors tests, while I'm seeing that the linkage_test version does not make use of arguments, though there is an implied expectation that they're executed in declaration order, which is not granted. I'm wondering if we shouldn't make the tests more robust: 1) explicitly set linkage_test_constructor_test_value to zero in the declaration, because here it's not set so we have no guarantee (we're not in the kernel) 2) only add values to check for cumulated values (e.g. |1 in const1, |2 in const2) and verify that the result is properly 3 3) make the argument test add a distinct value (|4) so that when testing it's instantly obvious which test was not called. And indeed, we can disable the tests we know fail on other libcs and even split that by feature (e.g. test that at least one constructor was called using !=0, that all non-arg ones were called via &3 == 3, and that the args were passed via &4==4). That would allow to further refine the tests if desired so that we can keep the differences in mind. In any case all of this can also be done later, and I'm obviously fine with this immediate adjustement. > Signed-off-by: Thomas Weißschuh <linux@weissschuh.net> Acked-by: Willy Tarreau <w@1wt.eu> Willy
On 2025-02-16 10:39:40+0100, Willy Tarreau wrote: > On Wed, Feb 12, 2025 at 07:01:01PM +0100, Thomas Weißschuh wrote: > > The nolibc testsuite can be run against other libcs to test for > > interoperability. Some aspects of the constructor execution are not > > standardized and musl does not provide all tested feature, for one it > > does not provide arguments to the constructors, anymore? > > > > Skip the constructor tests on non-nolibc configurations. > > I'm not much surprised, I've always avoided arguments in my use of > constructors due to a lack of portability. However the patch disables > all constructors tests, while I'm seeing that the linkage_test version > does not make use of arguments, though there is an implied expectation > that they're executed in declaration order, which is not granted. The tests are written specifically to test for execution order. While we can not rely on the order for other libcs, the idea was to expect a given order for the nolibc implementation. > I'm wondering if we shouldn't make the tests more robust: > 1) explicitly set linkage_test_constructor_test_value to zero in the > declaration, because here it's not set so we have no guarantee > (we're not in the kernel) Ack. > 2) only add values to check for cumulated values (e.g. |1 in const1, > |2 in const2) and verify that the result is properly 3 This would stop validating the order. > 3) make the argument test add a distinct value (|4) so that when > testing it's instantly obvious which test was not called. > > And indeed, we can disable the tests we know fail on other libcs and > even split that by feature (e.g. test that at least one constructor > was called using !=0, that all non-arg ones were called via &3 == 3, > and that the args were passed via &4==4). That would allow to further > refine the tests if desired so that we can keep the differences in mind. I'm not yet convinced about the additional value. But I'll give it some thought. > In any case all of this can also be done later, and I'm obviously fine > with this immediate adjustement. > > > Signed-off-by: Thomas Weißschuh <linux@weissschuh.net> > > Acked-by: Willy Tarreau <w@1wt.eu> Thanks! > Willy
diff --git a/tools/testing/selftests/nolibc/nolibc-test.c b/tools/testing/selftests/nolibc/nolibc-test.c index 798fbdcd3ff8c36b514feb3fa1c7b8d7701cccd7..94db506eca906ff0ce8f518298dee34abf386484 100644 --- a/tools/testing/selftests/nolibc/nolibc-test.c +++ b/tools/testing/selftests/nolibc/nolibc-test.c @@ -738,9 +738,9 @@ int run_startup(int min, int max) CASE_TEST(environ_HOME); EXPECT_PTRNZ(1, getenv("HOME")); break; CASE_TEST(auxv_addr); EXPECT_PTRGT(test_auxv != (void *)-1, test_auxv, brk); break; CASE_TEST(auxv_AT_UID); EXPECT_EQ(1, getauxval(AT_UID), getuid()); break; - CASE_TEST(constructor); EXPECT_EQ(1, constructor_test_value, 2); break; + CASE_TEST(constructor); EXPECT_EQ(is_nolibc, constructor_test_value, 2); break; CASE_TEST(linkage_errno); EXPECT_PTREQ(1, linkage_test_errno_addr(), &errno); break; - CASE_TEST(linkage_constr); EXPECT_EQ(1, linkage_test_constructor_test_value, 6); break; + CASE_TEST(linkage_constr); EXPECT_EQ(is_nolibc, linkage_test_constructor_test_value, 6); break; case __LINE__: return ret; /* must be last */ /* note: do not set any defaults so as to permit holes above */
The nolibc testsuite can be run against other libcs to test for interoperability. Some aspects of the constructor execution are not standardized and musl does not provide all tested feature, for one it does not provide arguments to the constructors, anymore? Skip the constructor tests on non-nolibc configurations. Signed-off-by: Thomas Weißschuh <linux@weissschuh.net> --- tools/testing/selftests/nolibc/nolibc-test.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- base-commit: 16681bea9a80080765c98b545ad74c17de2d513c change-id: 20250212-nolibc-test-constructor-42491ba71a19 Best regards,