From patchwork Wed Mar 12 00:21:16 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeff Xu X-Patchwork-Id: 14012784 Received: from mail-ed1-f49.google.com (mail-ed1-f49.google.com [209.85.208.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 78D311CF8B for ; Wed, 12 Mar 2025 00:21:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741738888; cv=none; b=UrrOMjNJ5B7GRsGGOXgeOw/5IDMG3/mPNPKDUC10IA2HAH5nXr0s+iqYhOKVvfMPHFJlSlzp9XL+S1/P5Su2Zc02vUWUzaXqPxdJvLVk+p9IuyE4nB0ciXsUvXyX2fuQLrm0S2kEZjGR5nqEiauRrls8EwPPUlGblpF5tT5uidY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741738888; c=relaxed/simple; bh=E0hajOFy+vpCtuf88R9Ti+b+60Xg+fLnjQmi+V0i0oM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gOi1VHhbXZQUSgvOknRmbVIt1Y4EwpJvsUnNcpwy4VntVoiHBy+lS4H1xrIEl+HHL2D3p81kXjqj/bThWBnYR5yp3Q2q2G0vPH+hTW790jbtNIVhf6wBd5gmL5ROWwt8bCUpRnU7zyEfNlK1HSy1zK0e10DZUHT82Z9AvLIFjpk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=nBVZokNJ; arc=none smtp.client-ip=209.85.208.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="nBVZokNJ" Received: by mail-ed1-f49.google.com with SMTP id 4fb4d7f45d1cf-5dc5a32c313so996941a12.3 for ; Tue, 11 Mar 2025 17:21:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1741738885; x=1742343685; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=miJIXyGYG3FDRWUe/NKY/2IA/SM1dTsr2zjDOOHuDTo=; b=nBVZokNJULTTLGlDeH+QhdefPlbGtadJTYisrscWeZKoqbMbt8ZdBdD+JAPkFjdXF9 oqym5qLf9wyw87OIhlqnNOokF1AZLQZtrujJ3j7KT2q3XXxuUkSooXD0u+vSLh3UhddZ oZAw+q88AZE6Z+CbKZbiWHICyvioBpJjbEwt8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741738885; x=1742343685; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=miJIXyGYG3FDRWUe/NKY/2IA/SM1dTsr2zjDOOHuDTo=; b=FAM1VXae8vDcl+xpktf7gltk2wO44jiWqlR3PTCrQIKtSG8FLUDSOYeSYUPaso9OU+ IV8g4HWQESvUqbapiVqi4IB6miiW+b7oNSGPbWHfWBcQEp6ef2bDBr7mQ5ifIJPz0UJe wSQTnMje55v/2Xgbn1sSQhEZteNb0jFpiQEz53r96nE93RgH/xqukd74B8ZnZzcxXIjP jIcGFkmXeiZ4G4kX3KT/8SikDZxBlTBNgBcoCbuuv3Ks7ok22ffhyMIK6LjY2+gY6OQO GXqKEnlMz9WzjT+NpWhz/FuioJ5G7iM+G+mvsudwyNHEkDHH/JQhIGhpwGnNHrQCC6UR mlmA== X-Forwarded-Encrypted: i=1; AJvYcCWs8+wAwoLY2t6aj4qn0wb50bRInptf7j1M3mNdh6QOqVzYXOaljTkOa+2awQ9g3m270uDz7d+1DqJBCTVdQMM=@vger.kernel.org X-Gm-Message-State: AOJu0YxnJC/3SoXINBB0nPfpnh7jN8Ho7HphLB4juhJc8bXqznrkfi33 IDwNEOChdVP75ClGuJPUG0Pic+qJ9PPCleA0/BMvJSxaQyxTAn+Ny1LJj/SPhg== X-Gm-Gg: ASbGncsaaZSP8EZbkqz5Ap3oXVjSZr0tEFPcHLcuW3TKDhaHMF5eGK0UcbvslCQfOSJ SlrBBEGzbDa0Q9nhdM4Nf17NhOq1eWGsmdBzHULLFPdJXdA1ASSJNr7rv8qmOvNdjskZ0ZfNGhb 98IK05Hx5Z8i9qiBXDQ1bfebhSQAX9jK+VNFGAR2d8bUNk70ey3OanEIuwRUr0p3ITy5ZMtdzgh 2Aw47WPLzxAlBh7ZR7VTElAEJlQjUqNYab1Cv/Z33/g3IJ5DFRVJeStWRElV/+Nw6xanzx8u2ns vTQoObqiXZEIWBDacnFb1giGLSzKqnb3J5BJmbiTlIk3Y1PUaTm7xmX0nNoI4qvVLsnu1OFdlrz O X-Google-Smtp-Source: AGHT+IG2RY8KyPk79cZ65JQw4p98XAf1wvRrztHIEplkXwrKzzh8fZlWbd9JzkmEqA3hVmaYTTf1Tg== X-Received: by 2002:a05:6402:35c6:b0:5e5:e17f:22fc with SMTP id 4fb4d7f45d1cf-5e617f919d5mr7379042a12.2.1741738884777; Tue, 11 Mar 2025 17:21:24 -0700 (PDT) Received: from cfish.c.googlers.com.com (40.162.204.35.bc.googleusercontent.com. [35.204.162.40]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5e5c7669fd0sm8846503a12.51.2025.03.11.17.21.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Mar 2025 17:21:23 -0700 (PDT) From: jeffxu@chromium.org To: akpm@linux-foundation.org, vbabka@suse.cz, lorenzo.stoakes@oracle.com, Liam.Howlett@Oracle.com, broonie@kernel.org, skhan@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, jorgelo@chromium.org, keescook@chromium.org, pedro.falcato@gmail.com, rdunlap@infradead.org, jannh@google.com, Jeff Xu Subject: [RFC PATCH v1 1/2] selftests/mm: mseal_test: avoid using no-op mprotect Date: Wed, 12 Mar 2025 00:21:16 +0000 Message-ID: <20250312002117.2556240-2-jeffxu@google.com> X-Mailer: git-send-email 2.49.0.rc0.332.g42c0ae87b1-goog In-Reply-To: <20250312002117.2556240-1-jeffxu@google.com> References: <20250312002117.2556240-1-jeffxu@google.com> Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Jeff Xu Modify mseal_tests to avoid using no-op mprotect. The no-op mprotect shall be allowed. Signed-off-by: Jeff Xu Fixes: 4a2dd02b0916 ("mm/mprotect: replace can_modify_mm with can_modify_vma") --- tools/testing/selftests/mm/mseal_test.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/testing/selftests/mm/mseal_test.c b/tools/testing/selftests/mm/mseal_test.c index ad17005521a8..0d4e5d8aeefb 100644 --- a/tools/testing/selftests/mm/mseal_test.c +++ b/tools/testing/selftests/mm/mseal_test.c @@ -677,7 +677,7 @@ static void test_seal_mprotect_two_vma(bool seal) FAIL_TEST_IF_FALSE(!ret); } - ret = sys_mprotect(ptr, page_size * 2, PROT_READ | PROT_WRITE); + ret = sys_mprotect(ptr, page_size * 2, PROT_READ); if (seal) FAIL_TEST_IF_FALSE(ret < 0); else @@ -718,7 +718,7 @@ static void test_seal_mprotect_two_vma_with_split(bool seal) FAIL_TEST_IF_FALSE(!ret); /* the second page is sealed. */ - ret = sys_mprotect(ptr + page_size, page_size, PROT_READ | PROT_WRITE); + ret = sys_mprotect(ptr + page_size, page_size, PROT_READ); if (seal) FAIL_TEST_IF_FALSE(ret < 0); else @@ -873,7 +873,7 @@ static void test_seal_mprotect_split(bool seal) FAIL_TEST_IF_FALSE(!ret); - ret = sys_mprotect(ptr + 2 * page_size, 2 * page_size, PROT_READ); + ret = sys_mprotect(ptr + 2 * page_size, 2 * page_size, PROT_WRITE); if (seal) FAIL_TEST_IF_FALSE(ret < 0); else