From patchwork Tue Mar 18 00:27:10 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: "Chia-Yu Chang (Nokia)" X-Patchwork-Id: 14020087 Received: from AS8PR03CU001.outbound.protection.outlook.com (mail-westeuropeazon11012009.outbound.protection.outlook.com [52.101.71.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D2FDC17A319; Tue, 18 Mar 2025 00:28:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.71.9 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742257690; cv=fail; b=G43yijSi/pWTe2e8nUZ6TWEv/Nz67uFU0q7yoCigsX3dNY+60JGQxpLW/SW5Ls+LnBl/kRYlGceaodbm3a3JPXz8GC/Q7vuHl6iIz4Kg6H7w9rn8TzSqinRyLsYxm+gVd0SRYcqRjfDXNEb5yVsI+y9rqeaDHOkMh/hx7WSsWaE= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742257690; c=relaxed/simple; bh=TmPK1Vyp2bFVJubcSXhUlXk5Wuf8M2fpIB8ZL5UOptg=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-Type; b=iFS87xzoc67tpWJwXvX34NhHjsd4zF1DFZQMfkxsKOa//xCctkK00gPSLbnJyKgX5+AlumzYG74rg8zMPnBUpJArroIBFKtFvJvBiAQKAe8RK70MVF511+KErBPDZSdKfbdZir+0Nant7n6A//f21Lulyr9awgrWGH0BA3CdiVM= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nokia-bell-labs.com; spf=fail smtp.mailfrom=nokia-bell-labs.com; dkim=pass (2048-bit key) header.d=nokia-bell-labs.com header.i=@nokia-bell-labs.com header.b=V63bKlJr; arc=fail smtp.client-ip=52.101.71.9 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nokia-bell-labs.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nokia-bell-labs.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nokia-bell-labs.com header.i=@nokia-bell-labs.com header.b="V63bKlJr" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=FPYA8vBLc4B1P1BzwycawK848R01ZQ7pn5k3cIxTuB1m9fQVTL16ndcJ3lvDUZAWqaDX1supoCzqkpriojWLOHQRTIz1z0QX3MeuqOCbEO3pV0g4DToM1O9v8ri4FZov3xFLcT0Iglk9ISnjedhOy/Wwu0xCxvFWQ30hNoU1zdu28bwtOESvgUvzJasSg5YAk2Nvz44570NEl1biMAQV+PYSr+Dw19/gqmy7mebMYMg5zpEvSmJLdwVsBPYiZ5rD68PdK+HIi5j1SAyTukMc8WjItYZJWNPG2QLCZDqrnf2PD0++BavwzRG8ZmSLS0ez24aBkRD218fXFujXLBNdOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=y/4w8JPc5QkyDdKZ1GwKpR0KH4xz9bMjj6Dj9IGETB4=; b=sBmufZU4eM6stMrO/pHiuJiWzuAfk1FqPht6ryV6HqTQrFEWYF8S+AB4k7mS8OpouIRtUTVt8/PhSkn0LCCPty26GChOFfB2nWohzS64MZ19VcKqz2VH7SrhnOCfDvxIWU80ZIBFDJXjbwAYKmVO2MP3jmNOC+XjzMCgwyaEw4TiTvVAzbsDC5BoXrrlrYwqUOmHwL5ZOUFjaUkHs6p2daqNRIo494fRmVw8aCEp6iMVE69B5gim5IAjnjio2cfr3U5msDtrdTU7Lz+aN3DJT+AKw5e1lJ1TlIjh7nZHIWO/kwvwM4F4ot1aZjZXcZvyHyZ99IsE19SWFJFb/xAEHg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 131.228.6.100) smtp.rcpttodomain=nokia-bell-labs.com smtp.mailfrom=nokia-bell-labs.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nokia-bell-labs.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nokia-bell-labs.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=y/4w8JPc5QkyDdKZ1GwKpR0KH4xz9bMjj6Dj9IGETB4=; b=V63bKlJr6mE1P8z2DP7F4qgW0Bqd2eWEC+b1i8qZ6FOJWD8U96DFP6Mfoo/o4s7pnYj5mN4pTE+Lc4hb2PtCvemRwPFynrzHl4yc71YqdrqivOZSHxkfBmAlaPluE/Dwm1tEPe3vM2V/g+xQa1GhO0f7GRVK2RcqFDDqbJH+r8OR9ofzi2HquC2YBwTAnD0wl1U391umOhPO5zQQVd/Akp5GPDKw1KkptC6JtSTKwrHppX9U65hwyn9PP1yBEb2l8sZ6jI0n5wpSrhZktUgtsUGGW2CbsPI4F43Z/ziHWM2PeBiLbpx8OZ1RF/qyX3AXVmaX6PXS0+IqJcRpue6tLA== Received: from AM0PR07CA0025.eurprd07.prod.outlook.com (2603:10a6:208:ac::38) by DU2PR07MB8109.eurprd07.prod.outlook.com (2603:10a6:10:238::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8534.33; Tue, 18 Mar 2025 00:28:05 +0000 Received: from AMS0EPF00000192.eurprd05.prod.outlook.com (2603:10a6:208:ac:cafe::9f) by AM0PR07CA0025.outlook.office365.com (2603:10a6:208:ac::38) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8534.33 via Frontend Transport; Tue, 18 Mar 2025 00:28:05 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 131.228.6.100) smtp.mailfrom=nokia-bell-labs.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nokia-bell-labs.com; Received-SPF: Pass (protection.outlook.com: domain of nokia-bell-labs.com designates 131.228.6.100 as permitted sender) receiver=protection.outlook.com; client-ip=131.228.6.100; helo=fr711usmtp2.zeu.alcatel-lucent.com; pr=C Received: from fr711usmtp2.zeu.alcatel-lucent.com (131.228.6.100) by AMS0EPF00000192.mail.protection.outlook.com (10.167.16.218) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8534.20 via Frontend Transport; Tue, 18 Mar 2025 00:28:05 +0000 Received: from sarah.nbl.nsn-rdnet.net (sarah.nbl.nsn-rdnet.net [10.0.73.150]) by fr711usmtp2.zeu.alcatel-lucent.com (GMO) with ESMTP id 52I0RNBv024935; Tue, 18 Mar 2025 00:28:12 GMT From: chia-yu.chang@nokia-bell-labs.com To: netdev@vger.kernel.org, dave.taht@gmail.com, pabeni@redhat.com, jhs@mojatatu.com, kuba@kernel.org, stephen@networkplumber.org, xiyou.wangcong@gmail.com, jiri@resnulli.us, davem@davemloft.net, edumazet@google.com, horms@kernel.org, andrew+netdev@lunn.ch, donald.hunter@gmail.com, ast@fiberby.net, liuhangbin@gmail.com, shuah@kernel.org, linux-kselftest@vger.kernel.org, ij@kernel.org, ncardwell@google.com, koen.de_schepper@nokia-bell-labs.com, g.white@cablelabs.com, ingemar.s.johansson@ericsson.com, mirja.kuehlewind@ericsson.com, cheshire@apple.com, rs.ietf@gmx.at, Jason_Livingood@comcast.com, vidhi_goel@apple.com Cc: Chia-Yu Chang Subject: [PATCH v2 net-next 15/15] gro: flushing when CWR is set negatively affects AccECN Date: Tue, 18 Mar 2025 01:27:10 +0100 Message-Id: <20250318002710.29483-16-chia-yu.chang@nokia-bell-labs.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250318002710.29483-1-chia-yu.chang@nokia-bell-labs.com> References: <20250318002710.29483-1-chia-yu.chang@nokia-bell-labs.com> Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AMS0EPF00000192:EE_|DU2PR07MB8109:EE_ X-MS-Office365-Filtering-Correlation-Id: d8c37557-8b60-4df5-8890-08dd65b3c018 X-LD-Processed: 5d471751-9675-428d-917b-70f44f9630b0,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|1800799024|36860700013|7416014|376014|921020; X-Microsoft-Antispam-Message-Info: =?utf-8?q?ZUSEgto126YzxiWlBgDrod+N5wS0oZ3?= =?utf-8?q?gjq8dJZrrp5upRnl7HNcGzcU+kPBlkb97ZaUlmb/+jPXzzmgBtDVFnoDVhd5dArVA?= =?utf-8?q?YPxivRtg0sV6ZweevyhHBwmO8HQW+Cy5NFcO6vz5/stib/ZG55+uhMsnnRd+qc3qb?= =?utf-8?q?c2qPR3duZRIf/bhLNdll0XxIzz+8xDB3UUP2Ud+BK0ibahWWYmMCFpaKypzJUeu2H?= =?utf-8?q?9WiVQUphWqoEhaPjNblJSpNzGu9b/Og8TgFY/QLBWshFYBWOGBUCALLYaBx1slw2N?= =?utf-8?q?zbV71x11Jon9pfA5Sm/r8KlRWQAPPzI7yME+HOmptDPdljC5p8R78PrkhULYk+wMG?= =?utf-8?q?Glgr3ykx1L6gX60jnyikjzEVP1QZZZR5aCVt/cN+4kpb2z/oGJkz9jRHN5CoUPCSB?= =?utf-8?q?Ezz2JnwB8lGdR64Ho+MrEDM4Fycs4jWv62ta1Iz5igyW6DT5UFru58D4MpeIqxfs5?= =?utf-8?q?imEfn8RKsMZm41sqJ+BALpT1dZZlRYk6adtRQyx9zmw3mR+sQubJIXAngUmyBbg1I?= =?utf-8?q?S3ivMlzARTgcAREaBD+KlTAy75GoAFIV92G/g21kf7jLM8zWCMTclFC/YJzE9IhPN?= =?utf-8?q?64/h0xmAYQGRb8CnQTd6pUXNpt2FRKqVfWm23+Wt5jZQFAUTR91f/acU6QQzVa5ck?= =?utf-8?q?p2qeWIVXhrDA6deuSLwxdSKtOYKgWu3kPOGs3gdilpsdfZTadEAntB/8TS5zSGWxs?= =?utf-8?q?UvGQJrIIhpggSfx/XQaeQgp7rtUSb+M3BYh3Z7ZGgUTA4ML3Sj5tbHYijyJqVtTk7?= =?utf-8?q?jeu4Ifrx8aVQJsbzrHF1AByk9bH35pIKmnB7iU4ehjIUoCUB4GSBL/TUCOlwYdqu8?= =?utf-8?q?TnoF2c7B/who1zahhtFmQcjs9vTQr16n8ZXx2Y/b0qNnis/kgFX5d2LhUMX9GnlMy?= =?utf-8?q?GZj3MzoY+WWcMBROGk3ikHFt5c0ROOwebYFy23WH0nQo4vJcPM/+9raH260TM91UF?= =?utf-8?q?hIIpZQj2RXm1DAr4AYycCqhenTRehOC9bQ1CjVPOfh4Y4k/GoFD+hmhc9b8+r1WFK?= =?utf-8?q?/k+qG93hWEozsYwmuTWXuRT6I+wJO2zdnzpwodCNX3kx9yG/VJMbjwV3LAIyfTlGL?= =?utf-8?q?w9V8lTR10Y+A1hmLPS8AdNhnuMToV2GSQMk8FOAL5bJWhzTC41BEB5iNdka35Dn5v?= =?utf-8?q?9baAKXqMDHbgc+3nQwyzKEnqrvTDEXCeup4aBodKdmV3mvr1I34po8lP/lyNefkm5?= =?utf-8?q?hZcoUKpXaPbnWUPU2RedZl3mUZLXZOQObgL0pBmLJ+2M5Tm1913OcknOlOS7IMRIA?= =?utf-8?q?yfPuBF2+d7yj0knu6O0QXAMHdDJjs/ZfDQiRBb4MvIPZ8QXlufocu41BfQN83aOpt?= =?utf-8?q?LpmOSceWFIMqoOu7aPzQpniubou/FLo2ltTD6c+cJob00vVfGyIsRe4V5VGciR6f7?= =?utf-8?q?e8h0dw+P4QBYVVu2OC+CIqQfOmh8tZlIVk3V4+AF8J61Qt7kMYD36U+0r5cew/AHd?= =?utf-8?q?wmYL7Z4/Rn?= X-Forefront-Antispam-Report: CIP:131.228.6.100;CTRY:FI;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:fr711usmtp2.zeu.alcatel-lucent.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(1800799024)(36860700013)(7416014)(376014)(921020);DIR:OUT;SFP:1101; X-OriginatorOrg: nokia-bell-labs.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Mar 2025 00:28:05.2238 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d8c37557-8b60-4df5-8890-08dd65b3c018 X-MS-Exchange-CrossTenant-Id: 5d471751-9675-428d-917b-70f44f9630b0 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5d471751-9675-428d-917b-70f44f9630b0;Ip=[131.228.6.100];Helo=[fr711usmtp2.zeu.alcatel-lucent.com] X-MS-Exchange-CrossTenant-AuthSource: AMS0EPF00000192.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR07MB8109 From: Ilpo Järvinen As AccECN may keep CWR bit asserted due to different interpretation of the bit, flushing with GRO because of CWR may effectively disable GRO until AccECN counter field changes such that CWR-bit becomes 0. There is no harm done from not immediately forwarding the CWR'ed segment with RFC3168 ECN. Signed-off-by: Ilpo Järvinen Signed-off-by: Chia-Yu Chang --- net/ipv4/tcp_offload.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/ipv4/tcp_offload.c b/net/ipv4/tcp_offload.c index 934f777f29d3..fd2fd70f650c 100644 --- a/net/ipv4/tcp_offload.c +++ b/net/ipv4/tcp_offload.c @@ -330,8 +330,7 @@ struct sk_buff *tcp_gro_receive(struct list_head *head, struct sk_buff *skb, goto out_check_final; th2 = tcp_hdr(p); - flush = (__force int)(flags & TCP_FLAG_CWR); - flush |= (__force int)((flags ^ tcp_flag_word(th2)) & + flush = (__force int)((flags ^ tcp_flag_word(th2)) & ~(TCP_FLAG_FIN | TCP_FLAG_PSH)); flush |= (__force int)(th->ack_seq ^ th2->ack_seq); for (i = sizeof(*th); i < thlen; i += 4)