| Message ID | 20250320020740.1631171-9-contact@antoniohickey.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | None | expand |
On Thu Mar 20, 2025 at 3:07 AM CET, Antonio Hickey wrote: > Replacing all occurrences of `addr_of!(place)` with > `&raw const place`. Again. > This will allow us to reduce macro complexity, and improve consistency > with existing reference syntax as `&raw const` is similar to `&` making > it fit more naturally with other existing code. > > Suggested-by: Benno Lossin <benno.lossin@proton.me> > Link: https://github.com/Rust-for-Linux/linux/issues/1148 > Signed-off-by: Antonio Hickey <contact@antoniohickey.com> Reviewed-by: Benno Lossin <benno.lossin@proton.me> --- Cheers, Benno > --- > rust/kernel/kunit.rs | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-)
On Thu, Mar 20, 2025 at 3:08 AM Antonio Hickey <contact@antoniohickey.com> wrote: > > Replacing all occurrences of `addr_of!(place)` with > `&raw const place`. > > This will allow us to reduce macro complexity, and improve consistency > with existing reference syntax as `&raw const` is similar to `&` making > it fit more naturally with other existing code. > > Suggested-by: Benno Lossin <benno.lossin@proton.me> > Link: https://github.com/Rust-for-Linux/linux/issues/1148 > Signed-off-by: Antonio Hickey <contact@antoniohickey.com> In general, you should pick the previous tags (e.g. Reviewed-by) that you were given for each patch (unless you think there are enough changes that it should not be done anymore etc.). For instance, in v4, this one was Reviewed-by: David, and a couple others were Reviewed-by Boqun; and from what I can tell, they didn't change. Thanks! Cheers, Miguel
diff --git a/rust/kernel/kunit.rs b/rust/kernel/kunit.rs index 824da0e9738a..a17ef3b2e860 100644 --- a/rust/kernel/kunit.rs +++ b/rust/kernel/kunit.rs @@ -128,9 +128,9 @@ unsafe impl Sync for UnaryAssert {} unsafe { $crate::bindings::__kunit_do_failed_assertion( kunit_test, - core::ptr::addr_of!(LOCATION.0), + &raw const LOCATION.0, $crate::bindings::kunit_assert_type_KUNIT_ASSERTION, - core::ptr::addr_of!(ASSERTION.0.assert), + &raw const ASSERTION.0.assert, Some($crate::bindings::kunit_unary_assert_format), core::ptr::null(), );
Replacing all occurrences of `addr_of!(place)` with `&raw const place`. This will allow us to reduce macro complexity, and improve consistency with existing reference syntax as `&raw const` is similar to `&` making it fit more naturally with other existing code. Suggested-by: Benno Lossin <benno.lossin@proton.me> Link: https://github.com/Rust-for-Linux/linux/issues/1148 Signed-off-by: Antonio Hickey <contact@antoniohickey.com> --- rust/kernel/kunit.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)