From patchwork Thu Mar 20 20:03:01 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Stultz X-Patchwork-Id: 14024520 Received: from mail-pl1-f202.google.com (mail-pl1-f202.google.com [209.85.214.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C0514229B26 for ; Thu, 20 Mar 2025 20:03:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.202 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742500994; cv=none; b=VLKTvb8/uINFDlJYtA7Zzi/wz895ZiIdpl+hTVebJrI3j8eDFhWmktkxERpw2yBDFtmuJ1Ago2w9yhgTzYgBzH123wHG3SNa0tFkXsoRG7ugY4btm3bZYKMog6iAmEEMGDHfA6CL+5yNoczwfkB02RipHbUOgIxFl/PDnVgkUtk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742500994; c=relaxed/simple; bh=tTxylqVTcwCy2pyXn0rUGN38RFfZhUBOEvnkcrpCNSE=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=KhV2NnZ+VC41BhZsRkJaubajPymFRfHo1aWyqD0xmEKatoyE0hqmvnOOtbrKNYCViQlAc6Zyw6rbgGvcX9KBjWCJH2fMXNCMud/Hj4k/BImrWE52SfDRNS/Ax+1gb4OEzLeADqv4z5BMCjNwjtRdCOuENZY2WNiwxZBPAuD2PS0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--jstultz.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=QJym8Us/; arc=none smtp.client-ip=209.85.214.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--jstultz.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="QJym8Us/" Received: by mail-pl1-f202.google.com with SMTP id d9443c01a7336-2265a09dbfcso30183135ad.0 for ; Thu, 20 Mar 2025 13:03:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1742500992; x=1743105792; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=15shGMlHMpFSN9hvjBCgOAgN8Cwgr8g8LYNCb4v7WJc=; b=QJym8Us/psSO6Ry0VcqWaSpoOdLvIjn/sX6wQnKhA1toqBBwIoJQGLDTWPaHXZHTT7 us9fwzw3ENZi4A7CMYheYBKi2hogXXmvoILhnto9QQHa7KxFWvOYX3O3vdQreRYLDd5p t0JAJy7SkFgb2f84c2TcC0dRyftQhVJVXthz9LVyK79DuB6dzLXz5xH3R7eC18FvKTjx Fi3fCkuuN5SkEH6/HP4UQ+JVffJHmC+Sx9gXIEOJrH0Gi4xuj19YC7OjumE9DBBf4zWM ARrl3YomWVsk6N8pay+iooLnKWkzg+I+TfyMyqXAT2LfCG9So4GilgmKP/PK1i2dik5A PoOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742500992; x=1743105792; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=15shGMlHMpFSN9hvjBCgOAgN8Cwgr8g8LYNCb4v7WJc=; b=MK8DghM3ZJfQBjMv14akLLQNUCenuQecmbZBuIbb6oR7Z+gQJwuCtVU7WB3C32fPXU secQIvUeY5Ir+4QUh1OWzRxV4lkO0LREmdXeE1CNbI765ua3jdAT7XcI9Ep5vSP9EHOO 4r4LeZbzZoCoiMB27qbq1ZvFUPHpP/ung3Q6TeuGDI7kzXBwEkpCT+h2OFzdZswyIV7d IDSDWAACOiuhiP24qieub/kqBEsSMPKPaIlV/J4ZkkDzGZEIIlnxFtTiz2fUixzB6Ste OWzno5nSd+JuBQWhe58k0wePmM/h6dDyBxoTNEHE0dopwk0KHKZz53T+KzFhAcajKoKA 6u4Q== X-Forwarded-Encrypted: i=1; AJvYcCVY/4Be4WWg8vMsBFn2dQFlWgLFnQ6yF/0BLyQhEPQmH2ebPGSG/JRdsKPYoSP3pvEt8KGrlwFjmwKQsklVsSU=@vger.kernel.org X-Gm-Message-State: AOJu0Yyxmuu6mD8sCA0EDjeEXfCEys2s5vglIa6ceeCszUyqKmMHRWD7 STJiWpEfts7bCpq7NgM9L8TeSSQwHsBwLGlW8PuPf+IvHIoZilX6bj22xq/hLYNAbhjEVuidFjP h1Wq7 X-Google-Smtp-Source: AGHT+IH14RrilTASqypK+L82ZC1gr9MGNXnC+OCPQR6Zx/BHge9JdQ1cImsPAWCfCv3LOIo/9qHlPHTOjAgx X-Received: from plfh3.prod.google.com ([2002:a17:902:f543:b0:220:e7dc:350d]) (user=jstultz job=prod-delivery.src-stubby-dispatcher) by 2002:a17:902:f64a:b0:223:28a8:6101 with SMTP id d9443c01a7336-22780d96e57mr11843895ad.29.1742500992126; Thu, 20 Mar 2025 13:03:12 -0700 (PDT) Date: Thu, 20 Mar 2025 13:03:01 -0700 In-Reply-To: <20250320200306.1712599-1-jstultz@google.com> Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250320200306.1712599-1-jstultz@google.com> X-Mailer: git-send-email 2.49.0.395.g12beb8f557-goog Message-ID: <20250320200306.1712599-2-jstultz@google.com> Subject: [PATCH v2 2/2] selftests/timers: Improve skew_consistency by testing with other clockids From: John Stultz To: LKML Cc: John Stultz , Thomas Gleixner , Stephen Boyd , Anna-Maria Behnsen , Frederic Weisbecker , Shuah Khan , Miroslav Lichvar , linux-kselftest@vger.kernel.org, kernel-team@android.com, Lei Chen Lei Chen reported a bug with CLOCK_MONOTONIC_COARSE having inconsistencies when NTP is adjusting the clock frequency. This has gone seemingly undetected for ~15 years, illustrating a clear gap in our testing. The skew_consistency test is intended to catch this sort of problem, but was focused on only evaluating CLOCK_MONOTONIC, and thus missed the problem on CLOCK_MONOTONIC_COARSE. So adjust the test to run with all clockids for 60 seconds each instead of 10 minutes with just CLOCK_MONOTONIC. Cc: Thomas Gleixner Cc: Stephen Boyd Cc: Anna-Maria Behnsen Cc: Frederic Weisbecker Cc: Shuah Khan Cc: Miroslav Lichvar Cc: linux-kselftest@vger.kernel.org Cc: kernel-team@android.com Cc: Lei Chen Reported-by: Lei Chen Closes: https://lore.kernel.org/lkml/20250310030004.3705801-1-lei.chen@smartx.com/ Signed-off-by: John Stultz --- tools/testing/selftests/timers/skew_consistency.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/timers/skew_consistency.c b/tools/testing/selftests/timers/skew_consistency.c index 83450145fe657..46c391d7f45dc 100644 --- a/tools/testing/selftests/timers/skew_consistency.c +++ b/tools/testing/selftests/timers/skew_consistency.c @@ -47,7 +47,7 @@ int main(int argc, char **argv) pid = fork(); if (!pid) - return system("./inconsistency-check -c 1 -t 600"); + return system("./inconsistency-check -t 60"); ppm = 500; ret = 0;