From patchwork Mon Apr 14 21:47:46 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sagi Shahar X-Patchwork-Id: 14051049 Received: from mail-pf1-f201.google.com (mail-pf1-f201.google.com [209.85.210.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 22B0421D3C7 for ; Mon, 14 Apr 2025 21:49:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744667346; cv=none; b=Q8myyfIRdFy9hrOLEEHsw+7sIXjmAXPik5pWKFRYd+WlA+dCxFYjgB6qTJCBdpvcZvloNAM3CRVCW6R05ezfo7PvmKlFrOeygjDOyUbWuffF9YjB04w4HXckFTNpb+duKDEjPxR310lKS4DBRb4B94U4XOzfCtOWBjHOLY+ccKc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744667346; c=relaxed/simple; bh=/n1foAlpk+etzTBM2D1hxEcnm/8ah9s9ZBI7R5m2ATQ=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=B2rRSo/EhXtDqsag8g+H4jDKnfHEAKlw9bWvM1SZ9YcUHOM0eaVaUceb8f4Ql6glyJRw06i8QtEAPLes7zHHJfXPq7EdqaCVy3R94dpNqUbVkMxg0E17yxUN2fcj/ibfEuN5mshaw2nSA8zIXX5eSQhy/RYdHSfoJM+gBsbbFh0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--sagis.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=kned6Wyf; arc=none smtp.client-ip=209.85.210.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--sagis.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="kned6Wyf" Received: by mail-pf1-f201.google.com with SMTP id d2e1a72fcca58-736c7d0d35aso6015361b3a.1 for ; Mon, 14 Apr 2025 14:49:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1744667344; x=1745272144; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=ojSFGVutva/8voVAMgW6hqOpSnmRctEgikC/JBWm1uk=; b=kned6Wyfu4JLibjaOouI9v7/iL79tkEhpanOsFQgW38k5QRWyBs+dWP6Q4eiEykJW0 Ncz3LFIz+6gU9mxRW31IRWo6015wm2X/3HT4dbLMyjBM15UDJn5grsqoAYifEj5lBjC4 4XCliHQC3tzK6Gb7yvkELOj+m74vs2rQo+O5dw37C4jhvCYh9piEaNmMYtoMIG+njSHz 6kzb0tar8Whgf3RM4XLkeosyV1Lxca9vab+LaS4ssu/vEIoh8tnJg3oLBkmi5C/X8sCJ 8TCp78vpkE5cv+XMRTFTKjtJwTpthrt3vnLDlmGIMvFwg8UvsQgGK61NbfIPqs4B5guN Dh8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744667344; x=1745272144; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ojSFGVutva/8voVAMgW6hqOpSnmRctEgikC/JBWm1uk=; b=sFvXDspLVE36e5cpjhVpXIEUe+5ea3/uAo9kCyuHWLfxeKShgdY0lhp7AjQuA0Wta/ JV664ZvgheFiT27f+Xx5+5jNCnqDkwfzxWPIC7UxPhRPUD2WmKd8fJV6Vg73lTwoRSiZ l6JB3O8iievS3lCbD7LsWGPIBBRhzxvE81iX8t9r1lU1Izk8QOxWwcPU0UJ8rHv9kdyz 1yfXqUlCji3JNl3spbXOJJtwT9ggNna8KZKZlRB6PCbEAPvBPfkR24frntU7StGK3/oX IK1c518u52vvPZjJs3QgFWmhMxeUpW6W04oMIcLsW1MwwlqMXY7EbCgLwQI6LkvYohHy bsaQ== X-Gm-Message-State: AOJu0YyDkcsiLU5aaRfFdJu+KRjbq+ieh0WnhUKUVnyP942o7/DobBRr utuZUFLvToFzSAZ4aU3Dgycp9oz/weG5HqATM3el538aPLGEq1L6FvXksJ879UXEzMFBVNrSS5n ccwAARbzR+TpQgVNGNmnREqrEiwLUj/mxfNjLHVud1i/4P2rMUA+jhVvh0iCeTVN5uRntgOuDK4 +i/iCRzFXKOc1+5wKCyN7ZTdOoePyT6V84qxFe6Y4= X-Google-Smtp-Source: AGHT+IGmeeImAshDYCR0XYzQjIanYW8HtrwP2QGwHu3yLtyGhKR1MZsn7HPM9WTulJ6ihGpNExB0SL21VA== X-Received: from pfhs21.prod.google.com ([2002:a62:e715:0:b0:730:96d1:c213]) (user=sagis job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:2185:b0:736:3e50:bfec with SMTP id d2e1a72fcca58-73bd11bde77mr22359994b3a.8.1744667344246; Mon, 14 Apr 2025 14:49:04 -0700 (PDT) Date: Mon, 14 Apr 2025 14:47:46 -0700 In-Reply-To: <20250414214801.2693294-1-sagis@google.com> Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250414214801.2693294-1-sagis@google.com> X-Mailer: git-send-email 2.49.0.777.g153de2bbd5-goog Message-ID: <20250414214801.2693294-18-sagis@google.com> Subject: [PATCH v6 17/30] KVM: selftests: TDX: Add TDX HLT exit test From: Sagi Shahar To: linux-kselftest@vger.kernel.org, Paolo Bonzini , Shuah Khan , Sean Christopherson , Ackerley Tng , Ryan Afranji , Andrew Jones , Isaku Yamahata , Erdem Aktas , Rick Edgecombe , Sagi Shahar , Roger Wang , Binbin Wu , Oliver Upton , "Pratik R. Sampat" , Reinette Chatre Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org From: Erdem Aktas The test verifies that the guest runs TDVMCALL and the guest vCPU enters to the halted state. Co-developed-by: Sagi Shahar Signed-off-by: Sagi Shahar Signed-off-by: Erdem Aktas Signed-off-by: Sagi Shahar --- .../selftests/kvm/include/x86/tdx/tdx.h | 2 + tools/testing/selftests/kvm/lib/x86/tdx/tdx.c | 10 +++ tools/testing/selftests/kvm/x86/tdx_vm_test.c | 81 ++++++++++++++++++- 3 files changed, 92 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/kvm/include/x86/tdx/tdx.h b/tools/testing/selftests/kvm/include/x86/tdx/tdx.h index 56359a8c4c19..b5831919a215 100644 --- a/tools/testing/selftests/kvm/include/x86/tdx/tdx.h +++ b/tools/testing/selftests/kvm/include/x86/tdx/tdx.h @@ -9,6 +9,7 @@ #define TDG_VP_VMCALL_GET_TD_VM_CALL_INFO 0x10000 #define TDG_VP_VMCALL_REPORT_FATAL_ERROR 0x10003 +#define TDG_VP_VMCALL_INSTRUCTION_HLT 12 #define TDG_VP_VMCALL_INSTRUCTION_IO 30 #define TDG_VP_VMCALL_INSTRUCTION_RDMSR 31 #define TDG_VP_VMCALL_INSTRUCTION_WRMSR 32 @@ -20,4 +21,5 @@ uint64_t tdg_vp_vmcall_get_td_vmcall_info(uint64_t *r11, uint64_t *r12, uint64_t *r13, uint64_t *r14); uint64_t tdg_vp_vmcall_instruction_rdmsr(uint64_t index, uint64_t *ret_value); uint64_t tdg_vp_vmcall_instruction_wrmsr(uint64_t index, uint64_t value); +uint64_t tdg_vp_vmcall_instruction_hlt(uint64_t interrupt_blocked_flag); #endif // SELFTEST_TDX_TDX_H diff --git a/tools/testing/selftests/kvm/lib/x86/tdx/tdx.c b/tools/testing/selftests/kvm/lib/x86/tdx/tdx.c index 99ec45a5a657..e89ca727286e 100644 --- a/tools/testing/selftests/kvm/lib/x86/tdx/tdx.c +++ b/tools/testing/selftests/kvm/lib/x86/tdx/tdx.c @@ -93,3 +93,13 @@ uint64_t tdg_vp_vmcall_instruction_wrmsr(uint64_t index, uint64_t value) return __tdx_hypercall(&args, 0); } + +uint64_t tdg_vp_vmcall_instruction_hlt(uint64_t interrupt_blocked_flag) +{ + struct tdx_hypercall_args args = { + .r11 = TDG_VP_VMCALL_INSTRUCTION_HLT, + .r12 = interrupt_blocked_flag, + }; + + return __tdx_hypercall(&args, 0); +} diff --git a/tools/testing/selftests/kvm/x86/tdx_vm_test.c b/tools/testing/selftests/kvm/x86/tdx_vm_test.c index 079ac266a44e..720ef5e87071 100644 --- a/tools/testing/selftests/kvm/x86/tdx_vm_test.c +++ b/tools/testing/selftests/kvm/x86/tdx_vm_test.c @@ -642,6 +642,83 @@ void verify_guest_msr_writes(void) printf("\t ... PASSED\n"); } +/* + * Verifies HLT functionality. + */ +void guest_hlt(void) +{ + uint64_t interrupt_blocked_flag; + uint64_t ret; + + interrupt_blocked_flag = 0; + ret = tdg_vp_vmcall_instruction_hlt(interrupt_blocked_flag); + tdx_assert_error(ret); + + tdx_test_success(); +} + +void _verify_guest_hlt(int signum); + +void wake_me(int interval) +{ + struct sigaction action; + + action.sa_handler = _verify_guest_hlt; + sigemptyset(&action.sa_mask); + action.sa_flags = 0; + + TEST_ASSERT(sigaction(SIGALRM, &action, NULL) == 0, + "Could not set the alarm handler!"); + + alarm(interval); +} + +void _verify_guest_hlt(int signum) +{ + static struct kvm_vcpu *vcpu; + struct kvm_vm *vm; + + /* + * This function will also be called by SIGALRM handler to check the + * vCPU MP State. If vm has been initialized, then we are in the signal + * handler. Check the MP state and let the guest run again. + */ + if (vcpu) { + struct kvm_mp_state mp_state; + + vcpu_mp_state_get(vcpu, &mp_state); + TEST_ASSERT_EQ(mp_state.mp_state, KVM_MP_STATE_HALTED); + + /* Let the guest to run and finish the test.*/ + mp_state.mp_state = KVM_MP_STATE_RUNNABLE; + vcpu_mp_state_set(vcpu, &mp_state); + return; + } + + vm = td_create(); + td_initialize(vm, VM_MEM_SRC_ANONYMOUS, 0); + vcpu = td_vcpu_add(vm, 0, guest_hlt); + td_finalize(vm); + + printf("Verifying HLT:\n"); + + printf("\t ... Running guest\n"); + + /* Wait 1 second for guest to execute HLT */ + wake_me(1); + tdx_run(vcpu); + + tdx_test_assert_success(vcpu); + + kvm_vm_free(vm); + printf("\t ... PASSED\n"); +} + +void verify_guest_hlt(void) +{ + _verify_guest_hlt(0); +} + int main(int argc, char **argv) { ksft_print_header(); @@ -649,7 +726,7 @@ int main(int argc, char **argv) if (!is_tdx_enabled()) ksft_exit_skip("TDX is not supported by the KVM. Exiting.\n"); - ksft_set_plan(9); + ksft_set_plan(10); ksft_test_result(!run_in_new_process(&verify_td_lifecycle), "verify_td_lifecycle\n"); ksft_test_result(!run_in_new_process(&verify_report_fatal_error), @@ -668,6 +745,8 @@ int main(int argc, char **argv) "verify_guest_msr_writes\n"); ksft_test_result(!run_in_new_process(&verify_guest_msr_reads), "verify_guest_msr_reads\n"); + ksft_test_result(!run_in_new_process(&verify_guest_hlt), + "verify_guest_hlt\n"); ksft_finished(); return 0;