diff mbox series

[bpf-next,v2] selftests/bpf: Drop return in bpf_testmod_exit

Message ID 5765b287ea088f0c820f2a834faf9b20fb2f8215.1706442113.git.tanggeliang@kylinos.cn (mailing list archive)
State Accepted
Commit f149d03f450b4afab11f5e1ebd8fdfaf7eb24a28
Headers show
Series [bpf-next,v2] selftests/bpf: Drop return in bpf_testmod_exit | expand

Commit Message

Geliang Tang Jan. 28, 2024, 11:43 a.m. UTC 
From: Geliang Tang <tanggeliang@kylinos.cn>

bpf_testmod_exit() should not have a return value, so this patch drops this
useless 'return' in it.

Acked-by: Jiri Olsa <jolsa@kernel.org>
Signed-off-by: Geliang Tang <tanggeliang@kylinos.cn>
---
v2:
 - rebase on top of latest bpf-next/master.
---
 tools/testing/selftests/bpf/bpf_testmod/bpf_testmod.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

patchwork-bot+netdevbpf@kernel.org Jan. 29, 2024, 3:50 p.m. UTC | #1 
Hello:

This patch was applied to bpf/bpf-next.git (master)
by Daniel Borkmann <daniel@iogearbox.net>:

On Sun, 28 Jan 2024 19:43:57 +0800 you wrote:
> From: Geliang Tang <tanggeliang@kylinos.cn>
> 
> bpf_testmod_exit() should not have a return value, so this patch drops this
> useless 'return' in it.
> 
> Acked-by: Jiri Olsa <jolsa@kernel.org>
> Signed-off-by: Geliang Tang <tanggeliang@kylinos.cn>
> 
> [...]

Here is the summary with links:
  - [bpf-next,v2] selftests/bpf: Drop return in bpf_testmod_exit
    https://git.kernel.org/bpf/bpf-next/c/f149d03f450b

You are awesome, thank you!
diff mbox series

Patch

diff --git a/tools/testing/selftests/bpf/bpf_testmod/bpf_testmod.c b/tools/testing/selftests/bpf/bpf_testmod/bpf_testmod.c
index 8befaf17d454..6f163a0f1c94 100644
--- a/tools/testing/selftests/bpf/bpf_testmod/bpf_testmod.c
+++ b/tools/testing/selftests/bpf/bpf_testmod/bpf_testmod.c
@@ -619,7 +619,7 @@  static void bpf_testmod_exit(void)
 	while (refcount_read(&prog_test_struct.cnt) > 1)
 		msleep(20);
 
-	return sysfs_remove_bin_file(kernel_kobj, &bin_attr_bpf_testmod_file);
+	sysfs_remove_bin_file(kernel_kobj, &bin_attr_bpf_testmod_file);
 }
 
 module_init(bpf_testmod_init);