diff mbox series

[RFC,v2,4/8] drm/i915: add support to run KUnit tests on bare metal

Message ID df4fd92968cb7442dd2778f1c6f3e69935c5796b.1667486144.git.mchehab@kernel.org (mailing list archive)
State New
Headers show
Series Add KUnit support for i915 driver | expand

Commit Message

Mauro Carvalho Chehab Nov. 3, 2022, 2:51 p.m. UTC
Add a logic to seek for PCI devices and to run tests on
them, if the tests are willing to run on physical hardware,
instead of using Qemu.

Later patches will add the KUnit tests. So, for now, mark
such functions with __maybe_unused, to avoid build issues
with WERROR.

Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
---

To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover.
See [PATCH RFC v2 0/8] at: https://lore.kernel.org/all/cover.1667486144.git.mchehab@kernel.org/

 drivers/gpu/drm/i915/selftests/i915_kunit.c | 100 ++++++++++++++++++++
 1 file changed, 100 insertions(+)
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/selftests/i915_kunit.c b/drivers/gpu/drm/i915/selftests/i915_kunit.c
index 731b84a1fdc3..430610864f6e 100644
--- a/drivers/gpu/drm/i915/selftests/i915_kunit.c
+++ b/drivers/gpu/drm/i915/selftests/i915_kunit.c
@@ -8,9 +8,109 @@ 
 
 #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
 
+#include <linux/pci.h>
 #include <kunit/test.h>
+#include "i915_drv.h"
 #include "i915_selftest.h"
 
+#define MAX_PCI_BOARDS	8
+
+/*
+ * PCI selftest support
+ *
+ * It is possible to run tests that demands hardware in bare metal.
+ *
+ * Add a logic to detect and get PCI devices using i915 driver, up to
+ * MAX_PCI_BOARDS devices.
+ */
+
+static int n_boards;
+static struct pci_dev *dev_i915[MAX_PCI_BOARDS];
+static int __maybe_unused i915_pci_init_suite(struct kunit_suite *suite)
+{
+	struct pci_dev *pdev = NULL;
+	int i;
+
+	/* Check for PCI devices with i915 driver */
+	do {
+		/*
+		 * Let's search all devices at the PCI ID. We could, instead,
+		 * use include/drm/i915_pciids.h, but that would mean a much
+		 * more complex code, and won't still warrant that the device
+		 * was bound to i915 driver. So, let's check the driver's
+		 * name instead.
+		 */
+		pdev = pci_get_device(PCI_VENDOR_ID_INTEL, PCI_ANY_ID, pdev);
+		if (pdev) {
+			if (pdev->driver && !strcmp(pdev->driver->name, "i915")) {
+				pr_info("%s: it is a i915 device.\n",
+					pci_name(pdev));
+
+				for (i = 0; i < n_boards; i++) {
+					if (pdev == dev_i915[i]) {
+						pci_dev_put(pdev);
+						continue;
+					}
+				}
+				dev_i915[n_boards++] = pdev;
+				if (n_boards >= MAX_PCI_BOARDS)
+					break;
+			} else {
+				pci_dev_put(pdev);
+			}
+		}
+	} while (pdev);
+
+	return 0;
+}
+
+static void __maybe_unused i915_pci_exit_suite(struct kunit_suite *suite)
+{
+	int i;
+
+	for (i = 0; i < n_boards; i++)
+		pci_dev_put(dev_i915[i]);
+
+	n_boards = 0;
+}
+
+static void __maybe_unused run_pci_test(struct kunit *test,
+					int (*f)(struct drm_i915_private *i915))
+{
+	struct drm_i915_private *i915;
+	int i, ret, disable_display;
+
+	if (!n_boards)
+		kunit_skip(test, "runs only on i915 hardware\n");
+
+	for (i = 0; i < n_boards; i++) {
+		i915 = pdev_to_i915(dev_i915[i]);
+
+		cond_resched();
+		if (signal_pending(current))
+			return;
+
+		pr_info("Running %s on %s\n",
+			test->name, pci_name(dev_i915[i]));
+
+		/* FIXME: is it ok to disable_display here? */
+		disable_display = i915->params.disable_display;
+		i915->params.disable_display = 1;
+		ret = f(i915);
+		i915->params.disable_display = disable_display;
+
+		if (ret == -EINTR && !signal_pending(current))
+			ret = 0;
+
+		if (WARN(ret > 0 || ret == -ENOTTY,
+			"%s returned %d, conflicting with selftest's magic values!\n",
+			test->name, ret))
+			ret = -EINVAL;
+
+		KUNIT_EXPECT_EQ(test, ret, 0);
+	}
+}
+
 /*
  * Test run logic, similar to what i915 selftest does
  */