| Message ID | fc4ff67f28c6a6b83afecb6a6e22d632e23b82f2.1568116761.git.esyr@redhat.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Update clone3 self-tests | expand |
On 9/10/19 6:03 AM, Eugene Syromiatnikov wrote: > * tools/testing/selftests/clone3/clone3.c (test_clone3): Change format > qualifier for printing size field from %d to %zu; place colon right > after the word "says". > Please drop the file name. The rest looks good. I am assuming there is a reason for doing this. Please include compile warns if applicable. > Signed-off-by: Eugene Syromiatnikov <esyr@redhat.com> > --- > tools/testing/selftests/clone3/clone3.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/clone3/clone3.c b/tools/testing/selftests/clone3/clone3.c > index 1746a9b..7b8d927 100644 > --- a/tools/testing/selftests/clone3/clone3.c > +++ b/tools/testing/selftests/clone3/clone3.c > @@ -109,11 +109,11 @@ static int test_clone3(uint64_t flags, size_t size, int expected, > { > int ret; > > - ksft_print_msg("[%d] Trying clone3() with flags %#" PRIx64 " (size %d)" > + ksft_print_msg("[%d] Trying clone3() with flags %#" PRIx64 " (size %zu)" > "\n", > getpid(), flags, size); > ret = call_clone3(flags, size, test_mode); > - ksft_print_msg("[%d] clone3() with flags says :%d expected %d\n", > + ksft_print_msg("[%d] clone3() with flags says: %d expected %d\n", > getpid(), ret, expected); > if (ret != expected) > ksft_exit_fail_msg( > thanks, -- Shuah
diff --git a/tools/testing/selftests/clone3/clone3.c b/tools/testing/selftests/clone3/clone3.c index 1746a9b..7b8d927 100644 --- a/tools/testing/selftests/clone3/clone3.c +++ b/tools/testing/selftests/clone3/clone3.c @@ -109,11 +109,11 @@ static int test_clone3(uint64_t flags, size_t size, int expected, { int ret; - ksft_print_msg("[%d] Trying clone3() with flags %#" PRIx64 " (size %d)" + ksft_print_msg("[%d] Trying clone3() with flags %#" PRIx64 " (size %zu)" "\n", getpid(), flags, size); ret = call_clone3(flags, size, test_mode); - ksft_print_msg("[%d] clone3() with flags says :%d expected %d\n", + ksft_print_msg("[%d] clone3() with flags says: %d expected %d\n", getpid(), ret, expected); if (ret != expected) ksft_exit_fail_msg(
* tools/testing/selftests/clone3/clone3.c (test_clone3): Change format qualifier for printing size field from %d to %zu; place colon right after the word "says". Signed-off-by: Eugene Syromiatnikov <esyr@redhat.com> --- tools/testing/selftests/clone3/clone3.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)