Message ID | tencent_CB281722B3C1BD504C16CDE586CACC2BE706@qq.com (mailing list archive) |
---|---|
State | Accepted |
Commit | 11e456cae91e9044cb12c2b037b52c9b268925f7 |
Headers | show |
Series | [bpf-next,v2] selftests/bpf: Fix compilation errors: assign a value to a constant | expand |
Hello: This patch was applied to bpf/bpf-next.git (master) by Andrii Nakryiko <andrii@kernel.org>: On Fri, 24 Feb 2023 23:10:02 +0800 you wrote: > From: Rong Tao <rongtao@cestc.cn> > > commit bc292ab00f6c("mm: introduce vma->vm_flags wrapper functions") > turns the vm_flags into a const variable. > > Added bpf_find_vma test in commit f108662b27c9("selftests/bpf: Add tests > for bpf_find_vma") to assign values to variables that declare const in > find_vma_fail1.c programs, which is an error to the compiler and does not > test BPF verifiers. It is better to replace 'const vm_flags_t vm_flags' > with 'unsigned long vm_start' for testing. > > [...] Here is the summary with links: - [bpf-next,v2] selftests/bpf: Fix compilation errors: assign a value to a constant https://git.kernel.org/bpf/bpf-next/c/11e456cae91e You are awesome, thank you!
diff --git a/tools/testing/selftests/bpf/progs/find_vma_fail1.c b/tools/testing/selftests/bpf/progs/find_vma_fail1.c index b3b326b8e2d1..47d5dedff554 100644 --- a/tools/testing/selftests/bpf/progs/find_vma_fail1.c +++ b/tools/testing/selftests/bpf/progs/find_vma_fail1.c @@ -13,7 +13,7 @@ static long write_vma(struct task_struct *task, struct vm_area_struct *vma, struct callback_ctx *data) { /* writing to vma, which is illegal */ - vma->vm_flags |= 0x55; + vma->vm_start = 0xffffffffff600000; return 0; }