| Message ID | 1539005572-803-1-git-send-email-vgarodia@codeaurora.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | Venus updates - PIL | expand |
<A Friendly reminder for review> On 2018-10-08 19:02, Vikash Garodia wrote: > This version of the series > * extends the description of firmware subnode in documentation. > * renames the flag suggesting the presence of tz and update code > accordingly. > > Stanimir Varbanov (1): > venus: firmware: register separate platform_device for firmware > loader > > Vikash Garodia (4): > venus: firmware: add routine to reset ARM9 > venus: firmware: move load firmware in a separate function > venus: firmware: add no TZ boot and shutdown routine > dt-bindings: media: Document bindings for venus firmware device > > .../devicetree/bindings/media/qcom,venus.txt | 14 +- > drivers/media/platform/qcom/venus/core.c | 24 ++- > drivers/media/platform/qcom/venus/core.h | 6 + > drivers/media/platform/qcom/venus/firmware.c | 235 > +++++++++++++++++++-- > drivers/media/platform/qcom/venus/firmware.h | 17 +- > drivers/media/platform/qcom/venus/hfi_venus.c | 13 +- > drivers/media/platform/qcom/venus/hfi_venus_io.h | 8 + > 7 files changed, 274 insertions(+), 43 deletions(-)
Hi Vikash, On 10/16/2018 06:55 PM, Vikash Garodia wrote: > <A Friendly reminder for review> I have no review comments. I'll need some time to test this version on v1 and v3. > > On 2018-10-08 19:02, Vikash Garodia wrote: >> This version of the series >> * extends the description of firmware subnode in documentation. >> * renames the flag suggesting the presence of tz and update code >> accordingly. >> >> Stanimir Varbanov (1): >> venus: firmware: register separate platform_device for firmware loader >> >> Vikash Garodia (4): >> venus: firmware: add routine to reset ARM9 >> venus: firmware: move load firmware in a separate function >> venus: firmware: add no TZ boot and shutdown routine >> dt-bindings: media: Document bindings for venus firmware device >> >> .../devicetree/bindings/media/qcom,venus.txt | 14 +- >> drivers/media/platform/qcom/venus/core.c | 24 ++- >> drivers/media/platform/qcom/venus/core.h | 6 + >> drivers/media/platform/qcom/venus/firmware.c | 235 >> +++++++++++++++++++-- >> drivers/media/platform/qcom/venus/firmware.h | 17 +- >> drivers/media/platform/qcom/venus/hfi_venus.c | 13 +- >> drivers/media/platform/qcom/venus/hfi_venus_io.h | 8 + >> 7 files changed, 274 insertions(+), 43 deletions(-)
Hi Vikash, Thanks for the patches and patience! On 10/08/2018 04:32 PM, Vikash Garodia wrote: > This version of the series > * extends the description of firmware subnode in documentation. > * renames the flag suggesting the presence of tz and update code > accordingly. > > Stanimir Varbanov (1): > venus: firmware: register separate platform_device for firmware loader > > Vikash Garodia (4): > venus: firmware: add routine to reset ARM9 > venus: firmware: move load firmware in a separate function > venus: firmware: add no TZ boot and shutdown routine > dt-bindings: media: Document bindings for venus firmware device > > .../devicetree/bindings/media/qcom,venus.txt | 14 +- > drivers/media/platform/qcom/venus/core.c | 24 ++- > drivers/media/platform/qcom/venus/core.h | 6 + > drivers/media/platform/qcom/venus/firmware.c | 235 +++++++++++++++++++-- > drivers/media/platform/qcom/venus/firmware.h | 17 +- > drivers/media/platform/qcom/venus/hfi_venus.c | 13 +- > drivers/media/platform/qcom/venus/hfi_venus_io.h | 8 + > 7 files changed, 274 insertions(+), 43 deletions(-) > Tested-by: Stanimir Varbanov <stanimir.varbanov@linaro.org> With the comment addressed in 1/5: Acked-by: Stanimir Varbanov <stanimir.varbanov@linaro.org>
Hi Stanimir, Thanks for the review and approvals. I have just posted v12 with the below comments addressed. Please check and provide your blessings :) On 2018-10-17 14:40, Stanimir Varbanov wrote: > Hi Vikash, > > Thanks for the patches and patience! > > On 10/08/2018 04:32 PM, Vikash Garodia wrote: >> This version of the series >> * extends the description of firmware subnode in documentation. >> * renames the flag suggesting the presence of tz and update code >> accordingly. >> >> Stanimir Varbanov (1): >> venus: firmware: register separate platform_device for firmware >> loader >> >> Vikash Garodia (4): >> venus: firmware: add routine to reset ARM9 >> venus: firmware: move load firmware in a separate function >> venus: firmware: add no TZ boot and shutdown routine >> dt-bindings: media: Document bindings for venus firmware device >> >> .../devicetree/bindings/media/qcom,venus.txt | 14 +- >> drivers/media/platform/qcom/venus/core.c | 24 ++- >> drivers/media/platform/qcom/venus/core.h | 6 + >> drivers/media/platform/qcom/venus/firmware.c | 235 >> +++++++++++++++++++-- >> drivers/media/platform/qcom/venus/firmware.h | 17 +- >> drivers/media/platform/qcom/venus/hfi_venus.c | 13 +- >> drivers/media/platform/qcom/venus/hfi_venus_io.h | 8 + >> 7 files changed, 274 insertions(+), 43 deletions(-) >> > > Tested-by: Stanimir Varbanov <stanimir.varbanov@linaro.org> > > With the comment addressed in 1/5: > > Acked-by: Stanimir Varbanov <stanimir.varbanov@linaro.org>