mbox series

[v2,0/7] add UniPhier DVB Frontend system support

Message ID 20180808052519.14528-1-suzuki.katsuhiro@socionext.com (mailing list archive)
Headers show
Series add UniPhier DVB Frontend system support | expand

Message

Katsuhiro Suzuki Aug. 8, 2018, 5:25 a.m. UTC 
This series adds support for DVB Frontend system named HSC support
for UniPhier LD11/LD20 SoCs. This driver supports MPEG2-TS serial
signal input from external demodulator and DMA MPEG2-TS stream data
onto memory.

UniPhier HSC driver provides many ports of TS input. Since the HSC
has mixed register map for those ports. It hard to split each register
areas.

---

Changes from v1:
  DT bindings
    - Fix mistakes of spelling
    - Rename uniphier,hsc.txt -> socionext,uniphier-hsc.txt
  Kconfig, Makefile
    - Add COMPILE_TEST, REGMAP_MMIO
    - Add $(srctree) to include path option
  Headers
    - Split large patch
    - Remove more unused definitions
    - Remove unneeded const
    - Replace enum that has special value into #define
    - Remove weird macro from register definitions
    - Remove field_get/prop inline functions
  Modules
    - Split register definitions, function prototypes
    - Fix include lines
    - Fix depended config
    - Remove redundant conditions
    - Drop adapter patches, and need no patches to build
    - Merge uniphier-adapter.o into each adapter drivers
    - Split 3 modules (core, ld11, ld20) to build adapter drivers as
      module
    - Fix compile error if build as module
    - Use hardware spec table to remove weird macro from register
      definitions
    - Use usleep_range instead of msleep
    - Use shift and mask instead of field_get/prop inline functions

Katsuhiro Suzuki (7):
  media: uniphier: add DT bindings documentation for UniPhier HSC
  media: uniphier: add DMA common file of HSC
  media: uniphier: add CSS common file of HSC
  media: uniphier: add TS common file of HSC
  media: uniphier: add ucode load common file of HSC
  media: uniphier: add platform driver module of HSC
  media: uniphier: add LD11/LD20 HSC support

 .../bindings/media/socionext,uniphier-hsc.txt |  38 ++
 drivers/media/platform/Kconfig                |   1 +
 drivers/media/platform/Makefile               |   2 +
 drivers/media/platform/uniphier/Kconfig       |  19 +
 drivers/media/platform/uniphier/Makefile      |   5 +
 drivers/media/platform/uniphier/hsc-core.c    | 515 ++++++++++++++++++
 drivers/media/platform/uniphier/hsc-css.c     | 250 +++++++++
 drivers/media/platform/uniphier/hsc-dma.c     | 212 +++++++
 drivers/media/platform/uniphier/hsc-ld11.c    | 273 ++++++++++
 drivers/media/platform/uniphier/hsc-reg.h     | 272 +++++++++
 drivers/media/platform/uniphier/hsc-ts.c      | 127 +++++
 drivers/media/platform/uniphier/hsc-ucode.c   | 416 ++++++++++++++
 drivers/media/platform/uniphier/hsc.h         | 389 +++++++++++++
 13 files changed, 2519 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/media/socionext,uniphier-hsc.txt
 create mode 100644 drivers/media/platform/uniphier/Kconfig
 create mode 100644 drivers/media/platform/uniphier/Makefile
 create mode 100644 drivers/media/platform/uniphier/hsc-core.c
 create mode 100644 drivers/media/platform/uniphier/hsc-css.c
 create mode 100644 drivers/media/platform/uniphier/hsc-dma.c
 create mode 100644 drivers/media/platform/uniphier/hsc-ld11.c
 create mode 100644 drivers/media/platform/uniphier/hsc-reg.h
 create mode 100644 drivers/media/platform/uniphier/hsc-ts.c
 create mode 100644 drivers/media/platform/uniphier/hsc-ucode.c
 create mode 100644 drivers/media/platform/uniphier/hsc.h

Comments

Katsuhiro Suzuki Aug. 30, 2018, 1:13 a.m. UTC | #1 
Hello Mauro,

This is ping...

> -----Original Message-----
> From: Katsuhiro Suzuki <suzuki.katsuhiro@socionext.com>
> Sent: Wednesday, August 8, 2018 2:25 PM
> To: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>;
> linux-media@vger.kernel.org
> Cc: Masami Hiramatsu <masami.hiramatsu@linaro.org>; Jassi Brar
> <jaswinder.singh@linaro.org>; linux-arm-kernel@lists.infradead.org;
> linux-kernel@vger.kernel.org; Suzuki, Katsuhiro 
> <suzuki.katsuhiro@socionext.com>
> Subject: [PATCH v2 0/7] add UniPhier DVB Frontend system support
> 
> This series adds support for DVB Frontend system named HSC support
> for UniPhier LD11/LD20 SoCs. This driver supports MPEG2-TS serial
> signal input from external demodulator and DMA MPEG2-TS stream data
> onto memory.
> 
> UniPhier HSC driver provides many ports of TS input. Since the HSC
> has mixed register map for those ports. It hard to split each register
> areas.
> 
> ---
> 
> Changes from v1:
>   DT bindings
>     - Fix mistakes of spelling
>     - Rename uniphier,hsc.txt -> socionext,uniphier-hsc.txt
>   Kconfig, Makefile
>     - Add COMPILE_TEST, REGMAP_MMIO
>     - Add $(srctree) to include path option
>   Headers
>     - Split large patch
>     - Remove more unused definitions
>     - Remove unneeded const
>     - Replace enum that has special value into #define
>     - Remove weird macro from register definitions
>     - Remove field_get/prop inline functions
>   Modules
>     - Split register definitions, function prototypes
>     - Fix include lines
>     - Fix depended config
>     - Remove redundant conditions
>     - Drop adapter patches, and need no patches to build
>     - Merge uniphier-adapter.o into each adapter drivers
>     - Split 3 modules (core, ld11, ld20) to build adapter drivers as
>       module
>     - Fix compile error if build as module
>     - Use hardware spec table to remove weird macro from register
>       definitions
>     - Use usleep_range instead of msleep
>     - Use shift and mask instead of field_get/prop inline functions
> 
> Katsuhiro Suzuki (7):
>   media: uniphier: add DT bindings documentation for UniPhier HSC
>   media: uniphier: add DMA common file of HSC
>   media: uniphier: add CSS common file of HSC
>   media: uniphier: add TS common file of HSC
>   media: uniphier: add ucode load common file of HSC
>   media: uniphier: add platform driver module of HSC
>   media: uniphier: add LD11/LD20 HSC support
> 
>  .../bindings/media/socionext,uniphier-hsc.txt |  38 ++
>  drivers/media/platform/Kconfig                |   1 +
>  drivers/media/platform/Makefile               |   2 +
>  drivers/media/platform/uniphier/Kconfig       |  19 +
>  drivers/media/platform/uniphier/Makefile      |   5 +
>  drivers/media/platform/uniphier/hsc-core.c    | 515 ++++++++++++++++++
>  drivers/media/platform/uniphier/hsc-css.c     | 250 +++++++++
>  drivers/media/platform/uniphier/hsc-dma.c     | 212 +++++++
>  drivers/media/platform/uniphier/hsc-ld11.c    | 273 ++++++++++
>  drivers/media/platform/uniphier/hsc-reg.h     | 272 +++++++++
>  drivers/media/platform/uniphier/hsc-ts.c      | 127 +++++
>  drivers/media/platform/uniphier/hsc-ucode.c   | 416 ++++++++++++++
>  drivers/media/platform/uniphier/hsc.h         | 389 +++++++++++++
>  13 files changed, 2519 insertions(+)
>  create mode 100644
> Documentation/devicetree/bindings/media/socionext,uniphier-hsc.txt
>  create mode 100644 drivers/media/platform/uniphier/Kconfig
>  create mode 100644 drivers/media/platform/uniphier/Makefile
>  create mode 100644 drivers/media/platform/uniphier/hsc-core.c
>  create mode 100644 drivers/media/platform/uniphier/hsc-css.c
>  create mode 100644 drivers/media/platform/uniphier/hsc-dma.c
>  create mode 100644 drivers/media/platform/uniphier/hsc-ld11.c
>  create mode 100644 drivers/media/platform/uniphier/hsc-reg.h
>  create mode 100644 drivers/media/platform/uniphier/hsc-ts.c
>  create mode 100644 drivers/media/platform/uniphier/hsc-ucode.c
>  create mode 100644 drivers/media/platform/uniphier/hsc.h
> 
> --
> 2.18.0
Mauro Carvalho Chehab Dec. 7, 2018, 2:17 p.m. UTC | #2 
Hi Katsuhiro-san,

Em Thu, 30 Aug 2018 10:13:11 +0900
"Katsuhiro Suzuki" <suzuki.katsuhiro@socionext.com> escreveu:

> Hello Mauro,
> 
> This is ping...

Sorry for taking a long time to look into it.

Reviewing new drivers take some time, and need to be done right.

I usually let the sub-maintainers to do a first look, but they
probably missed this one. So, let me copy them. Hopefully they
can do review on it soon.

I'll try to do a review myself, but I won't be able to do it
until mid next week.

Regards,
Mauro

> 
> > -----Original Message-----
> > From: Katsuhiro Suzuki <suzuki.katsuhiro@socionext.com>
> > Sent: Wednesday, August 8, 2018 2:25 PM
> > To: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>;
> > linux-media@vger.kernel.org
> > Cc: Masami Hiramatsu <masami.hiramatsu@linaro.org>; Jassi Brar
> > <jaswinder.singh@linaro.org>; linux-arm-kernel@lists.infradead.org;
> > linux-kernel@vger.kernel.org; Suzuki, Katsuhiro 
> > <suzuki.katsuhiro@socionext.com>
> > Subject: [PATCH v2 0/7] add UniPhier DVB Frontend system support
> > 
> > This series adds support for DVB Frontend system named HSC support
> > for UniPhier LD11/LD20 SoCs. This driver supports MPEG2-TS serial
> > signal input from external demodulator and DMA MPEG2-TS stream data
> > onto memory.
> > 
> > UniPhier HSC driver provides many ports of TS input. Since the HSC
> > has mixed register map for those ports. It hard to split each register
> > areas.
> > 
> > ---
> > 
> > Changes from v1:
> >   DT bindings
> >     - Fix mistakes of spelling
> >     - Rename uniphier,hsc.txt -> socionext,uniphier-hsc.txt
> >   Kconfig, Makefile
> >     - Add COMPILE_TEST, REGMAP_MMIO
> >     - Add $(srctree) to include path option
> >   Headers
> >     - Split large patch
> >     - Remove more unused definitions
> >     - Remove unneeded const
> >     - Replace enum that has special value into #define
> >     - Remove weird macro from register definitions
> >     - Remove field_get/prop inline functions
> >   Modules
> >     - Split register definitions, function prototypes
> >     - Fix include lines
> >     - Fix depended config
> >     - Remove redundant conditions
> >     - Drop adapter patches, and need no patches to build
> >     - Merge uniphier-adapter.o into each adapter drivers
> >     - Split 3 modules (core, ld11, ld20) to build adapter drivers as
> >       module
> >     - Fix compile error if build as module
> >     - Use hardware spec table to remove weird macro from register
> >       definitions
> >     - Use usleep_range instead of msleep
> >     - Use shift and mask instead of field_get/prop inline functions
> > 
> > Katsuhiro Suzuki (7):
> >   media: uniphier: add DT bindings documentation for UniPhier HSC
> >   media: uniphier: add DMA common file of HSC
> >   media: uniphier: add CSS common file of HSC
> >   media: uniphier: add TS common file of HSC
> >   media: uniphier: add ucode load common file of HSC
> >   media: uniphier: add platform driver module of HSC
> >   media: uniphier: add LD11/LD20 HSC support
> > 
> >  .../bindings/media/socionext,uniphier-hsc.txt |  38 ++
> >  drivers/media/platform/Kconfig                |   1 +
> >  drivers/media/platform/Makefile               |   2 +
> >  drivers/media/platform/uniphier/Kconfig       |  19 +
> >  drivers/media/platform/uniphier/Makefile      |   5 +
> >  drivers/media/platform/uniphier/hsc-core.c    | 515 ++++++++++++++++++
> >  drivers/media/platform/uniphier/hsc-css.c     | 250 +++++++++
> >  drivers/media/platform/uniphier/hsc-dma.c     | 212 +++++++
> >  drivers/media/platform/uniphier/hsc-ld11.c    | 273 ++++++++++
> >  drivers/media/platform/uniphier/hsc-reg.h     | 272 +++++++++
> >  drivers/media/platform/uniphier/hsc-ts.c      | 127 +++++
> >  drivers/media/platform/uniphier/hsc-ucode.c   | 416 ++++++++++++++
> >  drivers/media/platform/uniphier/hsc.h         | 389 +++++++++++++
> >  13 files changed, 2519 insertions(+)
> >  create mode 100644
> > Documentation/devicetree/bindings/media/socionext,uniphier-hsc.txt
> >  create mode 100644 drivers/media/platform/uniphier/Kconfig
> >  create mode 100644 drivers/media/platform/uniphier/Makefile
> >  create mode 100644 drivers/media/platform/uniphier/hsc-core.c
> >  create mode 100644 drivers/media/platform/uniphier/hsc-css.c
> >  create mode 100644 drivers/media/platform/uniphier/hsc-dma.c
> >  create mode 100644 drivers/media/platform/uniphier/hsc-ld11.c
> >  create mode 100644 drivers/media/platform/uniphier/hsc-reg.h
> >  create mode 100644 drivers/media/platform/uniphier/hsc-ts.c
> >  create mode 100644 drivers/media/platform/uniphier/hsc-ucode.c
> >  create mode 100644 drivers/media/platform/uniphier/hsc.h
> > 
> > --
> > 2.18.0  
> 
> 
> 



Thanks,
Mauro
Katsuhiro Suzuki Dec. 10, 2018, 3:55 a.m. UTC | #3 
Hello Mauro,

Thank you for reviewing. Actually, I leaved Socionext at October
this year. I tried to find next person that maintain these patches
before leaving Socionext but I could not find.

And unfortunately, I cannot test and refine these DVB patches
because Socionext evaluation boards that can receive ISDB are not
sell and SoC specification is not public.

So it's better to drop my UniPhier DVB patches, I think...

Best Regards,
---
Katsuhiro Suzuki

On 2018/12/07 23:17, Mauro Carvalho Chehab wrote:
> Hi Katsuhiro-san,
> 
> Em Thu, 30 Aug 2018 10:13:11 +0900
> "Katsuhiro Suzuki" <suzuki.katsuhiro@socionext.com> escreveu:
> 
>> Hello Mauro,
>>
>> This is ping...
> 
> Sorry for taking a long time to look into it.
> 
> Reviewing new drivers take some time, and need to be done right.
> 
> I usually let the sub-maintainers to do a first look, but they
> probably missed this one. So, let me copy them. Hopefully they
> can do review on it soon.
> 
> I'll try to do a review myself, but I won't be able to do it
> until mid next week.
> 
> Regards,
> Mauro
> 
>>
>>> -----Original Message-----
>>> From: Katsuhiro Suzuki <suzuki.katsuhiro@socionext.com>
>>> Sent: Wednesday, August 8, 2018 2:25 PM
>>> To: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>;
>>> linux-media@vger.kernel.org
>>> Cc: Masami Hiramatsu <masami.hiramatsu@linaro.org>; Jassi Brar
>>> <jaswinder.singh@linaro.org>; linux-arm-kernel@lists.infradead.org;
>>> linux-kernel@vger.kernel.org; Suzuki, Katsuhiro
>>> <suzuki.katsuhiro@socionext.com>
>>> Subject: [PATCH v2 0/7] add UniPhier DVB Frontend system support
>>>
>>> This series adds support for DVB Frontend system named HSC support
>>> for UniPhier LD11/LD20 SoCs. This driver supports MPEG2-TS serial
>>> signal input from external demodulator and DMA MPEG2-TS stream data
>>> onto memory.
>>>
>>> UniPhier HSC driver provides many ports of TS input. Since the HSC
>>> has mixed register map for those ports. It hard to split each register
>>> areas.
>>>
>>> ---
>>>
>>> Changes from v1:
>>>    DT bindings
>>>      - Fix mistakes of spelling
>>>      - Rename uniphier,hsc.txt -> socionext,uniphier-hsc.txt
>>>    Kconfig, Makefile
>>>      - Add COMPILE_TEST, REGMAP_MMIO
>>>      - Add $(srctree) to include path option
>>>    Headers
>>>      - Split large patch
>>>      - Remove more unused definitions
>>>      - Remove unneeded const
>>>      - Replace enum that has special value into #define
>>>      - Remove weird macro from register definitions
>>>      - Remove field_get/prop inline functions
>>>    Modules
>>>      - Split register definitions, function prototypes
>>>      - Fix include lines
>>>      - Fix depended config
>>>      - Remove redundant conditions
>>>      - Drop adapter patches, and need no patches to build
>>>      - Merge uniphier-adapter.o into each adapter drivers
>>>      - Split 3 modules (core, ld11, ld20) to build adapter drivers as
>>>        module
>>>      - Fix compile error if build as module
>>>      - Use hardware spec table to remove weird macro from register
>>>        definitions
>>>      - Use usleep_range instead of msleep
>>>      - Use shift and mask instead of field_get/prop inline functions
>>>
>>> Katsuhiro Suzuki (7):
>>>    media: uniphier: add DT bindings documentation for UniPhier HSC
>>>    media: uniphier: add DMA common file of HSC
>>>    media: uniphier: add CSS common file of HSC
>>>    media: uniphier: add TS common file of HSC
>>>    media: uniphier: add ucode load common file of HSC
>>>    media: uniphier: add platform driver module of HSC
>>>    media: uniphier: add LD11/LD20 HSC support
>>>
>>>   .../bindings/media/socionext,uniphier-hsc.txt |  38 ++
>>>   drivers/media/platform/Kconfig                |   1 +
>>>   drivers/media/platform/Makefile               |   2 +
>>>   drivers/media/platform/uniphier/Kconfig       |  19 +
>>>   drivers/media/platform/uniphier/Makefile      |   5 +
>>>   drivers/media/platform/uniphier/hsc-core.c    | 515 ++++++++++++++++++
>>>   drivers/media/platform/uniphier/hsc-css.c     | 250 +++++++++
>>>   drivers/media/platform/uniphier/hsc-dma.c     | 212 +++++++
>>>   drivers/media/platform/uniphier/hsc-ld11.c    | 273 ++++++++++
>>>   drivers/media/platform/uniphier/hsc-reg.h     | 272 +++++++++
>>>   drivers/media/platform/uniphier/hsc-ts.c      | 127 +++++
>>>   drivers/media/platform/uniphier/hsc-ucode.c   | 416 ++++++++++++++
>>>   drivers/media/platform/uniphier/hsc.h         | 389 +++++++++++++
>>>   13 files changed, 2519 insertions(+)
>>>   create mode 100644
>>> Documentation/devicetree/bindings/media/socionext,uniphier-hsc.txt
>>>   create mode 100644 drivers/media/platform/uniphier/Kconfig
>>>   create mode 100644 drivers/media/platform/uniphier/Makefile
>>>   create mode 100644 drivers/media/platform/uniphier/hsc-core.c
>>>   create mode 100644 drivers/media/platform/uniphier/hsc-css.c
>>>   create mode 100644 drivers/media/platform/uniphier/hsc-dma.c
>>>   create mode 100644 drivers/media/platform/uniphier/hsc-ld11.c
>>>   create mode 100644 drivers/media/platform/uniphier/hsc-reg.h
>>>   create mode 100644 drivers/media/platform/uniphier/hsc-ts.c
>>>   create mode 100644 drivers/media/platform/uniphier/hsc-ucode.c
>>>   create mode 100644 drivers/media/platform/uniphier/hsc.h
>>>
>>> --
>>> 2.18.0
>>
>>
>>
> 
> 
> 
> Thanks,
> Mauro
>