mbox series

[v3,0/9] TVP5150 fixes and new features

Message ID 20180918131453.21031-1-m.felsch@pengutronix.de (mailing list archive)
Headers show
Series TVP5150 fixes and new features | expand

Message

Marco Felsch Sept. 18, 2018, 1:14 p.m. UTC
Hi,

this is my v3 with the integrated reviews from my v2 [1]. This serie
applies to Mauro's experimental.git [2].

@Mauro:
Patch ("media: tvp5150: fix irq_request error path during probe") is new
in this series. Maybe you can squash them with ("media: tvp5150: Add sync lock
interrupt handling"), thanks.

I've tested this series on a customer dt-based board. Unfortunately I
haven't a device which use the em28xx driver. So other tester a welcome :)

[1] https://www.spinics.net/lists/devicetree/msg244129.html
[2] https://git.linuxtv.org/mchehab/experimental.git/log/?h=tvp5150-4

Javier Martinez Canillas (1):
  partial revert of "[media] tvp5150: add HW input connectors support"

Marco Felsch (7):
  media: tvp5150: fix irq_request error path during probe
  media: tvp5150: add input source selection of_graph support
  media: dt-bindings: tvp5150: Add input port connectors DT bindings
  media: v4l2-subdev: add stubs for v4l2_subdev_get_try_*
  media: v4l2-subdev: fix v4l2_subdev_get_try_* dependency
  media: tvp5150: add FORMAT_TRY support for get/set selection handlers
  media: tvp5150: add s_power callback

Michael Tretter (1):
  media: tvp5150: initialize subdev before parsing device tree

 .../devicetree/bindings/media/i2c/tvp5150.txt |  92 ++-
 drivers/media/i2c/tvp5150.c                   | 657 +++++++++++++-----
 include/dt-bindings/media/tvp5150.h           |   2 -
 include/media/v4l2-subdev.h                   |  15 +-
 4 files changed, 584 insertions(+), 182 deletions(-)

Comments

Marco Felsch Oct. 29, 2018, 6:41 p.m. UTC | #1
Hi Mauro,

just a reminder, Rob already added his ack/rev-by tags.

Thanks,
Marco

On 18-09-18 15:14, Marco Felsch wrote:
> Hi,
> 
> this is my v3 with the integrated reviews from my v2 [1]. This serie
> applies to Mauro's experimental.git [2].
> 
> @Mauro:
> Patch ("media: tvp5150: fix irq_request error path during probe") is new
> in this series. Maybe you can squash them with ("media: tvp5150: Add sync lock
> interrupt handling"), thanks.
> 
> I've tested this series on a customer dt-based board. Unfortunately I
> haven't a device which use the em28xx driver. So other tester a welcome :)
> 
> [1] https://www.spinics.net/lists/devicetree/msg244129.html
> [2] https://git.linuxtv.org/mchehab/experimental.git/log/?h=tvp5150-4
> 
> Javier Martinez Canillas (1):
>   partial revert of "[media] tvp5150: add HW input connectors support"
> 
> Marco Felsch (7):
>   media: tvp5150: fix irq_request error path during probe
>   media: tvp5150: add input source selection of_graph support
>   media: dt-bindings: tvp5150: Add input port connectors DT bindings
>   media: v4l2-subdev: add stubs for v4l2_subdev_get_try_*
>   media: v4l2-subdev: fix v4l2_subdev_get_try_* dependency
>   media: tvp5150: add FORMAT_TRY support for get/set selection handlers
>   media: tvp5150: add s_power callback
> 
> Michael Tretter (1):
>   media: tvp5150: initialize subdev before parsing device tree
> 
>  .../devicetree/bindings/media/i2c/tvp5150.txt |  92 ++-
>  drivers/media/i2c/tvp5150.c                   | 657 +++++++++++++-----
>  include/dt-bindings/media/tvp5150.h           |   2 -
>  include/media/v4l2-subdev.h                   |  15 +-
>  4 files changed, 584 insertions(+), 182 deletions(-)
> 
> -- 
> 2.19.0
> 
> 
>
Marco Felsch Nov. 9, 2018, 1:46 p.m. UTC | #2
Hi Mauro,

I don't want to spam you. Can you give me some feedback? I know the
merge window is a busy time, so maybe you have some time now.

Regards,
Marco

On 18-10-29 19:41, Marco Felsch wrote:
> Hi Mauro,
> 
> just a reminder, Rob already added his ack/rev-by tags.
> 
> Thanks,
> Marco
> 
> On 18-09-18 15:14, Marco Felsch wrote:
> > Hi,
> > 
> > this is my v3 with the integrated reviews from my v2 [1]. This serie
> > applies to Mauro's experimental.git [2].
> > 
> > @Mauro:
> > Patch ("media: tvp5150: fix irq_request error path during probe") is new
> > in this series. Maybe you can squash them with ("media: tvp5150: Add sync lock
> > interrupt handling"), thanks.
> > 
> > I've tested this series on a customer dt-based board. Unfortunately I
> > haven't a device which use the em28xx driver. So other tester a welcome :)
> > 
> > [1] https://www.spinics.net/lists/devicetree/msg244129.html
> > [2] https://git.linuxtv.org/mchehab/experimental.git/log/?h=tvp5150-4
> > 
> > Javier Martinez Canillas (1):
> >   partial revert of "[media] tvp5150: add HW input connectors support"
> > 
> > Marco Felsch (7):
> >   media: tvp5150: fix irq_request error path during probe
> >   media: tvp5150: add input source selection of_graph support
> >   media: dt-bindings: tvp5150: Add input port connectors DT bindings
> >   media: v4l2-subdev: add stubs for v4l2_subdev_get_try_*
> >   media: v4l2-subdev: fix v4l2_subdev_get_try_* dependency
> >   media: tvp5150: add FORMAT_TRY support for get/set selection handlers
> >   media: tvp5150: add s_power callback
> > 
> > Michael Tretter (1):
> >   media: tvp5150: initialize subdev before parsing device tree
> > 
> >  .../devicetree/bindings/media/i2c/tvp5150.txt |  92 ++-
> >  drivers/media/i2c/tvp5150.c                   | 657 +++++++++++++-----
> >  include/dt-bindings/media/tvp5150.h           |   2 -
> >  include/media/v4l2-subdev.h                   |  15 +-
> >  4 files changed, 584 insertions(+), 182 deletions(-)
> > 
> > -- 
> > 2.19.0
> > 
> > 
> > 
> 
> -- 
> Pengutronix e.K.                           |                             |
> Industrial Linux Solutions                 | http://www.pengutronix.de/  |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
> 
>
Mauro Carvalho Chehab Dec. 5, 2018, 9:57 a.m. UTC | #3
Hi Marco,

Em Fri, 9 Nov 2018 14:46:24 +0100
Marco Felsch <m.felsch@pengutronix.de> escreveu:

> Hi Mauro,
> 
> I don't want to spam you. Can you give me some feedback? I know the
> merge window is a busy time, so maybe you have some time now.

Sorry for taking so long on looking into it... has been really busy
those days :-(

I applied patch 2/9. Patch 3 doesn't apply. Would you mind
rebasing it on the top of upstream? there are some non-trivial
conflicts (perhaps I just missed some other preparation patch?).

I suspect that it would be easier if you could rebase your tree
on the top of the latest upstream one, e. g.:

	git://linuxtv.org/media_tree.git
	
(master branch)

Regards,
Mauro
> 
> Regards,
> Marco
> 
> On 18-10-29 19:41, Marco Felsch wrote:
> > Hi Mauro,
> > 
> > just a reminder, Rob already added his ack/rev-by tags.
> > 
> > Thanks,
> > Marco
> > 
> > On 18-09-18 15:14, Marco Felsch wrote:  
> > > Hi,
> > > 
> > > this is my v3 with the integrated reviews from my v2 [1]. This serie
> > > applies to Mauro's experimental.git [2].
> > > 
> > > @Mauro:
> > > Patch ("media: tvp5150: fix irq_request error path during probe") is new
> > > in this series. Maybe you can squash them with ("media: tvp5150: Add sync lock
> > > interrupt handling"), thanks.
> > > 
> > > I've tested this series on a customer dt-based board. Unfortunately I
> > > haven't a device which use the em28xx driver. So other tester a welcome :)
> > > 
> > > [1] https://www.spinics.net/lists/devicetree/msg244129.html
> > > [2] https://git.linuxtv.org/mchehab/experimental.git/log/?h=tvp5150-4
> > > 
> > > Javier Martinez Canillas (1):
> > >   partial revert of "[media] tvp5150: add HW input connectors support"
> > > 
> > > Marco Felsch (7):
> > >   media: tvp5150: fix irq_request error path during probe
> > >   media: tvp5150: add input source selection of_graph support
> > >   media: dt-bindings: tvp5150: Add input port connectors DT bindings
> > >   media: v4l2-subdev: add stubs for v4l2_subdev_get_try_*
> > >   media: v4l2-subdev: fix v4l2_subdev_get_try_* dependency
> > >   media: tvp5150: add FORMAT_TRY support for get/set selection handlers
> > >   media: tvp5150: add s_power callback
> > > 
> > > Michael Tretter (1):
> > >   media: tvp5150: initialize subdev before parsing device tree
> > > 
> > >  .../devicetree/bindings/media/i2c/tvp5150.txt |  92 ++-
> > >  drivers/media/i2c/tvp5150.c                   | 657 +++++++++++++-----
> > >  include/dt-bindings/media/tvp5150.h           |   2 -
> > >  include/media/v4l2-subdev.h                   |  15 +-
> > >  4 files changed, 584 insertions(+), 182 deletions(-)
> > > 
> > > -- 
> > > 2.19.0
> > > 
> > > 
> > >   
> > 
> > -- 
> > Pengutronix e.K.                           |                             |
> > Industrial Linux Solutions                 | http://www.pengutronix.de/  |
> > Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
> > Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
> > 
> >   
> 



Thanks,
Mauro