| Message ID | 20181205120950.36986-1-hverkuil-cisco@xs4all.nl (mailing list archive) |
|---|---|
| Headers | show |
| Series | cedrus: move MPEG controls out of the uAPI | expand |
Hi, On Wed, 2018-12-05 at 13:09 +0100, hverkuil-cisco@xs4all.nl wrote: > From: Hans Verkuil <hverkuil-cisco@xs4all.nl> > > The expectation was that the MPEG-2 state controls used by the staging > cedrus driver were stable, or would only require one final change. However, > it turns out that more changes are required, and that means that it is not > such a good idea to have these controls in the public kernel API. > > This patch series moves all the MPEG-2 state control data to a new > media/mpeg2-ctrls.h header. So none of this is available from the public > API. > > However, v4l2-ctrls.h includes it for now so the kAPI still knows about it > allowing the cedrus driver to use it without changes. > > The second patch adds a note to these two controls, mentioning that they > are likely to change. > > Moving forward, this allows us to take more time in getting the MPEG-2 > (and later H264/5) state controls right. Thanks a lot for this change, I'm glad we can take time to properly stabilize these controls! For the whole series: Reviewed-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com> Cheers, Paul > Regards, > > Hans > > Hans Verkuil (2): > mpeg2-ctrls.h: move MPEG2 state controls to non-public header > extended-controls.rst: add note to the MPEG2 state controls > > .../media/uapi/v4l/extended-controls.rst | 10 +++ > drivers/media/v4l2-core/v4l2-ctrls.c | 4 +- > include/media/mpeg2-ctrls.h | 86 +++++++++++++++++++ > include/media/v4l2-ctrls.h | 6 ++ > include/uapi/linux/v4l2-controls.h | 68 --------------- > include/uapi/linux/videodev2.h | 4 - > 6 files changed, 104 insertions(+), 74 deletions(-) > create mode 100644 include/media/mpeg2-ctrls.h >
From: Hans Verkuil <hverkuil-cisco@xs4all.nl> The expectation was that the MPEG-2 state controls used by the staging cedrus driver were stable, or would only require one final change. However, it turns out that more changes are required, and that means that it is not such a good idea to have these controls in the public kernel API. This patch series moves all the MPEG-2 state control data to a new media/mpeg2-ctrls.h header. So none of this is available from the public API. However, v4l2-ctrls.h includes it for now so the kAPI still knows about it allowing the cedrus driver to use it without changes. The second patch adds a note to these two controls, mentioning that they are likely to change. Moving forward, this allows us to take more time in getting the MPEG-2 (and later H264/5) state controls right. Regards, Hans Hans Verkuil (2): mpeg2-ctrls.h: move MPEG2 state controls to non-public header extended-controls.rst: add note to the MPEG2 state controls .../media/uapi/v4l/extended-controls.rst | 10 +++ drivers/media/v4l2-core/v4l2-ctrls.c | 4 +- include/media/mpeg2-ctrls.h | 86 +++++++++++++++++++ include/media/v4l2-ctrls.h | 6 ++ include/uapi/linux/v4l2-controls.h | 68 --------------- include/uapi/linux/videodev2.h | 4 - 6 files changed, 104 insertions(+), 74 deletions(-) create mode 100644 include/media/mpeg2-ctrls.h