mbox series

[RFCv5,0/4] Add properties support to the media controller

Message ID 20181213134113.15247-1-hverkuil-cisco@xs4all.nl (mailing list archive)
Headers show
Series Add properties support to the media controller | expand

Message

Hans Verkuil Dec. 13, 2018, 1:41 p.m. UTC 
From: Hans Verkuil <hverkuil-cisco@xs4all.nl>

The main changes since RFCv4 are:

- Dropped all the indexing code that I added to make it easier to
  traverse the topology. I still think that's a good idea, but that
  can be done in a future patch.
- Split the second patch into two: the first part adds the core support,
  the second adds the functions to let drivers add properties.

An updated v4l2-ctl and v4l2-compliance that can report properties
is available here:

https://git.linuxtv.org/hverkuil/v4l-utils.git/log/?h=props2

Currently I support u64, s64 and const char * property types. And also
a 'group' type that groups sub-properties. But it can be extended to any
type including binary data if needed. No array support (as we have for
controls), but there are enough reserved fields in media_v2_prop
to add this if needed.

I added properties for entities and pads to vimc, so I could test this.

Regards,

	Hans

Hans Verkuil (4):
  uapi/linux/media.h: add property support
  media controller: add properties support
  media: add functions to add properties to objects
  vimc: add property test code

 drivers/media/media-device.c              | 129 ++++++++-
 drivers/media/media-entity.c              |  90 +++++-
 drivers/media/platform/vimc/vimc-common.c |  50 ++++
 include/media/media-device.h              |   6 +
 include/media/media-entity.h              | 322 ++++++++++++++++++++++
 include/uapi/linux/media.h                |  56 ++++
 6 files changed, 639 insertions(+), 14 deletions(-)