| Message ID | 20181218113320.4856-1-jagan@amarulasolutions.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | media/sun6i: Allwinner A64 CSI support | expand |
On Tue, Dec 18, 2018 at 05:03:14PM +0530, Jagan Teki wrote: > This series support CSI on Allwinner A64. > > Tested 640x480, 320x240, 720p, 1080p resolutions UYVY8_2X8 format. > > Changes for v4: > - update the compatible string order > - add proper commit message > - included BPI-M64 patch > - skipped amarula-a64 patch > Changes for v3: > - update dt-bindings for A64 > - set mod clock via csi driver > - remove assign clocks from dtsi > - remove i2c-gpio opendrian > - fix avdd and dovdd supplies > - remove vcc-csi pin group supply > > Note: This series created on top of H3 changes [1] > > [1] https://patchwork.kernel.org/cover/10705905/ You had memory corruption before, how was this fixed? Maxime
On Tue, Dec 18, 2018 at 8:51 PM Maxime Ripard <maxime.ripard@bootlin.com> wrote: > > On Tue, Dec 18, 2018 at 05:03:14PM +0530, Jagan Teki wrote: > > This series support CSI on Allwinner A64. > > > > Tested 640x480, 320x240, 720p, 1080p resolutions UYVY8_2X8 format. > > > > Changes for v4: > > - update the compatible string order > > - add proper commit message > > - included BPI-M64 patch > > - skipped amarula-a64 patch > > Changes for v3: > > - update dt-bindings for A64 > > - set mod clock via csi driver > > - remove assign clocks from dtsi > > - remove i2c-gpio opendrian > > - fix avdd and dovdd supplies > > - remove vcc-csi pin group supply > > > > Note: This series created on top of H3 changes [1] > > > > [1] https://patchwork.kernel.org/cover/10705905/ > > You had memory corruption before, how was this fixed? Memory corruption observed with default 600MHz on 1080p. It worked fine on BPI-M64 (with 300MHz)
On Tue, Dec 18, 2018 at 08:58:22PM +0530, Jagan Teki wrote: > On Tue, Dec 18, 2018 at 8:51 PM Maxime Ripard <maxime.ripard@bootlin.com> wrote: > > > > On Tue, Dec 18, 2018 at 05:03:14PM +0530, Jagan Teki wrote: > > > This series support CSI on Allwinner A64. > > > > > > Tested 640x480, 320x240, 720p, 1080p resolutions UYVY8_2X8 format. > > > > > > Changes for v4: > > > - update the compatible string order > > > - add proper commit message > > > - included BPI-M64 patch > > > - skipped amarula-a64 patch > > > Changes for v3: > > > - update dt-bindings for A64 > > > - set mod clock via csi driver > > > - remove assign clocks from dtsi > > > - remove i2c-gpio opendrian > > > - fix avdd and dovdd supplies > > > - remove vcc-csi pin group supply > > > > > > Note: This series created on top of H3 changes [1] > > > > > > [1] https://patchwork.kernel.org/cover/10705905/ > > > > You had memory corruption before, how was this fixed? > > Memory corruption observed with default 600MHz on 1080p. It worked > fine on BPI-M64 (with 300MHz) I don't get it. In the previous version of those patches, you were mentionning you were still having this issue, even though you had the clock running at 300MHz, and then you tried to convince us to merge the patches nonetheless. Why would you say that then if that issue was fixed? Maxime
Hi Maxime On Wed, Dec 19, 2018 at 11:25 AM Maxime Ripard <maxime.ripard@bootlin.com> wrote: > > On Tue, Dec 18, 2018 at 08:58:22PM +0530, Jagan Teki wrote: > > On Tue, Dec 18, 2018 at 8:51 PM Maxime Ripard <maxime.ripard@bootlin.com> wrote: > > > > > > On Tue, Dec 18, 2018 at 05:03:14PM +0530, Jagan Teki wrote: > > > > This series support CSI on Allwinner A64. > > > > > > > > Tested 640x480, 320x240, 720p, 1080p resolutions UYVY8_2X8 format. > > > > > > > > Changes for v4: > > > > - update the compatible string order > > > > - add proper commit message > > > > - included BPI-M64 patch > > > > - skipped amarula-a64 patch > > > > Changes for v3: > > > > - update dt-bindings for A64 > > > > - set mod clock via csi driver > > > > - remove assign clocks from dtsi > > > > - remove i2c-gpio opendrian > > > > - fix avdd and dovdd supplies > > > > - remove vcc-csi pin group supply > > > > > > > > Note: This series created on top of H3 changes [1] > > > > > > > > [1] https://patchwork.kernel.org/cover/10705905/ > > > > > > You had memory corruption before, how was this fixed? > > > > Memory corruption observed with default 600MHz on 1080p. It worked > > fine on BPI-M64 (with 300MHz) > > I don't get it. In the previous version of those patches, you were > mentionning you were still having this issue, even though you had the > clock running at 300MHz, and then you tried to convince us to merge > the patches nonetheless. > > Why would you say that then if that issue was fixed? It's simple, we have a full working platform with ov5640 that support all the resolutions, that can be test by anyone and we have an industrial product that has some problem on high xvclk because it can not give us a clear image but this is limited on another design and another camera module vendor. Problem is not in the kernel code but it's just on relic design. We are getting the information on that module and see if inside is really using the xvclk or it's clocked by some other things. We have only the schematic up to the connector. Michael > > Maxime > > -- > Maxime Ripard, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com
On Wed, Dec 19, 2018 at 3:55 PM Maxime Ripard <maxime.ripard@bootlin.com> wrote: > > On Tue, Dec 18, 2018 at 08:58:22PM +0530, Jagan Teki wrote: > > On Tue, Dec 18, 2018 at 8:51 PM Maxime Ripard <maxime.ripard@bootlin.com> wrote: > > > > > > On Tue, Dec 18, 2018 at 05:03:14PM +0530, Jagan Teki wrote: > > > > This series support CSI on Allwinner A64. > > > > > > > > Tested 640x480, 320x240, 720p, 1080p resolutions UYVY8_2X8 format. > > > > > > > > Changes for v4: > > > > - update the compatible string order > > > > - add proper commit message > > > > - included BPI-M64 patch > > > > - skipped amarula-a64 patch > > > > Changes for v3: > > > > - update dt-bindings for A64 > > > > - set mod clock via csi driver > > > > - remove assign clocks from dtsi > > > > - remove i2c-gpio opendrian > > > > - fix avdd and dovdd supplies > > > > - remove vcc-csi pin group supply > > > > > > > > Note: This series created on top of H3 changes [1] > > > > > > > > [1] https://patchwork.kernel.org/cover/10705905/ > > > > > > You had memory corruption before, how was this fixed? > > > > Memory corruption observed with default 600MHz on 1080p. It worked > > fine on BPI-M64 (with 300MHz) > > I don't get it. In the previous version of those patches, you were > mentionning you were still having this issue, even though you had the > clock running at 300MHz, and then you tried to convince us to merge > the patches nonetheless. > > Why would you say that then if that issue was fixed? Previous version has A64-Relic board, which has some xclk issue on sensor side wrt 1080p. I have tried 300MHz on the same hardware, it's failing to capture on 30fps and so I tried 600MHz(which is default) on the same configuration but it encounter memory corruption. So, for checking whether there is an issue with hardware on A64-Relic I moved with BPI-M64 dev board. which is working 1080p with 300MHz, ie reason I have not included A64-Relic on this version and included BPI-M64. We processed A64-Relic to hardware team to figure out the clock and once ie fixed I'm planning to send DTS patch for that. This is overall summary, hope you understand.
65;5402;1c On Wed, Dec 19, 2018 at 04:11:50PM +0530, Jagan Teki wrote: > On Wed, Dec 19, 2018 at 3:55 PM Maxime Ripard <maxime.ripard@bootlin.com> wrote: > > > > On Tue, Dec 18, 2018 at 08:58:22PM +0530, Jagan Teki wrote: > > > On Tue, Dec 18, 2018 at 8:51 PM Maxime Ripard <maxime.ripard@bootlin.com> wrote: > > > > > > > > On Tue, Dec 18, 2018 at 05:03:14PM +0530, Jagan Teki wrote: > > > > > This series support CSI on Allwinner A64. > > > > > > > > > > Tested 640x480, 320x240, 720p, 1080p resolutions UYVY8_2X8 format. > > > > > > > > > > Changes for v4: > > > > > - update the compatible string order > > > > > - add proper commit message > > > > > - included BPI-M64 patch > > > > > - skipped amarula-a64 patch > > > > > Changes for v3: > > > > > - update dt-bindings for A64 > > > > > - set mod clock via csi driver > > > > > - remove assign clocks from dtsi > > > > > - remove i2c-gpio opendrian > > > > > - fix avdd and dovdd supplies > > > > > - remove vcc-csi pin group supply > > > > > > > > > > Note: This series created on top of H3 changes [1] > > > > > > > > > > [1] https://patchwork.kernel.org/cover/10705905/ > > > > > > > > You had memory corruption before, how was this fixed? > > > > > > Memory corruption observed with default 600MHz on 1080p. It worked > > > fine on BPI-M64 (with 300MHz) > > > > I don't get it. In the previous version of those patches, you were > > mentionning you were still having this issue, even though you had the > > clock running at 300MHz, and then you tried to convince us to merge > > the patches nonetheless. > > > > Why would you say that then if that issue was fixed? > > Previous version has A64-Relic board, which has some xclk issue on > sensor side wrt 1080p. I have tried 300MHz on the same hardware, it's > failing to capture on 30fps and so I tried 600MHz(which is default) on > the same configuration but it encounter memory corruption. > > So, for checking whether there is an issue with hardware on A64-Relic > I moved with BPI-M64 dev board. which is working 1080p with 300MHz, ie > reason I have not included A64-Relic on this version and included > BPI-M64. We processed A64-Relic to hardware team to figure out the > clock and once ie fixed I'm planning to send DTS patch for that. > > This is overall summary, hope you understand. Ok, great, thanks! Maxime