mbox series

[RFC,0/5] v4l2-ctl: list controls values in a machine-readable format

Message ID 20190103180102.12282-1-ao2@ao2.it (mailing list archive)
Headers show
Series v4l2-ctl: list controls values in a machine-readable format | expand

Message

Antonio Ospite Jan. 3, 2019, 6 p.m. UTC
Hi,

here is an experiment about listing controls values with v4l2-ctl in
a way that makes it more easy to reload them, I would use something like
that for https://git.ao2.it/v4l2-persistent-settings.git/

Patches 1 and 2 are just warm-up patches to get me familiar again with
the v4l2-ctrl codebase, patch 2 is a small preparatory cleanup, and
patches 4 and 5 showcase the idea.

Thanks,
   Antonio

Antonio Ospite (5):
  v4l2-ctl: list controls with menus when OptAll is specified
  v4l2-ctl: list once when both OptListCtrls and OptListCtrlsMenus are
    there
  v4l2-ctl: use a dedicated function to print the control class name
  v4l2-ctl: abstract the mechanism used to print the list of controls
  v4l2-ctl: add an option to list controls in a machine-readable format

 utils/v4l2-ctl/v4l2-ctl-common.cpp | 95 +++++++++++++++++++++++++-----
 utils/v4l2-ctl/v4l2-ctl.1.in       |  4 ++
 utils/v4l2-ctl/v4l2-ctl.cpp        |  3 +-
 utils/v4l2-ctl/v4l2-ctl.h          |  1 +
 4 files changed, 88 insertions(+), 15 deletions(-)

Comments

Hans Verkuil Jan. 7, 2019, 10:21 a.m. UTC | #1
On 01/03/2019 07:00 PM, Antonio Ospite wrote:
> Hi,
> 
> here is an experiment about listing controls values with v4l2-ctl in
> a way that makes it more easy to reload them, I would use something like
> that for https://git.ao2.it/v4l2-persistent-settings.git/
> 
> Patches 1 and 2 are just warm-up patches to get me familiar again with
> the v4l2-ctrl codebase, patch 2 is a small preparatory cleanup, and
> patches 4 and 5 showcase the idea.
> 
> Thanks,
>    Antonio
> 
> Antonio Ospite (5):
>   v4l2-ctl: list controls with menus when OptAll is specified
>   v4l2-ctl: list once when both OptListCtrls and OptListCtrlsMenus are
>     there

I merged these first two patches.

>   v4l2-ctl: use a dedicated function to print the control class name
>   v4l2-ctl: abstract the mechanism used to print the list of controls
>   v4l2-ctl: add an option to list controls in a machine-readable format

The others need more work, see my review of the last patch.

Thanks for working on this!

Regards,

	Hans

> 
>  utils/v4l2-ctl/v4l2-ctl-common.cpp | 95 +++++++++++++++++++++++++-----
>  utils/v4l2-ctl/v4l2-ctl.1.in       |  4 ++
>  utils/v4l2-ctl/v4l2-ctl.cpp        |  3 +-
>  utils/v4l2-ctl/v4l2-ctl.h          |  1 +
>  4 files changed, 88 insertions(+), 15 deletions(-)
>