From patchwork Wed Feb 27 03:54:45 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Chenbo Feng X-Patchwork-Id: 10831029 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 11A471669 for ; Wed, 27 Feb 2019 03:54:56 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id F08222C74D for ; Wed, 27 Feb 2019 03:54:55 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E396E2C76D; Wed, 27 Feb 2019 03:54:55 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, USER_IN_DEF_DKIM_WL autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7700A2C74D for ; Wed, 27 Feb 2019 03:54:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729539AbfB0Dyy (ORCPT ); Tue, 26 Feb 2019 22:54:54 -0500 Received: from mail-pl1-f202.google.com ([209.85.214.202]:54245 "EHLO mail-pl1-f202.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729128AbfB0Dyy (ORCPT ); Tue, 26 Feb 2019 22:54:54 -0500 Received: by mail-pl1-f202.google.com with SMTP id t1so11448577plo.20 for ; Tue, 26 Feb 2019 19:54:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:message-id:mime-version:subject:from:to:cc :content-transfer-encoding; bh=baxX1S5LtzfmqzAc72hpJ9BN2ZK/N6upcf+SaQYT9NE=; b=H7+eMG8ZA+v74XjzyzM6+KITVbJ6KK1i8VEz0BpZZaLGJgUdiPXnPd1EDEUuycCsJp EZjhK0tQFpeoWNcZ2Wq1CZFFJCW8T5uGW9Z89a2S63u7RvNqfmC3MwzNzVJFNTclY7gr 2MfG5bgxZr9xLo9JMwZNIup9SWhiM48jLyyAgxjf0UmO5wcME2LCVDSr8k6AgOev9789 A8THemqcpxx8ygWkV+8Md5gdP8XUkDfhv92yU3K2EKaW1ji77daw9JAExPlZak4rX8LE sMgLDc4QpcDuLmkD6awMTGqP+aKYbwAhwvyZuFlYUqKdycxWOz8BqfghYIUnjxQn33xE w1ig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc :content-transfer-encoding; bh=baxX1S5LtzfmqzAc72hpJ9BN2ZK/N6upcf+SaQYT9NE=; b=U1k2g8drlmMRpr8uGKUVx3IY02zKsEd6d+jGOWeXeXeWBl+Bv9v+Hv4es0yvZLfpUV H9OIV4bqpgFPfDzEW6HhMmy7BkjZfT/jlaAj7svYvNDhAvvaWKs7rK0l85L0xKlmyzDe mmojBtNgvkedXIWjLk+V1Yw0Frdbti1HmlC9pUYzeODVcBOk4CEpi1N5o64t8/ASV+C1 EpiF/qGExY4MeTElt/VhYPQe7wvCCg9BCJra2JR4Ai/v9jlsWPMqQBH7EglJcCyXCyVQ SfwyCjpr2OFi1YbvRXty9oshBFyL9OxBiyp67lDDJZJ6pXHEZ//YX64KRmWptGABZY9b uI9Q== X-Gm-Message-State: AHQUAuYdHKdDpgWlP833cl6BK63JxEKFnajvCtm2Q7xhM4HTdDD5fRZW hmw1P0QlB3cdyGyekXMn6wFIGdZByw== X-Google-Smtp-Source: AHgI3Ib/imDfoZJ4ItLCNcbF5XtYkjqiznblt6qKt1+LhMd5yLSVUg6ce1CYUmoalvSop74kbXFYdi7LJg== X-Received: by 2002:aa7:8718:: with SMTP id b24mr9117456pfo.139.1551239693479; Tue, 26 Feb 2019 19:54:53 -0800 (PST) Date: Tue, 26 Feb 2019 19:54:45 -0800 Message-Id: <20190227035448.117169-1-fengc@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.21.0.rc2.261.ga7da99ff1b-goog Subject: [RFC dma-buf 0/3] Improve the dma-buf tracking From: Chenbo Feng To: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org Cc: Sumit Semwal , erickreyes@google.com, Chenbo Feng Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Currently, all dma-bufs share the same anonymous inode. While we can count how many dma-buf fds or mappings a process has, we can't get the size of the backing buffers or tell if two entries point to the same dma-buf. And in debugfs, we can get a per-buffer breakdown of size and reference count, but can't tell which processes are actually holding the references to each buffer. To resolve the issue above and provide better method for userspace to track the dma-buf usage across different processes, the following changes are proposed in dma-buf kernel side. First of all, replace the singleton inode inside the dma-buf subsystem with a mini-filesystem, and assign each dma-buf a unique inode out of this filesystem. With this change, calling stat(2) on each entry gives the caller a unique ID (st_ino), the buffer's size (st_size), and even the number of pages assigned to each dma-buffer. Secoundly, add the inode information to /sys/kernel/debug/dma_buf/bufinfo so in the case where a buffer is mmap()ed into a process’s address space but all remaining fds have been closed, we can still get the dma-buf information and try to accociate it with the process by searching the proc/pid/maps and looking for the corresponding inode number exposed in dma-buf debug fs. Thirdly, created an ioctl to assign names to dma-bufs which lets userspace assign short names (e.g., "CAMERA") to buffers. This information can be extremely helpful for tracking and accounting shared buffers based on their usage and original purpose. Last but not least, add dma-buf information to /proc/pid/fdinfo by adding a show_fdinfo() handler to dma_buf_file_operations. The handler will print the file_count and name of each buffer. Greg Hackmann (3): dma-buf: give each buffer a full-fledged inode dma-buf: add DMA_BUF_{GET,SET}_NAME ioctls dma-buf: add show_fdinfo handler drivers/dma-buf/dma-buf.c | 121 ++++++++++++++++++++++++++++++++--- include/linux/dma-buf.h | 5 +- include/uapi/linux/dma-buf.h | 4 ++ include/uapi/linux/magic.h | 1 + 4 files changed, 122 insertions(+), 9 deletions(-)